Hi Richard
> > As I mentioned in v3, adding *general* pll to common card driver is
> > maybe difficult.
>
> You did say that. But you did not say why.
> Can you be more specific about what problem you see with adding it
> to the generic driver?
>
> > Using your own customized audio-graph-card driver is better idea,
> > instead of adding code to common driver.
>
> I just don't want to duplicate code without good reason.
Ahh, sorry for my unclear comment.
I think "PLL settings" is very board/platform specific,
so, adding such code to common driver will be issue in the future.
This is the reason why I don't want add it to audio-graph-card.
But, as I mentioned above and Sameer is already doing,
you can reuse audio-graph-card and customize it.
Reuse audio-graph-card + Use your own PLL code
= your own customized audio-graph-card
You can reuse audio-graph-card code by calling graph_parse_of(),
and customize before/after that.
I think no duplicate code is needed.
I hope it can help you.
Thank you for your help !!
Best regards
---
Kuninori Morimoto
On Wed, Jan 13, 2021 at 09:00:19AM +0900, Kuninori Morimoto wrote:
> Ahh, sorry for my unclear comment.
> I think "PLL settings" is very board/platform specific,
> so, adding such code to common driver will be issue in the future.
> This is the reason why I don't want add it to audio-graph-card.
I don't think it's *that* weird, they're a fairly common feature of
devices and in terms of integration aren't particularly different to
sysclks, though this is for more complex CODECs.