2013-04-06 03:52:10

by Wei Yongjun

Subject: [PATCH -next] virtio_console: make local symbols static

From: Wei Yongjun <[email protected]>

Those symbols only used within this file, and should be static.

Signed-off-by: Wei Yongjun <[email protected]>
---
drivers/char/virtio_console.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c
index 13ad9b1..f73ad64 100644
--- a/drivers/char/virtio_console.c
+++ b/drivers/char/virtio_console.c
@@ -78,8 +78,8 @@ struct ports_driver_data {
};
static struct ports_driver_data pdrvdata;

-DEFINE_SPINLOCK(pdrvdata_lock);
-DECLARE_COMPLETION(early_console_added);
+static DEFINE_SPINLOCK(pdrvdata_lock);
+static DECLARE_COMPLETION(early_console_added);

/* This struct holds information that's relevant only for console ports */
struct console {
@@ -1202,7 +1202,7 @@ int __init virtio_cons_early_init(int (*put_chars)(u32, const char *, int))
return hvc_instantiate(0, 0, &hv_ops);
}

-int init_port_console(struct port *port)
+static int init_port_console(struct port *port)
{
int ret;

2013-04-08 05:54:13

by Amit Shah

Subject: Re: [PATCH -next] virtio_console: make local symbols static

On (Sat) 06 Apr 2013 [11:52:07], Wei Yongjun wrote:
> From: Wei Yongjun <[email protected]>
>
> Those symbols only used within this file, and should be static.
>
> Signed-off-by: Wei Yongjun <[email protected]>

Acked-by: Amit Shah <[email protected]>

Amit

2013-04-08 14:28:42

by Rusty Russell

Subject: Re: [PATCH -next] virtio_console: make local symbols static

Amit Shah <[email protected]> writes:

> On (Sat) 06 Apr 2013 [11:52:07], Wei Yongjun wrote:
>> From: Wei Yongjun <[email protected]>
>>
>> Those symbols only used within this file, and should be static.
>>
>> Signed-off-by: Wei Yongjun <[email protected]>
>
> Acked-by: Amit Shah <[email protected]>
>
> Amit

Thanks, applied.

Cheers,
Rusty.