2012-08-25 08:24:28

by Namjae Jeon

Subject: [PATCH 1/2] fat: kill unused macros

Remove unused macros.

Signed-off-by: Namjae Jeon <[email protected]>
Signed-off-by: Amit Sahrawat <[email protected]>
---
include/linux/msdos_fs.h | 12 ------------
1 file changed, 12 deletions(-)

diff --git a/include/linux/msdos_fs.h b/include/linux/msdos_fs.h
index 11cc2ac..be3dc72 100644
--- a/include/linux/msdos_fs.h
+++ b/include/linux/msdos_fs.h
@@ -9,18 +9,6 @@
* The MS-DOS filesystem constants/structures
*/

-#define SECTOR_SIZE 512 /* sector size (bytes) */
-#define SECTOR_BITS 9 /* log2(SECTOR_SIZE) */
-#define MSDOS_DPB (MSDOS_DPS) /* dir entries per block */
-#define MSDOS_DPB_BITS 4 /* log2(MSDOS_DPB) */
-#define MSDOS_DPS (SECTOR_SIZE / sizeof(struct msdos_dir_entry))
-#define MSDOS_DPS_BITS 4 /* log2(MSDOS_DPS) */
-#define MSDOS_LONGNAME 256 /* maximum name length */
-#define CF_LE_W(v) le16_to_cpu(v)
-#define CF_LE_L(v) le32_to_cpu(v)
-#define CT_LE_W(v) cpu_to_le16(v)
-#define CT_LE_L(v) cpu_to_le32(v)
-
#define MSDOS_ROOT_INO 1 /* The root inode number */
#define MSDOS_FSINFO_INO 2 /* Used for managing the FSINFO block */

--
1.7.9.5

2012-08-26 13:58:55

by OGAWA Hirofumi

Subject: Re: [PATCH 1/2] fat: kill unused macros

Namjae Jeon <[email protected]> writes:

> Remove unused macros.

Those are for userland. Are you sure userland doesn't use those anymore?

> Signed-off-by: Namjae Jeon <[email protected]>
> Signed-off-by: Amit Sahrawat <[email protected]>
> ---
> include/linux/msdos_fs.h | 12 ------------
> 1 file changed, 12 deletions(-)
>
> diff --git a/include/linux/msdos_fs.h b/include/linux/msdos_fs.h
> index 11cc2ac..be3dc72 100644
> --- a/include/linux/msdos_fs.h
> +++ b/include/linux/msdos_fs.h
> @@ -9,18 +9,6 @@
> * The MS-DOS filesystem constants/structures
> */
>
> -#define SECTOR_SIZE 512 /* sector size (bytes) */
> -#define SECTOR_BITS 9 /* log2(SECTOR_SIZE) */
> -#define MSDOS_DPB (MSDOS_DPS) /* dir entries per block */
> -#define MSDOS_DPB_BITS 4 /* log2(MSDOS_DPB) */
> -#define MSDOS_DPS (SECTOR_SIZE / sizeof(struct msdos_dir_entry))
> -#define MSDOS_DPS_BITS 4 /* log2(MSDOS_DPS) */
> -#define MSDOS_LONGNAME 256 /* maximum name length */
> -#define CF_LE_W(v) le16_to_cpu(v)
> -#define CF_LE_L(v) le32_to_cpu(v)
> -#define CT_LE_W(v) cpu_to_le16(v)
> -#define CT_LE_L(v) cpu_to_le32(v)
> -
> #define MSDOS_ROOT_INO 1 /* The root inode number */
> #define MSDOS_FSINFO_INO 2 /* Used for managing the FSINFO block */

--
OGAWA Hirofumi <[email protected]>

2012-08-27 01:24:12

by Namjae Jeon

Subject: Re: [PATCH 1/2] fat: kill unused macros

2012/8/26, OGAWA Hirofumi <[email protected]>:
> Namjae Jeon <[email protected]> writes:
>
>> Remove unused macros.
>
> Those are for userland. Are you sure userland doesn't use those anymore?
Hi. OGAWA.
I missed this point. I will repost if I can be sure.
Thanks a lot.
>
>> Signed-off-by: Namjae Jeon <[email protected]>
>> Signed-off-by: Amit Sahrawat <[email protected]>
>> ---
>> include/linux/msdos_fs.h | 12 ------------
>> 1 file changed, 12 deletions(-)
>>
>> diff --git a/include/linux/msdos_fs.h b/include/linux/msdos_fs.h
>> index 11cc2ac..be3dc72 100644
>> --- a/include/linux/msdos_fs.h
>> +++ b/include/linux/msdos_fs.h
>> @@ -9,18 +9,6 @@
>> * The MS-DOS filesystem constants/structures
>> */
>>
>> -#define SECTOR_SIZE 512 /* sector size (bytes) */
>> -#define SECTOR_BITS 9 /* log2(SECTOR_SIZE) */
>> -#define MSDOS_DPB (MSDOS_DPS) /* dir entries per block */
>> -#define MSDOS_DPB_BITS 4 /* log2(MSDOS_DPB) */
>> -#define MSDOS_DPS (SECTOR_SIZE / sizeof(struct msdos_dir_entry))
>> -#define MSDOS_DPS_BITS 4 /* log2(MSDOS_DPS) */
>> -#define MSDOS_LONGNAME 256 /* maximum name length */
>> -#define CF_LE_W(v) le16_to_cpu(v)
>> -#define CF_LE_L(v) le32_to_cpu(v)
>> -#define CT_LE_W(v) cpu_to_le16(v)
>> -#define CT_LE_L(v) cpu_to_le32(v)
>> -
>> #define MSDOS_ROOT_INO 1 /* The root inode number */
>> #define MSDOS_FSINFO_INO 2 /* Used for managing the FSINFO block */
>
> --
> OGAWA Hirofumi <[email protected]>
>