Hello.
This is a small fix of a typo (or, more specifically, some remnant of
the old patch version spelling) in RWH_WRITE_LIFE_NOT_SET constant,
which is named as RWF_WRITE_LIFE_NOT_SET currently. Since the name
with "H" is used in man page and everywhere else, it's probably worth
to make the name used in the fcntl.h UAPI header in line with it.
The two follow-up patches update usage sites of this constant in kernel
to use the new spelling.
The old name is retained as it is part of UAPI now.
Changes since v2[1]:
* Updated RWF_WRITE_LIFE_NOT_SET constant usage
in drivers/md/raid5-ppl.c:ppl_init_log().
Changes since v1[2]:
* Changed format of the commit ID in the commit message of the first patch.
* Removed bogus Signed-off-by that snuck into the resend of the series.
[1] https://lkml.org/lkml/2018/10/30/34
[2] https://lkml.org/lkml/2018/10/26/88
Eugene Syromiatnikov (3):
fcntl: fix typo in RWH_WRITE_LIFE_NOT_SET r/w hint name
drivers/md/raid5.c: use the new spelling of RWH_WRITE_LIFE_NOT_SET
drivers/md/raid5-ppl.c: use the new spelling of RWH_WRITE_LIFE_NOT_SET
drivers/md/raid5-ppl.c | 2 +-
drivers/md/raid5.c | 4 ++--
fs/fcntl.c | 2 +-
include/uapi/linux/fcntl.h | 9 ++++++++-
tools/include/uapi/linux/fcntl.h | 9 ++++++++-
5 files changed, 20 insertions(+), 6 deletions(-)
--
2.1.4
As it is consistent with prefixes of other write life time hints.
Signed-off-by: Eugene Syromiatnikov <[email protected]>
---
drivers/md/raid5-ppl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/md/raid5-ppl.c b/drivers/md/raid5-ppl.c
index 18a4064..cab5b13 100644
--- a/drivers/md/raid5-ppl.c
+++ b/drivers/md/raid5-ppl.c
@@ -1404,7 +1404,7 @@ int ppl_init_log(struct r5conf *conf)
atomic64_set(&ppl_conf->seq, 0);
INIT_LIST_HEAD(&ppl_conf->no_mem_stripes);
spin_lock_init(&ppl_conf->no_mem_stripes_lock);
- ppl_conf->write_hint = RWF_WRITE_LIFE_NOT_SET;
+ ppl_conf->write_hint = RWH_WRITE_LIFE_NOT_SET;
if (!mddev->external) {
ppl_conf->signature = ~crc32c_le(~0, mddev->uuid, sizeof(mddev->uuid));
--
2.1.4
On Fri, Sep 20, 2019 at 8:58 AM Eugene Syromiatnikov <[email protected]> wrote:
>
> Hello.
>
> This is a small fix of a typo (or, more specifically, some remnant of
> the old patch version spelling) in RWH_WRITE_LIFE_NOT_SET constant,
> which is named as RWF_WRITE_LIFE_NOT_SET currently. Since the name
> with "H" is used in man page and everywhere else, it's probably worth
> to make the name used in the fcntl.h UAPI header in line with it.
> The two follow-up patches update usage sites of this constant in kernel
> to use the new spelling.
>
> The old name is retained as it is part of UAPI now.
>
> Changes since v2[1]:
> * Updated RWF_WRITE_LIFE_NOT_SET constant usage
> in drivers/md/raid5-ppl.c:ppl_init_log().
>
> Changes since v1[2]:
> * Changed format of the commit ID in the commit message of the first patch.
> * Removed bogus Signed-off-by that snuck into the resend of the series.
Applied to md-next.
Thanks,
Song
On 10/1/19 5:12 PM, Song Liu wrote:
> On Fri, Sep 20, 2019 at 8:58 AM Eugene Syromiatnikov <[email protected]> wrote:
>>
>> Hello.
>>
>> This is a small fix of a typo (or, more specifically, some remnant of
>> the old patch version spelling) in RWH_WRITE_LIFE_NOT_SET constant,
>> which is named as RWF_WRITE_LIFE_NOT_SET currently. Since the name
>> with "H" is used in man page and everywhere else, it's probably worth
>> to make the name used in the fcntl.h UAPI header in line with it.
>> The two follow-up patches update usage sites of this constant in kernel
>> to use the new spelling.
>>
>> The old name is retained as it is part of UAPI now.
>>
>> Changes since v2[1]:
>> * Updated RWF_WRITE_LIFE_NOT_SET constant usage
>> in drivers/md/raid5-ppl.c:ppl_init_log().
>>
>> Changes since v1[2]:
>> * Changed format of the commit ID in the commit message of the first patch.
>> * Removed bogus Signed-off-by that snuck into the resend of the series.
>
> Applied to md-next.
I think the core fs change should core in through a core tree, then
the md bits can go in at will after that.
--
Jens Axboe
On Tue, Oct 1, 2019 at 5:55 PM Jens Axboe <[email protected]> wrote:
>
> On 10/1/19 5:12 PM, Song Liu wrote:
> > On Fri, Sep 20, 2019 at 8:58 AM Eugene Syromiatnikov <[email protected]> wrote:
> >>
> >> Hello.
> >>
> >> This is a small fix of a typo (or, more specifically, some remnant of
> >> the old patch version spelling) in RWH_WRITE_LIFE_NOT_SET constant,
> >> which is named as RWF_WRITE_LIFE_NOT_SET currently. Since the name
> >> with "H" is used in man page and everywhere else, it's probably worth
> >> to make the name used in the fcntl.h UAPI header in line with it.
> >> The two follow-up patches update usage sites of this constant in kernel
> >> to use the new spelling.
> >>
> >> The old name is retained as it is part of UAPI now.
> >>
> >> Changes since v2[1]:
> >> * Updated RWF_WRITE_LIFE_NOT_SET constant usage
> >> in drivers/md/raid5-ppl.c:ppl_init_log().
> >>
> >> Changes since v1[2]:
> >> * Changed format of the commit ID in the commit message of the first patch.
> >> * Removed bogus Signed-off-by that snuck into the resend of the series.
> >
> > Applied to md-next.
>
> I think the core fs change should core in through a core tree, then
> the md bits can go in at will after that.
Good point. I guess I will wait until it shows up in for-5.5/block?
Song
Hi Jeff and J. Bruce,
On Wed, Oct 2, 2019 at 9:55 AM Song Liu <[email protected]> wrote:
>
> On Tue, Oct 1, 2019 at 5:55 PM Jens Axboe <[email protected]> wrote:
> >
> > On 10/1/19 5:12 PM, Song Liu wrote:
> > > On Fri, Sep 20, 2019 at 8:58 AM Eugene Syromiatnikov <[email protected]> wrote:
> > >>
> > >> Hello.
> > >>
> > >> This is a small fix of a typo (or, more specifically, some remnant of
> > >> the old patch version spelling) in RWH_WRITE_LIFE_NOT_SET constant,
> > >> which is named as RWF_WRITE_LIFE_NOT_SET currently. Since the name
> > >> with "H" is used in man page and everywhere else, it's probably worth
> > >> to make the name used in the fcntl.h UAPI header in line with it.
> > >> The two follow-up patches update usage sites of this constant in kernel
> > >> to use the new spelling.
> > >>
> > >> The old name is retained as it is part of UAPI now.
> > >>
> > >> Changes since v2[1]:
> > >> * Updated RWF_WRITE_LIFE_NOT_SET constant usage
> > >> in drivers/md/raid5-ppl.c:ppl_init_log().
> > >>
> > >> Changes since v1[2]:
> > >> * Changed format of the commit ID in the commit message of the first patch.
> > >> * Removed bogus Signed-off-by that snuck into the resend of the series.
> > >
> > > Applied to md-next.
> >
> > I think the core fs change should core in through a core tree, then
> > the md bits can go in at will after that.
As Jens suggested, we should route core fs patches through core tree. Could
you please apply these patches? Since the change is small, probably you can
also apply md patches?
Thanks,
Song
PS: for the series:
Acked-by: Song Liu <[email protected]>
On 10/16/19 11:00 AM, Song Liu wrote:
> Hi Jeff and J. Bruce,
>
> On Wed, Oct 2, 2019 at 9:55 AM Song Liu <[email protected]> wrote:
>>
>> On Tue, Oct 1, 2019 at 5:55 PM Jens Axboe <[email protected]> wrote:
>>>
>>> On 10/1/19 5:12 PM, Song Liu wrote:
>>>> On Fri, Sep 20, 2019 at 8:58 AM Eugene Syromiatnikov <[email protected]> wrote:
>>>>>
>>>>> Hello.
>>>>>
>>>>> This is a small fix of a typo (or, more specifically, some remnant of
>>>>> the old patch version spelling) in RWH_WRITE_LIFE_NOT_SET constant,
>>>>> which is named as RWF_WRITE_LIFE_NOT_SET currently. Since the name
>>>>> with "H" is used in man page and everywhere else, it's probably worth
>>>>> to make the name used in the fcntl.h UAPI header in line with it.
>>>>> The two follow-up patches update usage sites of this constant in kernel
>>>>> to use the new spelling.
>>>>>
>>>>> The old name is retained as it is part of UAPI now.
>>>>>
>>>>> Changes since v2[1]:
>>>>> * Updated RWF_WRITE_LIFE_NOT_SET constant usage
>>>>> in drivers/md/raid5-ppl.c:ppl_init_log().
>>>>>
>>>>> Changes since v1[2]:
>>>>> * Changed format of the commit ID in the commit message of the first patch.
>>>>> * Removed bogus Signed-off-by that snuck into the resend of the series.
>>>>
>>>> Applied to md-next.
>>>
>>> I think the core fs change should core in through a core tree, then
>>> the md bits can go in at will after that.
>
> As Jens suggested, we should route core fs patches through core tree. Could
> you please apply these patches? Since the change is small, probably you can
> also apply md patches?
>
> Thanks,
> Song
>
> PS: for the series:
>
> Acked-by: Song Liu <[email protected]>
I applied 1/3 to the for-5.5/block core branch.
--
Jens Axboe