2008-06-14 02:18:21

by Paul Collins

Subject: [PATCH] udf: restore UDFFS_DEBUG to being undefined by default

Commit 706047a79725b585cf272fdefc234b31b6545c72, "udf: Fix compilation
warnings when UDF debug is on" inadvertently (I assume) enabled
debugging messages by default for UDF. This patch disables them again.

Signed-off-by: Paul Collins <[email protected]>

diff --git a/fs/udf/udfdecl.h b/fs/udf/udfdecl.h
index 8fa9c2d..8ec865d 100644
--- a/fs/udf/udfdecl.h
+++ b/fs/udf/udfdecl.h
@@ -16,7 +16,7 @@
#define UDF_PREALLOCATE
#define UDF_DEFAULT_PREALLOC_BLOCKS 8

-#define UDFFS_DEBUG
+#undef UDFFS_DEBUG

#ifdef UDFFS_DEBUG
#define udf_debug(f, a...) \


--
Paul Collins
Wellington, New Zealand

Dag vijandelijk luchtschip de huismeester is dood

2008-06-16 12:08:45

by Jan Kara

Subject: Re: [PATCH] udf: restore UDFFS_DEBUG to being undefined by default

On Sat 14-06-08 14:14:59, Paul Collins wrote:
> Commit 706047a79725b585cf272fdefc234b31b6545c72, "udf: Fix compilation
> warnings when UDF debug is on" inadvertently (I assume) enabled
> debugging messages by default for UDF. This patch disables them again.
Oops, yes. Thanks for catching this. I'll merge the patch.

> Signed-off-by: Paul Collins <[email protected]>
>
> diff --git a/fs/udf/udfdecl.h b/fs/udf/udfdecl.h
> index 8fa9c2d..8ec865d 100644
> --- a/fs/udf/udfdecl.h
> +++ b/fs/udf/udfdecl.h
> @@ -16,7 +16,7 @@
> #define UDF_PREALLOCATE
> #define UDF_DEFAULT_PREALLOC_BLOCKS 8
>
> -#define UDFFS_DEBUG
> +#undef UDFFS_DEBUG
>
> #ifdef UDFFS_DEBUG
> #define udf_debug(f, a...) \

Honza

PS: Sorry for the bounce you probably got. I had misconfigured my mail
system for a while...
--
Jan Kara <[email protected]>
SUSE Labs, CR