2021-04-08 13:56:33

by Chen Hui

Subject: [PATCH -next] clk: qcom: Add missing MODULE_DEVICE_TABLE

Add missing MODULE_DEVICE_TABLE entries to support module autoloading,
as these drivers can be compiled as external modules.

Signed-off-by: Chen Hui <[email protected]>
---
drivers/clk/qcom/a53-pll.c | 1 +
drivers/clk/qcom/a7-pll.c | 1 +
drivers/clk/qcom/apss-ipq-pll.c | 1 +
3 files changed, 3 insertions(+)

diff --git a/drivers/clk/qcom/a53-pll.c b/drivers/clk/qcom/a53-pll.c
index 45cfc57bff92..af6ac17c7dae 100644
--- a/drivers/clk/qcom/a53-pll.c
+++ b/drivers/clk/qcom/a53-pll.c
@@ -93,6 +93,7 @@ static const struct of_device_id qcom_a53pll_match_table[] = {
{ .compatible = "qcom,msm8916-a53pll" },
{ }
};
+MODULE_DEVICE_TABLE(of, qcom_a53pll_match_table);

static struct platform_driver qcom_a53pll_driver = {
.probe = qcom_a53pll_probe,
diff --git a/drivers/clk/qcom/a7-pll.c b/drivers/clk/qcom/a7-pll.c
index e171d3caf2cf..c4a53e5db229 100644
--- a/drivers/clk/qcom/a7-pll.c
+++ b/drivers/clk/qcom/a7-pll.c
@@ -86,6 +86,7 @@ static const struct of_device_id qcom_a7pll_match_table[] = {
{ .compatible = "qcom,sdx55-a7pll" },
{ }
};
+MODULE_DEVICE_TABLE(of, qcom_a7pll_match_table);

static struct platform_driver qcom_a7pll_driver = {
.probe = qcom_a7pll_probe,
diff --git a/drivers/clk/qcom/apss-ipq-pll.c b/drivers/clk/qcom/apss-ipq-pll.c
index 30be87fb222a..bef7899ad0d6 100644
--- a/drivers/clk/qcom/apss-ipq-pll.c
+++ b/drivers/clk/qcom/apss-ipq-pll.c
@@ -81,6 +81,7 @@ static const struct of_device_id apss_ipq_pll_match_table[] = {
{ .compatible = "qcom,ipq6018-a53pll" },
{ }
};
+MODULE_DEVICE_TABLE(of, apss_ipq_pll_match_table);

static struct platform_driver apss_ipq_pll_driver = {
.probe = apss_ipq_pll_probe,
--
2.17.1

2021-04-08 20:31:37

by Stephen Boyd

Subject: Re: [PATCH -next] clk: qcom: Add missing MODULE_DEVICE_TABLE

Quoting Chen Hui (2021-04-08 06:55:09)
> Add missing MODULE_DEVICE_TABLE entries to support module autoloading,
> as these drivers can be compiled as external modules.
>
> Signed-off-by: Chen Hui <[email protected]>

Any fixes tag?

2021-04-09 01:52:13

by Chen Hui

Subject: Re: [PATCH -next] clk: qcom: Add missing MODULE_DEVICE_TABLE

在 2021/4/9 4:30, Stephen Boyd 写道:

> Quoting Chen Hui (2021-04-08 06:55:09)
>> Add missing MODULE_DEVICE_TABLE entries to support module autoloading,
>> as these drivers can be compiled as external modules.
>>
>> Signed-off-by: Chen Hui <[email protected]>
> Any fixes tag?
> .

Thanks for reviewing, fixes tags will be added in v2 patches, which I
will send out later

2021-04-09 06:24:00

by Manivannan Sadhasivam

Subject: Re: [PATCH -next] clk: qcom: Add missing MODULE_DEVICE_TABLE

On Thu, Apr 08, 2021 at 09:55:09PM +0800, Chen Hui wrote:
> Add missing MODULE_DEVICE_TABLE entries to support module autoloading,
> as these drivers can be compiled as external modules.
>
> Signed-off-by: Chen Hui <[email protected]>

Reviewed-by: Manivannan Sadhasivam <[email protected]>

Thanks,
Mani

> ---
> drivers/clk/qcom/a53-pll.c | 1 +
> drivers/clk/qcom/a7-pll.c | 1 +
> drivers/clk/qcom/apss-ipq-pll.c | 1 +
> 3 files changed, 3 insertions(+)
>
> diff --git a/drivers/clk/qcom/a53-pll.c b/drivers/clk/qcom/a53-pll.c
> index 45cfc57bff92..af6ac17c7dae 100644
> --- a/drivers/clk/qcom/a53-pll.c
> +++ b/drivers/clk/qcom/a53-pll.c
> @@ -93,6 +93,7 @@ static const struct of_device_id qcom_a53pll_match_table[] = {
> { .compatible = "qcom,msm8916-a53pll" },
> { }
> };
> +MODULE_DEVICE_TABLE(of, qcom_a53pll_match_table);
>
> static struct platform_driver qcom_a53pll_driver = {
> .probe = qcom_a53pll_probe,
> diff --git a/drivers/clk/qcom/a7-pll.c b/drivers/clk/qcom/a7-pll.c
> index e171d3caf2cf..c4a53e5db229 100644
> --- a/drivers/clk/qcom/a7-pll.c
> +++ b/drivers/clk/qcom/a7-pll.c
> @@ -86,6 +86,7 @@ static const struct of_device_id qcom_a7pll_match_table[] = {
> { .compatible = "qcom,sdx55-a7pll" },
> { }
> };
> +MODULE_DEVICE_TABLE(of, qcom_a7pll_match_table);
>
> static struct platform_driver qcom_a7pll_driver = {
> .probe = qcom_a7pll_probe,
> diff --git a/drivers/clk/qcom/apss-ipq-pll.c b/drivers/clk/qcom/apss-ipq-pll.c
> index 30be87fb222a..bef7899ad0d6 100644
> --- a/drivers/clk/qcom/apss-ipq-pll.c
> +++ b/drivers/clk/qcom/apss-ipq-pll.c
> @@ -81,6 +81,7 @@ static const struct of_device_id apss_ipq_pll_match_table[] = {
> { .compatible = "qcom,ipq6018-a53pll" },
> { }
> };
> +MODULE_DEVICE_TABLE(of, apss_ipq_pll_match_table);
>
> static struct platform_driver apss_ipq_pll_driver = {
> .probe = apss_ipq_pll_probe,
> --
> 2.17.1
>