2022-09-16 10:20:02

by Tiezhu Yang

Subject: [PATCH] docs, kprobes: Fix the wrong location of Kprobes

After commit 22471e1313f2 ("kconfig: use a menu in arch/Kconfig to reduce
clutter"), the location of Kprobes is under "General architecture-dependent
options" rather than "General setup".

Signed-off-by: Tiezhu Yang <[email protected]>
---
Documentation/trace/kprobes.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/trace/kprobes.rst b/Documentation/trace/kprobes.rst
index f318bce..48cf778 100644
--- a/Documentation/trace/kprobes.rst
+++ b/Documentation/trace/kprobes.rst
@@ -328,8 +328,8 @@ Configuring Kprobes
===================

When configuring the kernel using make menuconfig/xconfig/oldconfig,
-ensure that CONFIG_KPROBES is set to "y". Under "General setup", look
-for "Kprobes".
+ensure that CONFIG_KPROBES is set to "y", look for "Kprobes" under
+"General architecture-dependent options".

So that you can load and unload Kprobes-based instrumentation modules,
make sure "Loadable module support" (CONFIG_MODULES) and "Module
--
2.1.0

2022-09-26 19:03:58

by Steven Rostedt

Subject: Re: [PATCH] docs, kprobes: Fix the wrong location of Kprobes

On Fri, 16 Sep 2022 17:55:06 +0800
Tiezhu Yang <[email protected]> wrote:

> After commit 22471e1313f2 ("kconfig: use a menu in arch/Kconfig to reduce
> clutter"), the location of Kprobes is under "General architecture-dependent
> options" rather than "General setup".
>

Probably add a "Fixes:" tag for the above mentioned commit.

Anyway, Acked-by: Steven Rostedt (Google) <[email protected]>

-- Steve


> Signed-off-by: Tiezhu Yang <[email protected]>
> ---
> Documentation/trace/kprobes.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/trace/kprobes.rst b/Documentation/trace/kprobes.rst
> index f318bce..48cf778 100644
> --- a/Documentation/trace/kprobes.rst
> +++ b/Documentation/trace/kprobes.rst
> @@ -328,8 +328,8 @@ Configuring Kprobes
> ===================
>
> When configuring the kernel using make menuconfig/xconfig/oldconfig,
> -ensure that CONFIG_KPROBES is set to "y". Under "General setup", look
> -for "Kprobes".
> +ensure that CONFIG_KPROBES is set to "y", look for "Kprobes" under
> +"General architecture-dependent options".
>
> So that you can load and unload Kprobes-based instrumentation modules,
> make sure "Loadable module support" (CONFIG_MODULES) and "Module

2022-09-29 10:41:22

by Tiezhu Yang

Subject: Re: [PATCH] docs, kprobes: Fix the wrong location of Kprobes

On 09/27/2022 02:22 AM, Steven Rostedt wrote:
> On Fri, 16 Sep 2022 17:55:06 +0800
> Tiezhu Yang <[email protected]> wrote:
>
>> After commit 22471e1313f2 ("kconfig: use a menu in arch/Kconfig to reduce
>> clutter"), the location of Kprobes is under "General architecture-dependent
>> options" rather than "General setup".
>>
>
> Probably add a "Fixes:" tag for the above mentioned commit.
>
> Anyway, Acked-by: Steven Rostedt (Google) <[email protected]>


Thank you.

Do you know which tree this patch will go through?
Is it necessary to send v2 with "Fixes:" tag?

Thanks,
Tiezhu

>
> -- Steve
>
>
>> Signed-off-by: Tiezhu Yang <[email protected]>
>> ---
>> Documentation/trace/kprobes.rst | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/trace/kprobes.rst b/Documentation/trace/kprobes.rst
>> index f318bce..48cf778 100644
>> --- a/Documentation/trace/kprobes.rst
>> +++ b/Documentation/trace/kprobes.rst
>> @@ -328,8 +328,8 @@ Configuring Kprobes
>> ===================
>>
>> When configuring the kernel using make menuconfig/xconfig/oldconfig,
>> -ensure that CONFIG_KPROBES is set to "y". Under "General setup", look
>> -for "Kprobes".
>> +ensure that CONFIG_KPROBES is set to "y", look for "Kprobes" under
>> +"General architecture-dependent options".
>>
>> So that you can load and unload Kprobes-based instrumentation modules,
>> make sure "Loadable module support" (CONFIG_MODULES) and "Module

2022-09-29 13:37:41

by Steven Rostedt

Subject: Re: [PATCH] docs, kprobes: Fix the wrong location of Kprobes

On Thu, 29 Sep 2022 18:01:01 +0800
Tiezhu Yang <[email protected]> wrote:

> On 09/27/2022 02:22 AM, Steven Rostedt wrote:
> > On Fri, 16 Sep 2022 17:55:06 +0800
> > Tiezhu Yang <[email protected]> wrote:
> >
> >> After commit 22471e1313f2 ("kconfig: use a menu in arch/Kconfig to reduce
> >> clutter"), the location of Kprobes is under "General architecture-dependent
> >> options" rather than "General setup".
> >>
> >
> > Probably add a "Fixes:" tag for the above mentioned commit.
> >
> > Anyway, Acked-by: Steven Rostedt (Google) <[email protected]>
>
>
> Thank you.
>
> Do you know which tree this patch will go through?

I believe that Jon can take it through his documentation tree.

> Is it necessary to send v2 with "Fixes:" tag?

No, Jon could add it.

Thanks,

-- Steve

2022-09-29 19:52:36

by Jonathan Corbet

Subject: Re: [PATCH] docs, kprobes: Fix the wrong location of Kprobes

Steven Rostedt <[email protected]> writes:

> On Fri, 16 Sep 2022 17:55:06 +0800
> Tiezhu Yang <[email protected]> wrote:
>
>> After commit 22471e1313f2 ("kconfig: use a menu in arch/Kconfig to reduce
>> clutter"), the location of Kprobes is under "General architecture-dependent
>> options" rather than "General setup".
>>
>
> Probably add a "Fixes:" tag for the above mentioned commit.
>
> Anyway, Acked-by: Steven Rostedt (Google) <[email protected]>

When you embed a tag like that, b4 doesn't pick it up anymore...but I
was amending the commit to add the Fixes tag so I put it in too...:)

Applied, thanks.

jon