2012-11-19 06:42:49

by Shubhrajyoti D

Subject: [PATCH] spi: omap2-mcspi: Fix the redifine warning

Fix the below warning
drivers/spi/spi-omap2-mcspi.c:336:34: warning: symbol 'tx' shadows an earlier one
drivers/spi/spi-omap2-mcspi.c:327:12: originally declared here

So delete the u8 tx as it is assigned and not used(resigned afterwards).

Signed-off-by: Shubhrajyoti D <[email protected]>
---
drivers/spi/spi-omap2-mcspi.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/drivers/spi/spi-omap2-mcspi.c b/drivers/spi/spi-omap2-mcspi.c
index 251f6d0..c3dcfb3 100644
--- a/drivers/spi/spi-omap2-mcspi.c
+++ b/drivers/spi/spi-omap2-mcspi.c
@@ -323,14 +323,11 @@ static void omap2_mcspi_tx_dma(struct spi_device *spi,
struct omap2_mcspi *mcspi;
struct omap2_mcspi_dma *mcspi_dma;
unsigned int count;
- const u8 * tx;

mcspi = spi_master_get_devdata(spi->master);
mcspi_dma = &mcspi->dma_channels[spi->chip_select];
count = xfer->len;

- tx = xfer->tx_buf;
-
if (mcspi_dma->dma_tx) {
struct dma_async_tx_descriptor *tx;
struct scatterlist sg;
--
1.7.5.4

2012-11-19 10:33:36

by Peter Korsgaard

Subject: Re: [PATCH] spi: omap2-mcspi: Fix the redifine warning

>>>>> "Shubhrajyoti" == Shubhrajyoti D <[email protected]> writes:

Shubhrajyoti> Fix the below warning

Shubhrajyoti> drivers/spi/spi-omap2-mcspi.c:336:34: warning: symbol
Shubhrajyoti> 'tx' shadows an earlier one
Shubhrajyoti> drivers/spi/spi-omap2-mcspi.c:327:12: originally declared
Shubhrajyoti> here

Shubhrajyoti> So delete the u8 tx as it is assigned and not
Shubhrajyoti> used(resigned afterwards).

Shubhrajyoti> Signed-off-by: Shubhrajyoti D <[email protected]>

Acked-by: Peter Korsgaard <[email protected]>

--
Bye, Peter Korsgaard