2012-02-03 13:26:28

by Miklos Szeredi

Subject: [PATCH (untested)] vfs: fix d_inode_lookup() dentry ref leak

From: Miklos Szeredi <[email protected]>

d_inode_lookup() appears to leak a dentry reference on IS_DEADDIR().

Signed-off-by: Miklos Szeredi <[email protected]>
CC: [email protected]
---
fs/namei.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

Index: linux-2.6/fs/namei.c
===================================================================
--- linux-2.6.orig/fs/namei.c 2012-02-03 14:14:52.000000000 +0100
+++ linux-2.6/fs/namei.c 2012-02-03 14:15:48.000000000 +0100
@@ -1095,8 +1095,10 @@ static struct dentry *d_inode_lookup(str
struct dentry *old;

/* Don't create child dentry for a dead directory. */
- if (unlikely(IS_DEADDIR(inode)))
+ if (unlikely(IS_DEADDIR(inode))) {
+ dput(dentry);
return ERR_PTR(-ENOENT);
+ }

old = inode->i_op->lookup(inode, dentry, nd);
if (unlikely(old)) {

2012-02-03 13:30:25

by Al Viro

Subject: Re: [PATCH (untested)] vfs: fix d_inode_lookup() dentry ref leak

On Fri, Feb 03, 2012 at 02:25:18PM +0100, Miklos Szeredi wrote:
> From: Miklos Szeredi <[email protected]>
>
> d_inode_lookup() appears to leak a dentry reference on IS_DEADDIR().

Applied.