2024-02-01 22:28:34

by Ivan Orlov

Subject: [PATCH v2] ALSA: core: Fix dependencies for SND_CORE_TEST

Select CONFIG_SND_PCM when enabling CONFIG_SND_CORE_TEST, as the test
uses symbols from 'pcm_misc.c'.

Fixes: 3e39acf56ede ("ALSA: core: Add sound core KUnit test")
Signed-off-by: Ivan Orlov <[email protected]>
---
V1 -> V2:
- Change 'depends' with 'select', as the user can't enable SND_PCM
explicitly.
- Add 'Fixes' tag since it is a regression fix.

sound/core/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/sound/core/Kconfig b/sound/core/Kconfig
index 664c6ee2b5a1..8077f481d84f 100644
--- a/sound/core/Kconfig
+++ b/sound/core/Kconfig
@@ -42,6 +42,7 @@ config SND_UMP_LEGACY_RAWMIDI
config SND_CORE_TEST
tristate "Sound core KUnit test"
depends on KUNIT
+ select SND_PCM
default KUNIT_ALL_TESTS
help
This options enables the sound core functions KUnit test.
--
2.34.1

2024-02-02 08:22:38

by Takashi Iwai

Subject: Re: [PATCH v2] ALSA: core: Fix dependencies for SND_CORE_TEST

On Thu, 01 Feb 2024 23:11:22 +0100,
Ivan Orlov wrote:
>
> Select CONFIG_SND_PCM when enabling CONFIG_SND_CORE_TEST, as the test
> uses symbols from 'pcm_misc.c'.
>
> Fixes: 3e39acf56ede ("ALSA: core: Add sound core KUnit test")
> Signed-off-by: Ivan Orlov <[email protected]>

Thanks, applied now.


Takashi