2022-08-29 09:01:20

by Toke Høiland-Jørgensen

[permalink] [raw]
Subject: Re: [PATCH net-next,v2] net: sched: remove redundant NULL check in change hook function

Zhengchao Shao <[email protected]> writes:

> Currently, the change function can be called by two ways. The one way is
> that qdisc_change() will call it. Before calling change function,
> qdisc_change() ensures tca[TCA_OPTIONS] is not empty. The other way is
> that .init() will call it. The opt parameter is also checked before
> calling change function in .init(). Therefore, it's no need to check the
> input parameter opt in change function.
>
> Signed-off-by: Zhengchao Shao <[email protected]>

for sch_cake:

Acked-by: Toke Høiland-Jørgensen <[email protected]>