2021-08-12 03:35:52

by Chunfeng Yun

Subject: [PATCH 5/6] usb: gadget: bdc: remove unnecessary AND operation when get ep maxp

usb_endpoint_maxp() already returns actual max packet size, no need
AND 0x7ff.

Signed-off-by: Chunfeng Yun <[email protected]>
---
drivers/usb/gadget/udc/bdc/bdc_cmd.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/usb/gadget/udc/bdc/bdc_cmd.c b/drivers/usb/gadget/udc/bdc/bdc_cmd.c
index 995f79c79f96..67887316a1a6 100644
--- a/drivers/usb/gadget/udc/bdc/bdc_cmd.c
+++ b/drivers/usb/gadget/udc/bdc/bdc_cmd.c
@@ -153,7 +153,6 @@ int bdc_config_ep(struct bdc *bdc, struct bdc_ep *ep)
si = clamp_val(si, 1, 16) - 1;

mps = usb_endpoint_maxp(desc);
- mps &= 0x7ff;
param2 |= mps << MP_SHIFT;
param2 |= usb_endpoint_type(desc) << EPT_SHIFT;

--
2.25.1

2021-08-12 06:58:00

by Felipe Balbi

Subject: Re: [PATCH 5/6] usb: gadget: bdc: remove unnecessary AND operation when get ep maxp

Chunfeng Yun <[email protected]> writes:

> usb_endpoint_maxp() already returns actual max packet size, no need
> AND 0x7ff.
>
> Signed-off-by: Chunfeng Yun <[email protected]>

Acked-by: Felipe Balbi <[email protected]>

--
balbi