2021-07-28 09:22:14

by Rikard Falkeborn

Subject: [PATCH] usb: gadget: pxa25x_udc: Constify static struct pxa25x_ep_ops

The struct pxa25x_ep_ops is only assigned to the ops field in the
usb_ep struct, which is a pointer to const struct usb_ep_ops.
Make it const to allow the compiler to put it in read-only memory.

Signed-off-by: Rikard Falkeborn <[email protected]>
---
drivers/usb/gadget/udc/pxa25x_udc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/udc/pxa25x_udc.c b/drivers/usb/gadget/udc/pxa25x_udc.c
index 69ef1e669d0c..a09ec1d826b2 100644
--- a/drivers/usb/gadget/udc/pxa25x_udc.c
+++ b/drivers/usb/gadget/udc/pxa25x_udc.c
@@ -1093,7 +1093,7 @@ static void pxa25x_ep_fifo_flush(struct usb_ep *_ep)
}


-static struct usb_ep_ops pxa25x_ep_ops = {
+static const struct usb_ep_ops pxa25x_ep_ops = {
.enable = pxa25x_ep_enable,
.disable = pxa25x_ep_disable,

--
2.32.0

2021-07-28 09:27:24

by Felipe Balbi

Subject: Re: [PATCH] usb: gadget: pxa25x_udc: Constify static struct pxa25x_ep_ops

Rikard Falkeborn <[email protected]> writes:

> The struct pxa25x_ep_ops is only assigned to the ops field in the
> usb_ep struct, which is a pointer to const struct usb_ep_ops.
> Make it const to allow the compiler to put it in read-only memory.
>
> Signed-off-by: Rikard Falkeborn <[email protected]>

Acked-by: Felipe Balbi <[email protected]>

--
balbi