Since the PWM framework is switching struct pwm_state.duty_cycle's
datatype to u64, prepare for this transition by using DIV_ROUND_UP_ULL
to handle a 64-bit dividend.
Cc: Jani Nikula <[email protected]>
Cc: Joonas Lahtinen <[email protected]>
Cc: David Airlie <[email protected]>
Cc: Daniel Vetter <[email protected]>
Cc: Chris Wilson <[email protected]>
Cc: "Ville Syrjälä" <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: Rodrigo Vivi <[email protected]>
Cc: Maarten Lankhorst <[email protected]>
Signed-off-by: Guru Das Srinagesh <[email protected]>
---
drivers/gpu/drm/i915/display/intel_panel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_panel.c b/drivers/gpu/drm/i915/display/intel_panel.c
index bc14e9c..843cac1 100644
--- a/drivers/gpu/drm/i915/display/intel_panel.c
+++ b/drivers/gpu/drm/i915/display/intel_panel.c
@@ -1868,7 +1868,7 @@ static int pwm_setup_backlight(struct intel_connector *connector,
panel->backlight.min = 0; /* 0% */
panel->backlight.max = 100; /* 100% */
- panel->backlight.level = DIV_ROUND_UP(
+ panel->backlight.level = DIV_ROUND_UP_ULL(
pwm_get_duty_cycle(panel->backlight.pwm) * 100,
CRC_PMIC_PWM_PERIOD_NS);
panel->backlight.enabled = panel->backlight.level != 0;
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
On Tue, 17 Mar 2020, Guru Das Srinagesh <[email protected]> wrote:
> Since the PWM framework is switching struct pwm_state.duty_cycle's
> datatype to u64, prepare for this transition by using DIV_ROUND_UP_ULL
> to handle a 64-bit dividend.
>
> Cc: Jani Nikula <[email protected]>
> Cc: Joonas Lahtinen <[email protected]>
> Cc: David Airlie <[email protected]>
> Cc: Daniel Vetter <[email protected]>
> Cc: Chris Wilson <[email protected]>
> Cc: "Ville Syrjälä" <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Cc: Rodrigo Vivi <[email protected]>
> Cc: Maarten Lankhorst <[email protected]>
>
> Signed-off-by: Guru Das Srinagesh <[email protected]>
Reviewed-by: Jani Nikula <[email protected]>
Also ack for merging this via whichever tree you prefer; please let me
know if you want me to take this via drm-intel.
> ---
> drivers/gpu/drm/i915/display/intel_panel.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_panel.c b/drivers/gpu/drm/i915/display/intel_panel.c
> index bc14e9c..843cac1 100644
> --- a/drivers/gpu/drm/i915/display/intel_panel.c
> +++ b/drivers/gpu/drm/i915/display/intel_panel.c
> @@ -1868,7 +1868,7 @@ static int pwm_setup_backlight(struct intel_connector *connector,
>
> panel->backlight.min = 0; /* 0% */
> panel->backlight.max = 100; /* 100% */
> - panel->backlight.level = DIV_ROUND_UP(
> + panel->backlight.level = DIV_ROUND_UP_ULL(
> pwm_get_duty_cycle(panel->backlight.pwm) * 100,
> CRC_PMIC_PWM_PERIOD_NS);
> panel->backlight.enabled = panel->backlight.level != 0;
--
Jani Nikula, Intel Open Source Graphics Center
On Wed, Mar 18, 2020 at 09:08:45PM +0200, Jani Nikula wrote:
> On Tue, 17 Mar 2020, Guru Das Srinagesh <[email protected]> wrote:
> > Since the PWM framework is switching struct pwm_state.duty_cycle's
> > datatype to u64, prepare for this transition by using DIV_ROUND_UP_ULL
> > to handle a 64-bit dividend.
> >
> > Cc: Jani Nikula <[email protected]>
> > Cc: Joonas Lahtinen <[email protected]>
> > Cc: David Airlie <[email protected]>
> > Cc: Daniel Vetter <[email protected]>
> > Cc: Chris Wilson <[email protected]>
> > Cc: "Ville Syrjälä" <[email protected]>
> > Cc: [email protected]
> > Cc: [email protected]
> > Cc: Rodrigo Vivi <[email protected]>
> > Cc: Maarten Lankhorst <[email protected]>
> >
> > Signed-off-by: Guru Das Srinagesh <[email protected]>
>
> Reviewed-by: Jani Nikula <[email protected]>
Thanks!
> Also ack for merging this via whichever tree you prefer; please let me
> know if you want me to take this via drm-intel.
I'm not sure if this patch can be taken via drm-intel in isolation as it
is part of a series... Will let you know if I need to make such a
request.
Thank you.
Guru Das.