2024-03-20 08:18:22

by Kemeng Shi

[permalink] [raw]
Subject: [PATCH] Documentation: kunit: correct KUNIT_VERY_SLOW to KUNIT_SPEED_VERY_SLOW

There is no KUNIT_VERY_SLOW, I guess we mean KUNIT_SPEED_VERY_SLOW.

Signed-off-by: Kemeng Shi <[email protected]>
---
Documentation/dev-tools/kunit/running_tips.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/dev-tools/kunit/running_tips.rst b/Documentation/dev-tools/kunit/running_tips.rst
index bd689db6fdd2..482f598d141c 100644
--- a/Documentation/dev-tools/kunit/running_tips.rst
+++ b/Documentation/dev-tools/kunit/running_tips.rst
@@ -294,7 +294,7 @@ macro to define the test case instead of ``KUNIT_CASE(test_name)``.
.. code-block:: c

static const struct kunit_attributes example_attr = {
- .speed = KUNIT_VERY_SLOW,
+ .speed = KUNIT_SPEED_VERY_SLOW,
};

static struct kunit_case example_test_cases[] = {
@@ -311,7 +311,7 @@ suite definition.
.. code-block:: c

static const struct kunit_attributes example_attr = {
- .speed = KUNIT_VERY_SLOW,
+ .speed = KUNIT_SPEED_VERY_SLOW,
};

static struct kunit_suite example_test_suite = {
--
2.30.0



2024-03-22 04:12:36

by David Gow

[permalink] [raw]
Subject: Re: [PATCH] Documentation: kunit: correct KUNIT_VERY_SLOW to KUNIT_SPEED_VERY_SLOW

On Wed, 20 Mar 2024 at 16:18, Kemeng Shi <[email protected]> wrote:
>
> There is no KUNIT_VERY_SLOW, I guess we mean KUNIT_SPEED_VERY_SLOW.
>
> Signed-off-by: Kemeng Shi <[email protected]>
> ---

Nice catch, thanks!

Reviewed-by: David Gow <[email protected]>

Cheers,
-- David

> Documentation/dev-tools/kunit/running_tips.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/dev-tools/kunit/running_tips.rst b/Documentation/dev-tools/kunit/running_tips.rst
> index bd689db6fdd2..482f598d141c 100644
> --- a/Documentation/dev-tools/kunit/running_tips.rst
> +++ b/Documentation/dev-tools/kunit/running_tips.rst
> @@ -294,7 +294,7 @@ macro to define the test case instead of ``KUNIT_CASE(test_name)``.
> .. code-block:: c
>
> static const struct kunit_attributes example_attr = {
> - .speed = KUNIT_VERY_SLOW,
> + .speed = KUNIT_SPEED_VERY_SLOW,
> };
>
> static struct kunit_case example_test_cases[] = {
> @@ -311,7 +311,7 @@ suite definition.
> .. code-block:: c
>
> static const struct kunit_attributes example_attr = {
> - .speed = KUNIT_VERY_SLOW,
> + .speed = KUNIT_SPEED_VERY_SLOW,
> };
>
> static struct kunit_suite example_test_suite = {
> --
> 2.30.0
>
> --
> You received this message because you are subscribed to the Google Groups "KUnit Development" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
> To view this discussion on the web visit https://groups.google.com/d/msgid/kunit-dev/20240320171424.6536-1-shikemeng%40huaweicloud.com.

Attachments:
smime.p7s (3.92 kB)
S/MIME Cryptographic Signature

2024-04-02 16:15:47

by Jonathan Corbet

[permalink] [raw]
Subject: Re: [PATCH] Documentation: kunit: correct KUNIT_VERY_SLOW to KUNIT_SPEED_VERY_SLOW

David Gow <[email protected]> writes:

> On Wed, 20 Mar 2024 at 16:18, Kemeng Shi <[email protected]> wrote:
>>
>> There is no KUNIT_VERY_SLOW, I guess we mean KUNIT_SPEED_VERY_SLOW.
>>
>> Signed-off-by: Kemeng Shi <[email protected]>
>> ---
>
> Nice catch, thanks!
>
> Reviewed-by: David Gow <[email protected]>

Let me know if you'd like me to pick this up; otherwise I'm assuming it
will go via the kunit path.

Thanks,

jon