2024-01-26 09:13:20

by Chhayly Leang

[permalink] [raw]
Subject: [PATCH] ALSA: hda: cs35l41: Support ASUS Zenbook UM3402YAR

Adds sound support for ASUS Zenbook UM3402YAR with missing DSD

Signed-off-by: Chhayly Leang <[email protected]>
---
sound/pci/hda/cs35l41_hda_property.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/sound/pci/hda/cs35l41_hda_property.c b/sound/pci/hda/cs35l41_hda_property.c
index 35277ce890a..2af083183d8 100644
--- a/sound/pci/hda/cs35l41_hda_property.c
+++ b/sound/pci/hda/cs35l41_hda_property.c
@@ -76,6 +76,7 @@ static const struct cs35l41_config cs35l41_config_table[] = {
{ "10431533", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
{ "10431573", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 1000, 4500, 24 },
{ "10431663", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, -1, 0, 1000, 4500, 24 },
+ { "10431683", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 0, 0, 0 },
{ "104316D3", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 0, 0, 0 },
{ "104316F3", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 0, 0, 0 },
{ "104317F3", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
@@ -410,6 +411,7 @@ static const struct cs35l41_prop_model cs35l41_prop_model_table[] = {
{ "CSC3551", "10431533", generic_dsd_config },
{ "CSC3551", "10431573", generic_dsd_config },
{ "CSC3551", "10431663", generic_dsd_config },
+ { "CSC3551", "10431683", generic_dsd_config },
{ "CSC3551", "104316D3", generic_dsd_config },
{ "CSC3551", "104316F3", generic_dsd_config },
{ "CSC3551", "104317F3", generic_dsd_config },
--
2.42.0



2024-01-30 11:08:01

by Takashi Iwai

[permalink] [raw]
Subject: Re: [PATCH] ALSA: hda: cs35l41: Support ASUS Zenbook UM3402YAR

On Fri, 26 Jan 2024 09:09:12 +0100,
Chhayly Leang wrote:
>
> Adds sound support for ASUS Zenbook UM3402YAR with missing DSD
>
> Signed-off-by: Chhayly Leang <[email protected]>

Yet another missing entry; can Cirrus people review this before I
merge?


thanks,

Takashi

> ---
> sound/pci/hda/cs35l41_hda_property.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/sound/pci/hda/cs35l41_hda_property.c b/sound/pci/hda/cs35l41_hda_property.c
> index 35277ce890a..2af083183d8 100644
> --- a/sound/pci/hda/cs35l41_hda_property.c
> +++ b/sound/pci/hda/cs35l41_hda_property.c
> @@ -76,6 +76,7 @@ static const struct cs35l41_config cs35l41_config_table[] = {
> { "10431533", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
> { "10431573", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 1000, 4500, 24 },
> { "10431663", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, -1, 0, 1000, 4500, 24 },
> + { "10431683", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 0, 0, 0 },
> { "104316D3", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 0, 0, 0 },
> { "104316F3", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 0, 0, 0 },
> { "104317F3", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
> @@ -410,6 +411,7 @@ static const struct cs35l41_prop_model cs35l41_prop_model_table[] = {
> { "CSC3551", "10431533", generic_dsd_config },
> { "CSC3551", "10431573", generic_dsd_config },
> { "CSC3551", "10431663", generic_dsd_config },
> + { "CSC3551", "10431683", generic_dsd_config },
> { "CSC3551", "104316D3", generic_dsd_config },
> { "CSC3551", "104316F3", generic_dsd_config },
> { "CSC3551", "104317F3", generic_dsd_config },
> --
> 2.42.0
>

2024-01-30 11:26:55

by Stefan Binding

[permalink] [raw]
Subject: RE: [PATCH] ALSA: hda: cs35l41: Support ASUS Zenbook UM3402YAR

Hi,

> -----Original Message-----
> From: Takashi Iwai <[email protected]>
> Sent: Tuesday, January 30, 2024 11:06 AM
> To: Chhayly Leang <[email protected]>
> Cc: Stefan Binding <[email protected]>; Takashi Iwai
> <[email protected]>; [email protected]; James Schulman
> <[email protected]>; David Rhodes
> <[email protected]>; Richard Fitzgerald
> <[email protected]>; Jaroslav Kysela <[email protected]>; linux-
> [email protected]; [email protected]
> Subject: Re: [PATCH] ALSA: hda: cs35l41: Support ASUS Zenbook
> UM3402YAR
>
> On Fri, 26 Jan 2024 09:09:12 +0100,
> Chhayly Leang wrote:
> >
> > Adds sound support for ASUS Zenbook UM3402YAR with missing DSD
> >
> > Signed-off-by: Chhayly Leang <[email protected]>
>
> Yet another missing entry; can Cirrus people review this before I
> merge?

Looks good to me.

Thanks,
Stefan

>
>
> thanks,
>
> Takashi
>
> > ---
> > sound/pci/hda/cs35l41_hda_property.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/sound/pci/hda/cs35l41_hda_property.c
> b/sound/pci/hda/cs35l41_hda_property.c
> > index 35277ce890a..2af083183d8 100644
> > --- a/sound/pci/hda/cs35l41_hda_property.c
> > +++ b/sound/pci/hda/cs35l41_hda_property.c
> > @@ -76,6 +76,7 @@ static const struct cs35l41_config
> cs35l41_config_table[] = {
> > { "10431533", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0
> }, 0, 1, -1, 1000, 4500, 24 },
> > { "10431573", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0
> }, 1, 2, 0, 1000, 4500, 24 },
> > { "10431663", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0
> }, 1, -1, 0, 1000, 4500, 24 },
> > + { "10431683", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0
> }, 0, 1, -1, 0, 0, 0 },
> > { "104316D3", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0
> }, 1, 2, 0, 0, 0, 0 },
> > { "104316F3", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0
> }, 1, 2, 0, 0, 0, 0 },
> > { "104317F3", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0
> }, 0, 1, -1, 1000, 4500, 24 },
> > @@ -410,6 +411,7 @@ static const struct cs35l41_prop_model
> cs35l41_prop_model_table[] = {
> > { "CSC3551", "10431533", generic_dsd_config },
> > { "CSC3551", "10431573", generic_dsd_config },
> > { "CSC3551", "10431663", generic_dsd_config },
> > + { "CSC3551", "10431683", generic_dsd_config },
> > { "CSC3551", "104316D3", generic_dsd_config },
> > { "CSC3551", "104316F3", generic_dsd_config },
> > { "CSC3551", "104317F3", generic_dsd_config },
> > --
> > 2.42.0
> >



2024-01-30 13:16:46

by Takashi Iwai

[permalink] [raw]
Subject: Re: [PATCH] ALSA: hda: cs35l41: Support ASUS Zenbook UM3402YAR

On Fri, 26 Jan 2024 09:09:12 +0100,
Chhayly Leang wrote:
>
> Adds sound support for ASUS Zenbook UM3402YAR with missing DSD
>
> Signed-off-by: Chhayly Leang <[email protected]>

Applied now. Thanks.


Takashi