2021-12-06 03:17:20

by Huang, Ying

[permalink] [raw]
Subject: [PATCH] numa balancing: remove some outdated document

After commit 8a99b6833c88 ("sched: Move SCHED_DEBUG sysctl to
debugfs"), some NUMA balancing sysctls enclosed with SCHED_DEBUG has
been moved to debugfs. This patch removes the document for the
sysctls to keep the document consistent with the code.

Signed-off-by: "Huang, Ying" <[email protected]>
Fixes: 8a99b6833c88 ("sched: Move SCHED_DEBUG sysctl to debugfs")
Cc: Mel Gorman <[email protected]>
Cc: Peter Zijlstra (Intel) <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>
Cc: Valentin Schneider <[email protected]>
Cc: [email protected] # since v5.13
---
Documentation/admin-guide/sysctl/kernel.rst | 46 +--------------------
1 file changed, 1 insertion(+), 45 deletions(-)

diff --git a/Documentation/admin-guide/sysctl/kernel.rst b/Documentation/admin-guide/sysctl/kernel.rst
index 426162009ce9..d2679ea6936e 100644
--- a/Documentation/admin-guide/sysctl/kernel.rst
+++ b/Documentation/admin-guide/sysctl/kernel.rst
@@ -609,51 +609,7 @@ be migrated to a local memory node.
The unmapping of pages and trapping faults incur additional overhead that
ideally is offset by improved memory locality but there is no universal
guarantee. If the target workload is already bound to NUMA nodes then this
-feature should be disabled. Otherwise, if the system overhead from the
-feature is too high then the rate the kernel samples for NUMA hinting
-faults may be controlled by the `numa_balancing_scan_period_min_ms,
-numa_balancing_scan_delay_ms, numa_balancing_scan_period_max_ms,
-numa_balancing_scan_size_mb`_, and numa_balancing_settle_count sysctls.
-
-
-numa_balancing_scan_period_min_ms, numa_balancing_scan_delay_ms, numa_balancing_scan_period_max_ms, numa_balancing_scan_size_mb
-===============================================================================================================================
-
-
-Automatic NUMA balancing scans tasks address space and unmaps pages to
-detect if pages are properly placed or if the data should be migrated to a
-memory node local to where the task is running. Every "scan delay" the task
-scans the next "scan size" number of pages in its address space. When the
-end of the address space is reached the scanner restarts from the beginning.
-
-In combination, the "scan delay" and "scan size" determine the scan rate.
-When "scan delay" decreases, the scan rate increases. The scan delay and
-hence the scan rate of every task is adaptive and depends on historical
-behaviour. If pages are properly placed then the scan delay increases,
-otherwise the scan delay decreases. The "scan size" is not adaptive but
-the higher the "scan size", the higher the scan rate.
-
-Higher scan rates incur higher system overhead as page faults must be
-trapped and potentially data must be migrated. However, the higher the scan
-rate, the more quickly a tasks memory is migrated to a local node if the
-workload pattern changes and minimises performance impact due to remote
-memory accesses. These sysctls control the thresholds for scan delays and
-the number of pages scanned.
-
-``numa_balancing_scan_period_min_ms`` is the minimum time in milliseconds to
-scan a tasks virtual memory. It effectively controls the maximum scanning
-rate for each task.
-
-``numa_balancing_scan_delay_ms`` is the starting "scan delay" used for a task
-when it initially forks.
-
-``numa_balancing_scan_period_max_ms`` is the maximum time in milliseconds to
-scan a tasks virtual memory. It effectively controls the minimum scanning
-rate for each task.
-
-``numa_balancing_scan_size_mb`` is how many megabytes worth of pages are
-scanned for a given scan.
-
+feature should be disabled.

oops_all_cpu_backtrace
======================
--
2.30.2



2021-12-06 09:51:50

by Valentin Schneider

[permalink] [raw]
Subject: Re: [PATCH] numa balancing: remove some outdated document

On 06/12/21 11:16, Huang Ying wrote:
> After commit 8a99b6833c88 ("sched: Move SCHED_DEBUG sysctl to
> debugfs"), some NUMA balancing sysctls enclosed with SCHED_DEBUG has
> been moved to debugfs. This patch removes the document for the
> sysctls to keep the document consistent with the code.
>

There are still some useful pieces of information in those hunks; what
about moving that to a Documentation/scheduler/sched-debug.rst?

> Signed-off-by: "Huang, Ying" <[email protected]>
> Fixes: 8a99b6833c88 ("sched: Move SCHED_DEBUG sysctl to debugfs")
> Cc: Mel Gorman <[email protected]>
> Cc: Peter Zijlstra (Intel) <[email protected]>
> Cc: Greg Kroah-Hartman <[email protected]>
> Cc: Valentin Schneider <[email protected]>
> Cc: [email protected] # since v5.13

2021-12-07 00:16:01

by Huang, Ying

[permalink] [raw]
Subject: Re: [PATCH] numa balancing: remove some outdated document

Valentin Schneider <[email protected]> writes:

> On 06/12/21 11:16, Huang Ying wrote:
>> After commit 8a99b6833c88 ("sched: Move SCHED_DEBUG sysctl to
>> debugfs"), some NUMA balancing sysctls enclosed with SCHED_DEBUG has
>> been moved to debugfs. This patch removes the document for the
>> sysctls to keep the document consistent with the code.
>>
>
> There are still some useful pieces of information in those hunks; what
> about moving that to a Documentation/scheduler/sched-debug.rst?

Sound good to me. Will do that in the next version.

Best Regards,
Huang, Ying

>> Signed-off-by: "Huang, Ying" <[email protected]>
>> Fixes: 8a99b6833c88 ("sched: Move SCHED_DEBUG sysctl to debugfs")
>> Cc: Mel Gorman <[email protected]>
>> Cc: Peter Zijlstra (Intel) <[email protected]>
>> Cc: Greg Kroah-Hartman <[email protected]>
>> Cc: Valentin Schneider <[email protected]>
>> Cc: [email protected] # since v5.13