2021-03-31 16:35:53

by Ismael Luceno

Subject: [PATCH] docs: reporting-issues: Remove reference to oldnoconfig

Replace it with olddefconfig. oldnoconfig didn't do what the document
suggests (it aliased to olddefconfig), and isn't available since 4.19.

Ref: 04c459d20448 ("kconfig: remove oldnoconfig target")
Ref: 312ee68752fa ("kconfig: announce removal of oldnoconfig if used")
Signed-off-by: Ismael Luceno <[email protected]>
---
Documentation/admin-guide/reporting-issues.rst | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/Documentation/admin-guide/reporting-issues.rst b/Documentation/admin-guide/reporting-issues.rst
index 07879d01fe68..ffa0d4c6e450 100644
--- a/Documentation/admin-guide/reporting-issues.rst
+++ b/Documentation/admin-guide/reporting-issues.rst
@@ -1000,8 +1000,7 @@ In the whole process keep in mind: an issue only qualifies as regression if the
older and the newer kernel got built with a similar configuration. The best way
to archive this: copy the configuration file (``.config``) from the old working
kernel freshly to each newer kernel version you try. Afterwards run ``make
-oldnoconfig`` to adjust it for the needs of the new version without enabling
-any new feature, as those are allowed to cause regressions.
+olddefconfig`` to adjust it for the needs of the new version.


Write and send the report
--
2.31.1

2021-03-31 20:37:39

by Jonathan Corbet

Subject: Re: [PATCH] docs: reporting-issues: Remove reference to oldnoconfig

Ismael Luceno <[email protected]> writes:

> Replace it with olddefconfig. oldnoconfig didn't do what the document
> suggests (it aliased to olddefconfig), and isn't available since 4.19.
>
> Ref: 04c459d20448 ("kconfig: remove oldnoconfig target")
> Ref: 312ee68752fa ("kconfig: announce removal of oldnoconfig if used")
> Signed-off-by: Ismael Luceno <[email protected]>
> ---
> Documentation/admin-guide/reporting-issues.rst | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/Documentation/admin-guide/reporting-issues.rst b/Documentation/admin-guide/reporting-issues.rst
> index 07879d01fe68..ffa0d4c6e450 100644
> --- a/Documentation/admin-guide/reporting-issues.rst
> +++ b/Documentation/admin-guide/reporting-issues.rst
> @@ -1000,8 +1000,7 @@ In the whole process keep in mind: an issue only qualifies as regression if the
> older and the newer kernel got built with a similar configuration. The best way
> to archive this: copy the configuration file (``.config``) from the old working
> kernel freshly to each newer kernel version you try. Afterwards run ``make
> -oldnoconfig`` to adjust it for the needs of the new version without enabling
> -any new feature, as those are allowed to cause regressions.
> +olddefconfig`` to adjust it for the needs of the new version.

[CC += Thorsten]

Applied, thanks.

jon