devm_ioremap_resource does sanity checks on the given resource. No need to
duplicate this in the driver.
Signed-off-by: Wolfram Sang <[email protected]>
Acked-by: John Crispin <[email protected]>
---
Should go via subsystem tree
arch/mips/lantiq/xway/dma.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/arch/mips/lantiq/xway/dma.c b/arch/mips/lantiq/xway/dma.c
index 08f7ebd..78a91fa 100644
--- a/arch/mips/lantiq/xway/dma.c
+++ b/arch/mips/lantiq/xway/dma.c
@@ -220,10 +220,6 @@ ltq_dma_init(struct platform_device *pdev)
int i;
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- if (!res)
- panic("Failed to get dma resource");
-
- /* remap dma register range */
ltq_dma_membase = devm_ioremap_resource(&pdev->dev, res);
if (IS_ERR(ltq_dma_membase))
panic("Failed to remap dma resource");
--
1.8.5.1
devm_ioremap_resource does sanity checks on the given resource. No need to
duplicate this in the driver.
Signed-off-by: Wolfram Sang <[email protected]>
---
Should go via subsystem tree
arch/mips/pci/pci-rt3883.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/arch/mips/pci/pci-rt3883.c b/arch/mips/pci/pci-rt3883.c
index adeff2b..72919ae 100644
--- a/arch/mips/pci/pci-rt3883.c
+++ b/arch/mips/pci/pci-rt3883.c
@@ -436,9 +436,6 @@ static int rt3883_pci_probe(struct platform_device *pdev)
return -ENOMEM;
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- if (!res)
- return -EINVAL;
-
rpc->base = devm_ioremap_resource(dev, res);
if (IS_ERR(rpc->base))
return PTR_ERR(rpc->base);
--
1.8.5.1
devm_ioremap_resource does sanity checks on the given resource. No need to
duplicate this in the driver.
Signed-off-by: Wolfram Sang <[email protected]>
---
Should go via subsystem tree
drivers/gpio/gpio-davinci.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
index 84be701..a5e1a56 100644
--- a/drivers/gpio/gpio-davinci.c
+++ b/drivers/gpio/gpio-davinci.c
@@ -172,11 +172,6 @@ static int davinci_gpio_probe(struct platform_device *pdev)
}
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- if (!res) {
- dev_err(dev, "Invalid memory resource\n");
- return -EBUSY;
- }
-
gpio_base = devm_ioremap_resource(dev, res);
if (IS_ERR(gpio_base))
return PTR_ERR(gpio_base);
--
1.8.5.1
devm_ioremap_resource does sanity checks on the given resource. No need to
duplicate this in the driver.
Signed-off-by: Wolfram Sang <[email protected]>
Reviewed-by: Terje Bergstrom <[email protected]>
---
Should go via subsystem tree
drivers/gpu/drm/tegra/hdmi.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/tegra/hdmi.c b/drivers/gpu/drm/tegra/hdmi.c
index 0cd9bc2..1650fb3 100644
--- a/drivers/gpu/drm/tegra/hdmi.c
+++ b/drivers/gpu/drm/tegra/hdmi.c
@@ -1375,9 +1375,6 @@ static int tegra_hdmi_probe(struct platform_device *pdev)
return err;
regs = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- if (!regs)
- return -ENXIO;
-
hdmi->regs = devm_ioremap_resource(&pdev->dev, regs);
if (IS_ERR(hdmi->regs))
return PTR_ERR(hdmi->regs);
--
1.8.5.1
devm_ioremap_resource does sanity checks on the given resource. No need to
duplicate this in the driver.
Signed-off-by: Wolfram Sang <[email protected]>
---
Should go via subsystem tree
drivers/pci/host/pci-imx6.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/pci/host/pci-imx6.c b/drivers/pci/host/pci-imx6.c
index bd70af8..5002e23 100644
--- a/drivers/pci/host/pci-imx6.c
+++ b/drivers/pci/host/pci-imx6.c
@@ -426,11 +426,6 @@ static int __init imx6_pcie_probe(struct platform_device *pdev)
"imprecise external abort");
dbi_base = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- if (!dbi_base) {
- dev_err(&pdev->dev, "dbi_base memory resource not found\n");
- return -ENODEV;
- }
-
pp->dbi_base = devm_ioremap_resource(&pdev->dev, dbi_base);
if (IS_ERR(pp->dbi_base)) {
ret = PTR_ERR(pp->dbi_base);
--
1.8.5.1
devm_ioremap_resource does sanity checks on the given resource. No need to
duplicate this in the driver.
Signed-off-by: Wolfram Sang <[email protected]>
---
Should go via subsystem tree
drivers/usb/dwc3/dwc3-omap.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drivers/usb/dwc3/dwc3-omap.c
index 7f7ea62..cbcd972 100644
--- a/drivers/usb/dwc3/dwc3-omap.c
+++ b/drivers/usb/dwc3/dwc3-omap.c
@@ -432,11 +432,6 @@ static int dwc3_omap_probe(struct platform_device *pdev)
}
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- if (!res) {
- dev_err(dev, "missing memory base resource\n");
- return -EINVAL;
- }
-
base = devm_ioremap_resource(dev, res);
if (IS_ERR(base))
return PTR_ERR(base);
--
1.8.5.1
devm_ioremap_resource does sanity checks on the given resource. No need to
duplicate this in the driver.
Signed-off-by: Wolfram Sang <[email protected]>
---
Should go via subsystem tree
drivers/amba/tegra-ahb.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/amba/tegra-ahb.c b/drivers/amba/tegra-ahb.c
index 1f44e56c..558a239 100644
--- a/drivers/amba/tegra-ahb.c
+++ b/drivers/amba/tegra-ahb.c
@@ -256,8 +256,6 @@ static int tegra_ahb_probe(struct platform_device *pdev)
return -ENOMEM;
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- if (!res)
- return -ENODEV;
ahb->regs = devm_ioremap_resource(&pdev->dev, res);
if (IS_ERR(ahb->regs))
return PTR_ERR(ahb->regs);
--
1.8.5.1
Hi Wolfgang,
should we take 1/7 and 6/7 via the mips tree ?
John
On 14/01/2014 12:58, Wolfram Sang wrote:
> devm_ioremap_resource does sanity checks on the given resource. No need to
> duplicate this in the driver.
>
> Signed-off-by: Wolfram Sang <[email protected]>
> Acked-by: John Crispin <[email protected]>
> ---
>
> Should go via subsystem tree
>
> arch/mips/lantiq/xway/dma.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/arch/mips/lantiq/xway/dma.c b/arch/mips/lantiq/xway/dma.c
> index 08f7ebd..78a91fa 100644
> --- a/arch/mips/lantiq/xway/dma.c
> +++ b/arch/mips/lantiq/xway/dma.c
> @@ -220,10 +220,6 @@ ltq_dma_init(struct platform_device *pdev)
> int i;
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - if (!res)
> - panic("Failed to get dma resource");
> -
> - /* remap dma register range */
> ltq_dma_membase = devm_ioremap_resource(&pdev->dev, res);
> if (IS_ERR(ltq_dma_membase))
> panic("Failed to remap dma resource");
Hi,
On Tue, Jan 14, 2014 at 01:03:34PM +0100, John Crispin wrote:
> Hi Wolfgang,
Wolfram, please...
> should we take 1/7 and 6/7 via the mips tree ?
> > Should go via subsystem tree
Yes :)
Thanks,
Wolfram
On Tuesday, January 14, 2014 at 12:58:55 PM, Wolfram Sang wrote:
> devm_ioremap_resource does sanity checks on the given resource. No need to
> duplicate this in the driver.
>
> Signed-off-by: Wolfram Sang <[email protected]>
True that,
Acked-by: Marek Vasut <[email protected]>
> ---
>
> Should go via subsystem tree
>
> drivers/pci/host/pci-imx6.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/pci/host/pci-imx6.c b/drivers/pci/host/pci-imx6.c
> index bd70af8..5002e23 100644
> --- a/drivers/pci/host/pci-imx6.c
> +++ b/drivers/pci/host/pci-imx6.c
> @@ -426,11 +426,6 @@ static int __init imx6_pcie_probe(struct
> platform_device *pdev) "imprecise external abort");
>
> dbi_base = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - if (!dbi_base) {
> - dev_err(&pdev->dev, "dbi_base memory resource not found\n");
> - return -ENODEV;
> - }
> -
> pp->dbi_base = devm_ioremap_resource(&pdev->dev, dbi_base);
> if (IS_ERR(pp->dbi_base)) {
> ret = PTR_ERR(pp->dbi_base);
Best regards,
Marek Vasut
On Tue, Jan 14, 2014 at 12:58:53PM +0100, Wolfram Sang wrote:
> devm_ioremap_resource does sanity checks on the given resource. No need to
> duplicate this in the driver.
>
> Signed-off-by: Wolfram Sang <[email protected]>
> ---
>
> Should go via subsystem tree
>
> drivers/amba/tegra-ahb.c | 2 --
> 1 file changed, 2 deletions(-)
Reviewed-by: Thierry Reding <[email protected]>
On Tue, Jan 14, 2014 at 12:58:54PM +0100, Wolfram Sang wrote:
> devm_ioremap_resource does sanity checks on the given resource. No need to
> duplicate this in the driver.
>
> Signed-off-by: Wolfram Sang <[email protected]>
> Reviewed-by: Terje Bergstrom <[email protected]>
> ---
>
> Should go via subsystem tree
>
> drivers/gpu/drm/tegra/hdmi.c | 3 ---
> 1 file changed, 3 deletions(-)
Applied, thanks.
Thierry
On Tue, Jan 14, 2014 at 12:58:56PM +0100, Wolfram Sang wrote:
> devm_ioremap_resource does sanity checks on the given resource. No need to
> duplicate this in the driver.
>
> Signed-off-by: Wolfram Sang <[email protected]>
> ---
>
> Should go via subsystem tree
too late for v3.14, I'll merge this for v3.15.
--
balbi
On 01/14/2014 04:58 AM, Wolfram Sang wrote:
> devm_ioremap_resource does sanity checks on the given resource. No need to
> duplicate this in the driver.
This looks fine. I expect to apply it for 3.15 after the 3.14 merge
window, unless it's urgent to get it into 3.14 for some reason?
> This looks fine. I expect to apply it for 3.15 after the 3.14 merge
> window, unless it's urgent to get it into 3.14 for some reason?
Nope, it is not. I wasn't aiming for 3.14, it was simply in my queue.
On Tuesday, January 14, 2014 10:17 PM, Marek Vasut wrote:
> On Tuesday, January 14, 2014 at 12:58:55 PM, Wolfram Sang wrote:
> > devm_ioremap_resource does sanity checks on the given resource. No need to
> > duplicate this in the driver.
> >
> > Signed-off-by: Wolfram Sang <[email protected]>
>
> True that,
>
> Acked-by: Marek Vasut <[email protected]>
(+cc Fabio Estevam)
Hi all,
The same patch was already sent by Fabio Estevam a month ago.[1]
Also, it was applied to pci/next tree.[2]
[1] http://www.spinics.net/lists/linux-pci/msg26873.html
[2] http://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/commit/?h=next&id=ebb034a4ce9fc37877b3df2b85b9c33d43349586
Best regards,
Jingoo Han
>
> > ---
> >
> > Should go via subsystem tree
> >
> > drivers/pci/host/pci-imx6.c | 5 -----
> > 1 file changed, 5 deletions(-)
> >
> > diff --git a/drivers/pci/host/pci-imx6.c b/drivers/pci/host/pci-imx6.c
> > index bd70af8..5002e23 100644
> > --- a/drivers/pci/host/pci-imx6.c
> > +++ b/drivers/pci/host/pci-imx6.c
> > @@ -426,11 +426,6 @@ static int __init imx6_pcie_probe(struct
> > platform_device *pdev) "imprecise external abort");
> >
> > dbi_base = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > - if (!dbi_base) {
> > - dev_err(&pdev->dev, "dbi_base memory resource not found\n");
> > - return -ENODEV;
> > - }
> > -
> > pp->dbi_base = devm_ioremap_resource(&pdev->dev, dbi_base);
> > if (IS_ERR(pp->dbi_base)) {
> > ret = PTR_ERR(pp->dbi_base);
>
> Best regards,
> Marek Vasut
On Tue, Jan 14, 2014 at 12:58 PM, Wolfram Sang <[email protected]> wrote:
> devm_ioremap_resource does sanity checks on the given resource. No need to
> duplicate this in the driver.
>
> Signed-off-by: Wolfram Sang <[email protected]>
> ---
>
> Should go via subsystem tree
>
> drivers/gpio/gpio-davinci.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
> index 84be701..a5e1a56 100644
> --- a/drivers/gpio/gpio-davinci.c
> +++ b/drivers/gpio/gpio-davinci.c
> @@ -172,11 +172,6 @@ static int davinci_gpio_probe(struct platform_device *pdev)
> }
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - if (!res) {
> - dev_err(dev, "Invalid memory resource\n");
> - return -EBUSY;
> - }
> -
> gpio_base = devm_ioremap_resource(dev, res);
> if (IS_ERR(gpio_base))
> return PTR_ERR(gpio_base);
Acked-by: Linus Walleij <[email protected]>
The DaVinci maintainers are queuing GPIO patches for their driver
for this merge window, so requesting them to apply this patch.
Yours,
Linus Walleij
On Wednesday 15 January 2014 02:58 PM, Linus Walleij wrote:
> On Tue, Jan 14, 2014 at 12:58 PM, Wolfram Sang <[email protected]> wrote:
>
>> devm_ioremap_resource does sanity checks on the given resource. No need to
>> duplicate this in the driver.
>>
>> Signed-off-by: Wolfram Sang <[email protected]>
>> ---
>>
>> Should go via subsystem tree
>>
>> drivers/gpio/gpio-davinci.c | 5 -----
>> 1 file changed, 5 deletions(-)
>>
>> diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
>> index 84be701..a5e1a56 100644
>> --- a/drivers/gpio/gpio-davinci.c
>> +++ b/drivers/gpio/gpio-davinci.c
>> @@ -172,11 +172,6 @@ static int davinci_gpio_probe(struct platform_device *pdev)
>> }
>>
>> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>> - if (!res) {
>> - dev_err(dev, "Invalid memory resource\n");
>> - return -EBUSY;
>> - }
>> -
>> gpio_base = devm_ioremap_resource(dev, res);
>> if (IS_ERR(gpio_base))
>> return PTR_ERR(gpio_base);
>
> Acked-by: Linus Walleij <[email protected]>
>
> The DaVinci maintainers are queuing GPIO patches for their driver
> for this merge window, so requesting them to apply this patch.
I wont be sending any more pull requests for v3.14. Even if I send, the
ARM-SoC maintainers will not take it anyway. So likely this wont get
into v3.14. For v3.15, Linus should be able to queue it as dependencies
would have made it into the kernel by then.
Thanks,
Sekhar
On Wed, Jan 15, 2014 at 1:54 PM, Sekhar Nori <[email protected]> wrote:
> On Wednesday 15 January 2014 02:58 PM, Linus Walleij wrote:
>> Acked-by: Linus Walleij <[email protected]>
>>
>> The DaVinci maintainers are queuing GPIO patches for their driver
>> for this merge window, so requesting them to apply this patch.
>
> I wont be sending any more pull requests for v3.14. Even if I send, the
> ARM-SoC maintainers will not take it anyway.
But as it is a fix I believe the ARM SoC maintainers will apply it
directly to the davinci branch.
Wolfram: I suggest you send this patch with my ACK directly
to [email protected] and ask it to be applied to the davinci branch
in the ARM SoC tree.
Yours,
Linus Walleij
On Wednesday 15 January 2014 07:21 PM, Linus Walleij wrote:
> On Wed, Jan 15, 2014 at 1:54 PM, Sekhar Nori <[email protected]> wrote:
>> On Wednesday 15 January 2014 02:58 PM, Linus Walleij wrote:
>
>>> Acked-by: Linus Walleij <[email protected]>
>>>
>>> The DaVinci maintainers are queuing GPIO patches for their driver
>>> for this merge window, so requesting them to apply this patch.
>>
>> I wont be sending any more pull requests for v3.14. Even if I send, the
>> ARM-SoC maintainers will not take it anyway.
>
> But as it is a fix I believe the ARM SoC maintainers will apply it
> directly to the davinci branch.
Sorry I did not realize this is a fix.
>
> Wolfram: I suggest you send this patch with my ACK directly
> to [email protected] and ask it to be applied to the davinci branch
> in the ARM SoC tree.
This would work too, I guess. Wolfram, can you please keep me in CC too
in case questions/actions come up?
Thanks,
Sekhar
Sekhar Nori <[email protected]> writes:
> On Wednesday 15 January 2014 07:21 PM, Linus Walleij wrote:
>> On Wed, Jan 15, 2014 at 1:54 PM, Sekhar Nori <[email protected]> wrote:
>>> On Wednesday 15 January 2014 02:58 PM, Linus Walleij wrote:
>>
>>>> Acked-by: Linus Walleij <[email protected]>
>>>>
>>>> The DaVinci maintainers are queuing GPIO patches for their driver
>>>> for this merge window, so requesting them to apply this patch.
>>>
>>> I wont be sending any more pull requests for v3.14. Even if I send, the
>>> ARM-SoC maintainers will not take it anyway.
>>
>> But as it is a fix I believe the ARM SoC maintainers will apply it
>> directly to the davinci branch.
>
> Sorry I did not realize this is a fix.
>
>>
>> Wolfram: I suggest you send this patch with my ACK directly
>> to [email protected] and ask it to be applied to the davinci branch
>> in the ARM SoC tree.
>
> This would work too, I guess. Wolfram, can you please keep me in CC too
> in case questions/actions come up?
Sekhar, I assume this is an ack from you too? If so, Wolfram, please
include that in the patch submitted to arm-soc.
Kevin
On Wednesday 15 January 2014 09:20 PM, Kevin Hilman wrote:
> Sekhar Nori <[email protected]> writes:
>
>> On Wednesday 15 January 2014 07:21 PM, Linus Walleij wrote:
>>> On Wed, Jan 15, 2014 at 1:54 PM, Sekhar Nori <[email protected]> wrote:
>>>> On Wednesday 15 January 2014 02:58 PM, Linus Walleij wrote:
>>>
>>>>> Acked-by: Linus Walleij <[email protected]>
>>>>>
>>>>> The DaVinci maintainers are queuing GPIO patches for their driver
>>>>> for this merge window, so requesting them to apply this patch.
>>>>
>>>> I wont be sending any more pull requests for v3.14. Even if I send, the
>>>> ARM-SoC maintainers will not take it anyway.
>>>
>>> But as it is a fix I believe the ARM SoC maintainers will apply it
>>> directly to the davinci branch.
>>
>> Sorry I did not realize this is a fix.
>>
>>>
>>> Wolfram: I suggest you send this patch with my ACK directly
>>> to [email protected] and ask it to be applied to the davinci branch
>>> in the ARM SoC tree.
>>
>> This would work too, I guess. Wolfram, can you please keep me in CC too
>> in case questions/actions come up?
>
> Sekhar, I assume this is an ack from you too? If so, Wolfram, please
> include that in the patch submitted to arm-soc.
Wolfram, if you have not sent it already, please add:
Acked-by: Sekhar Nori <[email protected]>
The branch to which the patch will be applied is davinci/gpio on
git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc.git. Please
rebase on this branch so it applies cleanly.
Thanks,
Sekhar
Hi Linus, Sekhar,
On 01/16/2014 06:29 AM, Sekhar Nori wrote:
> On Wednesday 15 January 2014 09:20 PM, Kevin Hilman wrote:
>> Sekhar Nori <[email protected]> writes:
>>
>>> On Wednesday 15 January 2014 07:21 PM, Linus Walleij wrote:
>>>> On Wed, Jan 15, 2014 at 1:54 PM, Sekhar Nori <[email protected]> wrote:
>>>>> On Wednesday 15 January 2014 02:58 PM, Linus Walleij wrote:
>>>>
>>>>>> Acked-by: Linus Walleij <[email protected]>
>>>>>>
>>>>>> The DaVinci maintainers are queuing GPIO patches for their driver
>>>>>> for this merge window, so requesting them to apply this patch.
>>>>>
>>>>> I wont be sending any more pull requests for v3.14. Even if I send, the
>>>>> ARM-SoC maintainers will not take it anyway.
>>>>
>>>> But as it is a fix I believe the ARM SoC maintainers will apply it
>>>> directly to the davinci branch.
>>>
>>> Sorry I did not realize this is a fix.
>>>
>>>>
>>>> Wolfram: I suggest you send this patch with my ACK directly
>>>> to [email protected] and ask it to be applied to the davinci branch
>>>> in the ARM SoC tree.
>>>
>>> This would work too, I guess. Wolfram, can you please keep me in CC too
>>> in case questions/actions come up?
>>
>> Sekhar, I assume this is an ack from you too? If so, Wolfram, please
>> include that in the patch submitted to arm-soc.
>
> Wolfram, if you have not sent it already, please add:
>
> Acked-by: Sekhar Nori <[email protected]>
>
> The branch to which the patch will be applied is davinci/gpio on
> git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc.git. Please
> rebase on this branch so it applies cleanly.
>
This patch is not in 3.14 yet. Are there any chances to have it in 3.14,
as it introduces merge conflicts with future patches?
Regards,
-grygorii
On 01/14/2014 04:58 AM, Wolfram Sang wrote:
> devm_ioremap_resource does sanity checks on the given resource. No need to
> duplicate this in the driver.
Applied to Tegra's for-3.15/drivers branch.