2012-06-20 06:11:34

by Namhyung Kim

Subject: [PATCH v2] perf bench: Documentation update

From: Namhyung Kim <[email protected]>

The current perf-bench documentation has a couple
of typos and even lacks entire description of mem
subsystem. Fix it.

Reported-by: Ingo Molnar <[email protected]>
Cc: Hitoshi Mitake <[email protected]>
Link: http://lkml.kernel.org/n/[email protected]
Signed-off-by: Namhyung Kim <[email protected]>
---
tools/perf/Documentation/perf-bench.txt | 78 +++++++++++++++++++++++++++++--
tools/perf/bench/mem-memcpy.c | 4 +-
tools/perf/bench/mem-memset.c | 8 ++--
tools/perf/builtin-bench.c | 4 +-
4 files changed, 83 insertions(+), 11 deletions(-)

diff --git a/tools/perf/Documentation/perf-bench.txt b/tools/perf/Documentation/perf-bench.txt
index a3dbadb26ef5..f3c716a4cad3 100644
--- a/tools/perf/Documentation/perf-bench.txt
+++ b/tools/perf/Documentation/perf-bench.txt
@@ -12,7 +12,7 @@ SYNOPSIS

DESCRIPTION
-----------
-This 'perf bench' command is general framework for benchmark suites.
+This 'perf bench' command is a general framework for benchmark suites.

COMMON OPTIONS
--------------
@@ -45,14 +45,20 @@ SUBSYSTEM
'sched'::
Scheduler and IPC mechanisms.

+'mem'::
+ Memory access performance.
+
+'all'::
+ All benchmark subsystems.
+
SUITES FOR 'sched'
~~~~~~~~~~~~~~~~~~
*messaging*::
Suite for evaluating performance of scheduler and IPC mechanisms.
Based on hackbench by Rusty Russell.

-Options of *pipe*
-^^^^^^^^^^^^^^^^^
+Options of *messaging*
+^^^^^^^^^^^^^^^^^^^^^^
-p::
--pipe::
Use pipe() instead of socketpair()
@@ -115,6 +121,72 @@ Example of *pipe*
59004 ops/sec
---------------------

+SUITES FOR 'mem'
+~~~~~~~~~~~~~~~~
+*memcpy*::
+Suite for evaluating performance of simple memory copy in various ways.
+
+Options of *memcpy*
+^^^^^^^^^^^^^^^^^^^
+-l::
+--length::
+Specify length of memory to copy (default: 1MB).
+Available units are B, KB, MB, GB and TB (case insensitive).
+
+-r::
+--routine::
+Specify routine to copy (default: default).
+Available routines are depend on the architecture.
+On x86-64, x86-64-unrolled, x86-64-movsq and x86-64-movsb are supported.
+
+-i::
+--iterations::
+Repeat memcpy invocation this number of times.
+
+-c::
+--clock::
+Use perf's cpu-cycles event instead of gettimeofday syscall.
+
+-o::
+--only-prefault::
+Show only the result with page faults before memcpy.
+
+-n::
+--no-prefault::
+Show only the result without page faults before memcpy.
+
+*memset*::
+Suite for evaluating performance of simple memory set in various ways.
+
+Options of *memset*
+^^^^^^^^^^^^^^^^^^^
+-l::
+--length::
+Specify length of memory to set (default: 1MB).
+Available units are B, KB, MB, GB and TB (case insensitive).
+
+-r::
+--routine::
+Specify routine to set (default: default).
+Available routines are depend on the architecture.
+On x86-64, x86-64-unrolled, x86-64-stosq and x86-64-stosb are supported.
+
+-i::
+--iterations::
+Repeat memset invocation this number of times.
+
+-c::
+--clock::
+Use perf's cpu-cycles event instead of gettimeofday syscall.
+
+-o::
+--only-prefault::
+Show only the result with page faults before memset.
+
+-n::
+--no-prefault::
+Show only the result without page faults before memset.
+
SEE ALSO
--------
linkperf:perf[1]
diff --git a/tools/perf/bench/mem-memcpy.c b/tools/perf/bench/mem-memcpy.c
index 71557225bf92..d990365cafa0 100644
--- a/tools/perf/bench/mem-memcpy.c
+++ b/tools/perf/bench/mem-memcpy.c
@@ -32,13 +32,13 @@ static bool no_prefault;
static const struct option options[] = {
OPT_STRING('l', "length", &length_str, "1MB",
"Specify length of memory to copy. "
- "available unit: B, MB, GB (upper and lower)"),
+ "Available units: B, KB, MB, GB and TB (upper and lower)"),
OPT_STRING('r', "routine", &routine, "default",
"Specify routine to copy"),
OPT_INTEGER('i', "iterations", &iterations,
"repeat memcpy() invocation this number of times"),
OPT_BOOLEAN('c', "clock", &use_clock,
- "Use CPU clock for measuring"),
+ "Use cycles event instead of gettimeofday() for measuring"),
OPT_BOOLEAN('o', "only-prefault", &only_prefault,
"Show only the result with page faults before memcpy()"),
OPT_BOOLEAN('n', "no-prefault", &no_prefault,
diff --git a/tools/perf/bench/mem-memset.c b/tools/perf/bench/mem-memset.c
index e9079185bd72..bf0d5f552017 100644
--- a/tools/perf/bench/mem-memset.c
+++ b/tools/perf/bench/mem-memset.c
@@ -31,14 +31,14 @@ static bool no_prefault;

static const struct option options[] = {
OPT_STRING('l', "length", &length_str, "1MB",
- "Specify length of memory to copy. "
- "available unit: B, MB, GB (upper and lower)"),
+ "Specify length of memory to set. "
+ "Available units: B, KB, MB, GB and TB (upper and lower)"),
OPT_STRING('r', "routine", &routine, "default",
- "Specify routine to copy"),
+ "Specify routine to set"),
OPT_INTEGER('i', "iterations", &iterations,
"repeat memset() invocation this number of times"),
OPT_BOOLEAN('c', "clock", &use_clock,
- "Use CPU clock for measuring"),
+ "Use cycles event instead of gettimeofday() for measuring"),
OPT_BOOLEAN('o', "only-prefault", &only_prefault,
"Show only the result with page faults before memset()"),
OPT_BOOLEAN('n', "no-prefault", &no_prefault,
diff --git a/tools/perf/builtin-bench.c b/tools/perf/builtin-bench.c
index b0e74ab2d7a2..1f3100216448 100644
--- a/tools/perf/builtin-bench.c
+++ b/tools/perf/builtin-bench.c
@@ -33,7 +33,7 @@ struct bench_suite {
};
\
/* sentinel: easy for help */
-#define suite_all { "all", "test all suite (pseudo suite)", NULL }
+#define suite_all { "all", "Test all benchmark suites", NULL }

static struct bench_suite sched_suites[] = {
{ "messaging",
@@ -75,7 +75,7 @@ static struct bench_subsys subsystems[] = {
"memory access performance",
mem_suites },
{ "all", /* sentinel: easy for help */
- "test all subsystem (pseudo subsystem)",
+ "all benchmark subsystem",
NULL },
{ NULL,
NULL,
--
1.7.10.2

2012-06-24 15:46:16

by Hitoshi Mitake

Subject: Re: [PATCH v2] perf bench: Documentation update

On Wed, Jun 20, 2012 at 3:08 PM, Namhyung Kim <[email protected]> wrote:
> From: Namhyung Kim <[email protected]>
>
> The current perf-bench documentation has a couple
> of typos and even lacks entire description of mem
> subsystem. Fix it.

Really sorry for my bad English... and thanks for your fix!
Acked-by: Hitoshi Mitake <[email protected]>

>
> Reported-by: Ingo Molnar <[email protected]>
> Cc: Hitoshi Mitake <[email protected]>
> Link: http://lkml.kernel.org/n/[email protected]
> Signed-off-by: Namhyung Kim <[email protected]>
> ---
> ?tools/perf/Documentation/perf-bench.txt | ? 78 +++++++++++++++++++++++++++++--
> ?tools/perf/bench/mem-memcpy.c ? ? ? ? ? | ? ?4 +-
> ?tools/perf/bench/mem-memset.c ? ? ? ? ? | ? ?8 ++--
> ?tools/perf/builtin-bench.c ? ? ? ? ? ? ?| ? ?4 +-
> ?4 files changed, 83 insertions(+), 11 deletions(-)
>
> diff --git a/tools/perf/Documentation/perf-bench.txt b/tools/perf/Documentation/perf-bench.txt
> index a3dbadb26ef5..f3c716a4cad3 100644
> --- a/tools/perf/Documentation/perf-bench.txt
> +++ b/tools/perf/Documentation/perf-bench.txt
> @@ -12,7 +12,7 @@ SYNOPSIS
>
> ?DESCRIPTION
> ?-----------
> -This 'perf bench' command is general framework for benchmark suites.
> +This 'perf bench' command is a general framework for benchmark suites.
>
> ?COMMON OPTIONS
> ?--------------
> @@ -45,14 +45,20 @@ SUBSYSTEM
> ?'sched'::
> ? ? ? ?Scheduler and IPC mechanisms.
>
> +'mem'::
> + ? ? ? Memory access performance.
> +
> +'all'::
> + ? ? ? All benchmark subsystems.
> +
> ?SUITES FOR 'sched'
> ?~~~~~~~~~~~~~~~~~~
> ?*messaging*::
> ?Suite for evaluating performance of scheduler and IPC mechanisms.
> ?Based on hackbench by Rusty Russell.
>
> -Options of *pipe*
> -^^^^^^^^^^^^^^^^^
> +Options of *messaging*
> +^^^^^^^^^^^^^^^^^^^^^^
> ?-p::
> ?--pipe::
> ?Use pipe() instead of socketpair()
> @@ -115,6 +121,72 @@ Example of *pipe*
> ? ? ? ? ? ? ? ? 59004 ops/sec
> ?---------------------
>
> +SUITES FOR 'mem'
> +~~~~~~~~~~~~~~~~
> +*memcpy*::
> +Suite for evaluating performance of simple memory copy in various ways.
> +
> +Options of *memcpy*
> +^^^^^^^^^^^^^^^^^^^
> +-l::
> +--length::
> +Specify length of memory to copy (default: 1MB).
> +Available units are B, KB, MB, GB and TB (case insensitive).
> +
> +-r::
> +--routine::
> +Specify routine to copy (default: default).
> +Available routines are depend on the architecture.
> +On x86-64, x86-64-unrolled, x86-64-movsq and x86-64-movsb are supported.
> +
> +-i::
> +--iterations::
> +Repeat memcpy invocation this number of times.
> +
> +-c::
> +--clock::
> +Use perf's cpu-cycles event instead of gettimeofday syscall.
> +
> +-o::
> +--only-prefault::
> +Show only the result with page faults before memcpy.
> +
> +-n::
> +--no-prefault::
> +Show only the result without page faults before memcpy.
> +
> +*memset*::
> +Suite for evaluating performance of simple memory set in various ways.
> +
> +Options of *memset*
> +^^^^^^^^^^^^^^^^^^^
> +-l::
> +--length::
> +Specify length of memory to set (default: 1MB).
> +Available units are B, KB, MB, GB and TB (case insensitive).
> +
> +-r::
> +--routine::
> +Specify routine to set (default: default).
> +Available routines are depend on the architecture.
> +On x86-64, x86-64-unrolled, x86-64-stosq and x86-64-stosb are supported.
> +
> +-i::
> +--iterations::
> +Repeat memset invocation this number of times.
> +
> +-c::
> +--clock::
> +Use perf's cpu-cycles event instead of gettimeofday syscall.
> +
> +-o::
> +--only-prefault::
> +Show only the result with page faults before memset.
> +
> +-n::
> +--no-prefault::
> +Show only the result without page faults before memset.
> +
> ?SEE ALSO
> ?--------
> ?linkperf:perf[1]
> diff --git a/tools/perf/bench/mem-memcpy.c b/tools/perf/bench/mem-memcpy.c
> index 71557225bf92..d990365cafa0 100644
> --- a/tools/perf/bench/mem-memcpy.c
> +++ b/tools/perf/bench/mem-memcpy.c
> @@ -32,13 +32,13 @@ static bool ? ? ? ? no_prefault;
> ?static const struct option options[] = {
> ? ? ? ?OPT_STRING('l', "length", &length_str, "1MB",
> ? ? ? ? ? ? ? ? ? ?"Specify length of memory to copy. "
> - ? ? ? ? ? ? ? ? ? "available unit: B, MB, GB (upper and lower)"),
> + ? ? ? ? ? ? ? ? ? "Available units: B, KB, MB, GB and TB (upper and lower)"),
> ? ? ? ?OPT_STRING('r', "routine", &routine, "default",
> ? ? ? ? ? ? ? ? ? ?"Specify routine to copy"),
> ? ? ? ?OPT_INTEGER('i', "iterations", &iterations,
> ? ? ? ? ? ? ? ? ? ?"repeat memcpy() invocation this number of times"),
> ? ? ? ?OPT_BOOLEAN('c', "clock", &use_clock,
> - ? ? ? ? ? ? ? ? ? "Use CPU clock for measuring"),
> + ? ? ? ? ? ? ? ? ? "Use cycles event instead of gettimeofday() for measuring"),
> ? ? ? ?OPT_BOOLEAN('o', "only-prefault", &only_prefault,
> ? ? ? ? ? ? ? ? ? ?"Show only the result with page faults before memcpy()"),
> ? ? ? ?OPT_BOOLEAN('n', "no-prefault", &no_prefault,
> diff --git a/tools/perf/bench/mem-memset.c b/tools/perf/bench/mem-memset.c
> index e9079185bd72..bf0d5f552017 100644
> --- a/tools/perf/bench/mem-memset.c
> +++ b/tools/perf/bench/mem-memset.c
> @@ -31,14 +31,14 @@ static bool ? ? ? ? no_prefault;
>
> ?static const struct option options[] = {
> ? ? ? ?OPT_STRING('l', "length", &length_str, "1MB",
> - ? ? ? ? ? ? ? ? ? "Specify length of memory to copy. "
> - ? ? ? ? ? ? ? ? ? "available unit: B, MB, GB (upper and lower)"),
> + ? ? ? ? ? ? ? ? ? "Specify length of memory to set. "
> + ? ? ? ? ? ? ? ? ? "Available units: B, KB, MB, GB and TB (upper and lower)"),
> ? ? ? ?OPT_STRING('r', "routine", &routine, "default",
> - ? ? ? ? ? ? ? ? ? "Specify routine to copy"),
> + ? ? ? ? ? ? ? ? ? "Specify routine to set"),
> ? ? ? ?OPT_INTEGER('i', "iterations", &iterations,
> ? ? ? ? ? ? ? ? ? ?"repeat memset() invocation this number of times"),
> ? ? ? ?OPT_BOOLEAN('c', "clock", &use_clock,
> - ? ? ? ? ? ? ? ? ? "Use CPU clock for measuring"),
> + ? ? ? ? ? ? ? ? ? "Use cycles event instead of gettimeofday() for measuring"),
> ? ? ? ?OPT_BOOLEAN('o', "only-prefault", &only_prefault,
> ? ? ? ? ? ? ? ? ? ?"Show only the result with page faults before memset()"),
> ? ? ? ?OPT_BOOLEAN('n', "no-prefault", &no_prefault,
> diff --git a/tools/perf/builtin-bench.c b/tools/perf/builtin-bench.c
> index b0e74ab2d7a2..1f3100216448 100644
> --- a/tools/perf/builtin-bench.c
> +++ b/tools/perf/builtin-bench.c
> @@ -33,7 +33,7 @@ struct bench_suite {
> ?};
> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?\
> ?/* sentinel: easy for help */
> -#define suite_all { "all", "test all suite (pseudo suite)", NULL }
> +#define suite_all { "all", "Test all benchmark suites", NULL }
>
> ?static struct bench_suite sched_suites[] = {
> ? ? ? ?{ "messaging",
> @@ -75,7 +75,7 @@ static struct bench_subsys subsystems[] = {
> ? ? ? ? ?"memory access performance",
> ? ? ? ? ?mem_suites },
> ? ? ? ?{ "all", ? ? ? ? ? ? ? ?/* sentinel: easy for help */
> - ? ? ? ? "test all subsystem (pseudo subsystem)",
> + ? ? ? ? "all benchmark subsystem",
> ? ? ? ? ?NULL },
> ? ? ? ?{ NULL,
> ? ? ? ? ?NULL,
> --
> 1.7.10.2
>
>

2012-06-25 01:44:32

by Namhyung Kim

Subject: Re: [PATCH v2] perf bench: Documentation update

Hi, Hitoshi-san

On Mon, 25 Jun 2012 00:46:12 +0900, Hitoshi Mitake wrote:
> On Wed, Jun 20, 2012 at 3:08 PM, Namhyung Kim <[email protected]> wrote:
>> From: Namhyung Kim <[email protected]>
>>
>> The current perf-bench documentation has a couple
>> of typos and even lacks entire description of mem
>> subsystem. Fix it.
>
> Really sorry for my bad English... and thanks for your fix!

Don't be sorry! Your work is great and my English is bad too :)


> Acked-by: Hitoshi Mitake <[email protected]>
>

Thanks,
Namhyung

2012-06-27 16:25:50

by Arnaldo Carvalho de Melo

Subject: Re: [PATCH v2] perf bench: Documentation update

Em Mon, Jun 25, 2012 at 12:46:12AM +0900, Hitoshi Mitake escreveu:
> On Wed, Jun 20, 2012 at 3:08 PM, Namhyung Kim <[email protected]> wrote:
> > From: Namhyung Kim <[email protected]>
> >
> > The current perf-bench documentation has a couple
> > of typos and even lacks entire description of mem
> > subsystem. Fix it.
>
> Really sorry for my bad English... and thanks for your fix!
> Acked-by: Hitoshi Mitake <[email protected]>

Thanks, applied to my perf/core branch.

- Arnaldo

2012-06-29 16:19:44

by Namhyung Kim

Subject: [tip:perf/core] perf bench: Documentation update

Commit-ID: 08942f6d5d992e9486b07653fd87ea8182a22fa0
Gitweb: http://git.kernel.org/tip/08942f6d5d992e9486b07653fd87ea8182a22fa0
Author: Namhyung Kim <[email protected]>
AuthorDate: Wed, 20 Jun 2012 15:08:06 +0900
Committer: Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Wed, 27 Jun 2012 13:17:48 -0300

perf bench: Documentation update

The current perf-bench documentation has a couple of typos and even
lacks entire description of mem subsystem. Fix it.

Reported-by: Ingo Molnar <[email protected]>
Signed-off-by: Namhyung Kim <[email protected]>
Acked-by: Hitoshi Mitake <[email protected]>
Cc: Hitoshi Mitake <[email protected]>
Cc: Ingo Molnar <[email protected]>
Cc: Paul Mackerras <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
---
tools/perf/Documentation/perf-bench.txt | 78 +++++++++++++++++++++++++++++-
tools/perf/bench/mem-memcpy.c | 4 +-
tools/perf/bench/mem-memset.c | 8 ++--
tools/perf/builtin-bench.c | 4 +-
4 files changed, 83 insertions(+), 11 deletions(-)

diff --git a/tools/perf/Documentation/perf-bench.txt b/tools/perf/Documentation/perf-bench.txt
index a3dbadb..f3c716a 100644
--- a/tools/perf/Documentation/perf-bench.txt
+++ b/tools/perf/Documentation/perf-bench.txt
@@ -12,7 +12,7 @@ SYNOPSIS

DESCRIPTION
-----------
-This 'perf bench' command is general framework for benchmark suites.
+This 'perf bench' command is a general framework for benchmark suites.

COMMON OPTIONS
--------------
@@ -45,14 +45,20 @@ SUBSYSTEM
'sched'::
Scheduler and IPC mechanisms.

+'mem'::
+ Memory access performance.
+
+'all'::
+ All benchmark subsystems.
+
SUITES FOR 'sched'
~~~~~~~~~~~~~~~~~~
*messaging*::
Suite for evaluating performance of scheduler and IPC mechanisms.
Based on hackbench by Rusty Russell.

-Options of *pipe*
-^^^^^^^^^^^^^^^^^
+Options of *messaging*
+^^^^^^^^^^^^^^^^^^^^^^
-p::
--pipe::
Use pipe() instead of socketpair()
@@ -115,6 +121,72 @@ Example of *pipe*
59004 ops/sec
---------------------

+SUITES FOR 'mem'
+~~~~~~~~~~~~~~~~
+*memcpy*::
+Suite for evaluating performance of simple memory copy in various ways.
+
+Options of *memcpy*
+^^^^^^^^^^^^^^^^^^^
+-l::
+--length::
+Specify length of memory to copy (default: 1MB).
+Available units are B, KB, MB, GB and TB (case insensitive).
+
+-r::
+--routine::
+Specify routine to copy (default: default).
+Available routines are depend on the architecture.
+On x86-64, x86-64-unrolled, x86-64-movsq and x86-64-movsb are supported.
+
+-i::
+--iterations::
+Repeat memcpy invocation this number of times.
+
+-c::
+--clock::
+Use perf's cpu-cycles event instead of gettimeofday syscall.
+
+-o::
+--only-prefault::
+Show only the result with page faults before memcpy.
+
+-n::
+--no-prefault::
+Show only the result without page faults before memcpy.
+
+*memset*::
+Suite for evaluating performance of simple memory set in various ways.
+
+Options of *memset*
+^^^^^^^^^^^^^^^^^^^
+-l::
+--length::
+Specify length of memory to set (default: 1MB).
+Available units are B, KB, MB, GB and TB (case insensitive).
+
+-r::
+--routine::
+Specify routine to set (default: default).
+Available routines are depend on the architecture.
+On x86-64, x86-64-unrolled, x86-64-stosq and x86-64-stosb are supported.
+
+-i::
+--iterations::
+Repeat memset invocation this number of times.
+
+-c::
+--clock::
+Use perf's cpu-cycles event instead of gettimeofday syscall.
+
+-o::
+--only-prefault::
+Show only the result with page faults before memset.
+
+-n::
+--no-prefault::
+Show only the result without page faults before memset.
+
SEE ALSO
--------
linkperf:perf[1]
diff --git a/tools/perf/bench/mem-memcpy.c b/tools/perf/bench/mem-memcpy.c
index 7155722..d990365 100644
--- a/tools/perf/bench/mem-memcpy.c
+++ b/tools/perf/bench/mem-memcpy.c
@@ -32,13 +32,13 @@ static bool no_prefault;
static const struct option options[] = {
OPT_STRING('l', "length", &length_str, "1MB",
"Specify length of memory to copy. "
- "available unit: B, MB, GB (upper and lower)"),
+ "Available units: B, KB, MB, GB and TB (upper and lower)"),
OPT_STRING('r', "routine", &routine, "default",
"Specify routine to copy"),
OPT_INTEGER('i', "iterations", &iterations,
"repeat memcpy() invocation this number of times"),
OPT_BOOLEAN('c', "clock", &use_clock,
- "Use CPU clock for measuring"),
+ "Use cycles event instead of gettimeofday() for measuring"),
OPT_BOOLEAN('o', "only-prefault", &only_prefault,
"Show only the result with page faults before memcpy()"),
OPT_BOOLEAN('n', "no-prefault", &no_prefault,
diff --git a/tools/perf/bench/mem-memset.c b/tools/perf/bench/mem-memset.c
index e907918..bf0d5f5 100644
--- a/tools/perf/bench/mem-memset.c
+++ b/tools/perf/bench/mem-memset.c
@@ -31,14 +31,14 @@ static bool no_prefault;

static const struct option options[] = {
OPT_STRING('l', "length", &length_str, "1MB",
- "Specify length of memory to copy. "
- "available unit: B, MB, GB (upper and lower)"),
+ "Specify length of memory to set. "
+ "Available units: B, KB, MB, GB and TB (upper and lower)"),
OPT_STRING('r', "routine", &routine, "default",
- "Specify routine to copy"),
+ "Specify routine to set"),
OPT_INTEGER('i', "iterations", &iterations,
"repeat memset() invocation this number of times"),
OPT_BOOLEAN('c', "clock", &use_clock,
- "Use CPU clock for measuring"),
+ "Use cycles event instead of gettimeofday() for measuring"),
OPT_BOOLEAN('o', "only-prefault", &only_prefault,
"Show only the result with page faults before memset()"),
OPT_BOOLEAN('n', "no-prefault", &no_prefault,
diff --git a/tools/perf/builtin-bench.c b/tools/perf/builtin-bench.c
index b0e74ab..1f31002 100644
--- a/tools/perf/builtin-bench.c
+++ b/tools/perf/builtin-bench.c
@@ -33,7 +33,7 @@ struct bench_suite {
};
\
/* sentinel: easy for help */
-#define suite_all { "all", "test all suite (pseudo suite)", NULL }
+#define suite_all { "all", "Test all benchmark suites", NULL }

static struct bench_suite sched_suites[] = {
{ "messaging",
@@ -75,7 +75,7 @@ static struct bench_subsys subsystems[] = {
"memory access performance",
mem_suites },
{ "all", /* sentinel: easy for help */
- "test all subsystem (pseudo subsystem)",
+ "all benchmark subsystem",
NULL },
{ NULL,
NULL,