2003-08-11 14:06:36

by Dave Jones

[permalink] [raw]
Subject: [PATCH] remove version.h from bttv

diff -urpN --exclude-from=/home/davej/.exclude bk-linus/drivers/media/video/bttvp.h linux-2.5/drivers/media/video/bttvp.h
--- bk-linus/drivers/media/video/bttvp.h 2003-08-07 19:45:39.000000000 +0100
+++ linux-2.5/drivers/media/video/bttvp.h 2003-08-07 22:20:17.000000000 +0100
@@ -24,7 +24,7 @@
#ifndef _BTTVP_H_
#define _BTTVP_H_

-#include <linux/version.h>
+
#define BTTV_VERSION_CODE KERNEL_VERSION(0,9,11)

#include <linux/types.h>


2003-08-11 16:36:13

by Gerd Knorr

[permalink] [raw]
Subject: Re: [PATCH] remove version.h from bttv

[email protected] writes:

> -#include <linux/version.h>
> +
> #define BTTV_VERSION_CODE KERNEL_VERSION(0,9,11)
^^^^^^^^^^^^^^

I'm pretty sure this will break the build ...

Gerd

--
sigfault

2003-08-11 17:01:36

by Valdis Klētnieks

[permalink] [raw]
Subject: Re: [PATCH] remove version.h from bttv

On Mon, 11 Aug 2003 18:30:54 +0200, Gerd Knorr <[email protected]> said:
> [email protected] writes:
>
> > -#include <linux/version.h>
> > +
> > #define BTTV_VERSION_CODE KERNEL_VERSION(0,9,11)
> ^^^^^^^^^^^^^^
>
> I'm pretty sure this will break the build ...

Not if all consumers of that .h file have already #included version.h (perhaps
indirectly).


Attachments:
(No filename) (226.00 B)