2003-01-25 17:40:52

by Jochen Hein

[permalink] [raw]
Subject: [TRIVIAL][ACPI, PCI] boot messages need line feeds


The messages are:

pci_link-0331 [15] acpi_pci_link_set : Link disabled
ACPI: PCI Interrupt Link [LNKA] enabled at IRQ 0
pci_link-0331 [15] acpi_pci_link_set : Link disabled
ACPI: PCI Interrupt Link [LNKB] enabled at IRQ 0
pci_link-0331 [15] acpi_pci_link_set : Link disabled
ACPI: PCI Interrupt Link [LNKC] enabled at IRQ 0
pci_link-0331 [15] acpi_pci_link_set : Link disabled
ACPI: PCI Interrupt Link [LNKD] enabled at IRQ 0
pci_link-0484 [16] acpi_pci_link_get_irq : Link disabled
pci_irq-0256 [15] acpi_pci_irq_lookup : Invalid IRQ link routing entry
pci_irq-0295 [15] acpi_pci_irq_derive : Unable to derive IRQ for device 00:02.0
ACPI: No IRQ known for interrupt pin A of device 00:02.0 - using IRQ 255
pci_link-0484 [16] acpi_pci_link_get_irq : Link disabled
pci_irq-0256 [15] acpi_pci_irq_lookup : Invalid IRQ link routing entry
pci_irq-0295 [15] acpi_pci_irq_derive : Unable to derive IRQ for device 00:02.1
ACPI: No IRQ known for interrupt pin B of device 00:02.1 - using IRQ 255
pci_link-0484 [16] acpi_pci_link_get_irq : Link disabled
pci_irq-0256 [15] acpi_pci_irq_lookup : Invalid IRQ link routing entry
pci_irq-0295 [15] acpi_pci_irq_derive : Unable to derive IRQ for device 00:03.0
ACPI: No IRQ known for interrupt pin A of device 00:03.0pci_link-0484 [16] acpi_pci_link_get_irq : Link disabled

^I think, here
should be a line feed. Next messages:

pci_irq-0256 [15] acpi_pci_irq_lookup : Invalid IRQ link routing entry
pci_irq-0295 [15] acpi_pci_irq_derive : Unable to derive IRQ for device 00:07.2
ACPI: No IRQ known for interrupt pin D of device 00:07.2<6>PCI: Using ACPI for IRQ routing
^and again.

The following patch sould fix it, but is for now untested:

--- linux-2.5.59/drivers/acpi/pci_irq.c.jh 2003-01-25 10:09:10.000000000 +0100
+++ linux-2.5.59/drivers/acpi/pci_irq.c 2003-01-25 10:10:54.000000000 +0100
@@ -351,8 +351,10 @@
printk(" - using IRQ %d\n", dev->irq);
return_VALUE(dev->irq);
}
- else
+ else {
+ printk("\n");
return_VALUE(0);
+ }
}

dev->irq = irq;

Jochen

--
Wenn Du nicht wei?t was Du tust, tu's mit Eleganz.