2024-01-12 16:36:04

by Kenzo Gomez

Subject: [PATCH] ALSA: hda: cs35l41: Support additional ASUS Zenbook UX3402VA

Add new model entry into configuration table.

Signed-off-by: Kenzo Gomez <[email protected]>
---
sound/pci/hda/cs35l41_hda_property.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/sound/pci/hda/cs35l41_hda_property.c b/sound/pci/hda/cs35l41_hda_property.c
index c1afb721b4c6..adfb31a6bf1e 100644
--- a/sound/pci/hda/cs35l41_hda_property.c
+++ b/sound/pci/hda/cs35l41_hda_property.c
@@ -67,6 +67,7 @@ static const struct cs35l41_config cs35l41_config_table[] = {
{ "10431D1F", I2C, 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
{ "10431DA2", SPI, 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 0, 0, 0 },
{ "10431E02", SPI, 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 0, 0, 0 },
+ { "104316A3", SPI, 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 0, 0, 0 },
{ "10431EE2", I2C, 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, -1, -1, 0, 0, 0 },
{ "10431F12", I2C, 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
{ "10431F1F", SPI, 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, -1, 0, 0, 0, 0 },
@@ -371,6 +372,7 @@ static const struct cs35l41_prop_model cs35l41_prop_model_table[] = {
{ "CSC3551", "10431D1F", generic_dsd_config },
{ "CSC3551", "10431DA2", generic_dsd_config },
{ "CSC3551", "10431E02", generic_dsd_config },
+ { "CSC3551", "104316A3", generic_dsd_config },
{ "CSC3551", "10431EE2", generic_dsd_config },
{ "CSC3551", "10431F12", generic_dsd_config },
{ "CSC3551", "10431F1F", generic_dsd_config },
--
2.43.0

2024-01-12 17:22:37

by Stefan Binding

Subject: RE: [PATCH] ALSA: hda: cs35l41: Support additional ASUS Zenbook UX3402VA

Hi,

> -----Original Message-----
> From: Kenzo Gomez <[email protected]>
> Sent: Friday, January 12, 2024 4:32 PM
> To: [email protected]
> Cc: Kenzo Gomez <[email protected]>; James Schulman
> <[email protected]>; David Rhodes
> <[email protected]>; Richard Fitzgerald
> <[email protected]>; Jaroslav Kysela <[email protected]>;
Takashi
> Iwai <[email protected]>; [email protected];
> [email protected]; [email protected]; linux-
> [email protected]
> Subject: [PATCH] ALSA: hda: cs35l41: Support additional ASUS Zenbook
> UX3402VA
>
> Add new model entry into configuration table.
>
> Signed-off-by: Kenzo Gomez <[email protected]>
> ---
> sound/pci/hda/cs35l41_hda_property.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/sound/pci/hda/cs35l41_hda_property.c
> b/sound/pci/hda/cs35l41_hda_property.c
> index c1afb721b4c6..adfb31a6bf1e 100644
> --- a/sound/pci/hda/cs35l41_hda_property.c
> +++ b/sound/pci/hda/cs35l41_hda_property.c
> @@ -67,6 +67,7 @@ static const struct cs35l41_config
> cs35l41_config_table[] = {
> { "10431D1F", I2C, 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT,
> 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
> { "10431DA2", SPI, 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT,
> 0, 0 }, 1, 2, 0, 0, 0, 0 },
> { "10431E02", SPI, 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT,
> 0, 0 }, 1, 2, 0, 0, 0, 0 },
> + { "104316A3", SPI, 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT,
> 0, 0 }, 1, 2, 0, 0, 0, 0 },

This entry looks correct, but this table is supposed to be sorted by
SSID,
can you move the entry to its correct location?

> { "10431EE2", I2C, 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT,
> 0, 0 }, 0, -1, -1, 0, 0, 0 },
> { "10431F12", I2C, 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT,
> 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
> { "10431F1F", SPI, 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT,
> 0, 0 }, 1, -1, 0, 0, 0, 0 },
> @@ -371,6 +372,7 @@ static const struct cs35l41_prop_model
> cs35l41_prop_model_table[] = {
> { "CSC3551", "10431D1F", generic_dsd_config },
> { "CSC3551", "10431DA2", generic_dsd_config },
> { "CSC3551", "10431E02", generic_dsd_config },
> + { "CSC3551", "104316A3", generic_dsd_config },

Same with this table, it should be sorted by SSID.

> { "CSC3551", "10431EE2", generic_dsd_config },
> { "CSC3551", "10431F12", generic_dsd_config },
> { "CSC3551", "10431F1F", generic_dsd_config },
> --
> 2.43.0
>

Thanks,
Stefan

2024-01-12 18:24:28

by Kenzo Gomez

Subject: [PATCH v2] ALSA: hda: cs35l41: Support additional ASUS Zenbook UX3402VA

Add new model entry into configuration table.

Signed-off-by: Kenzo Gomez <[email protected]>
---
sound/pci/hda/cs35l41_hda_property.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/sound/pci/hda/cs35l41_hda_property.c b/sound/pci/hda/cs35l41_hda_property.c
index c1afb721b4c6..9ec5773e580e 100644
--- a/sound/pci/hda/cs35l41_hda_property.c
+++ b/sound/pci/hda/cs35l41_hda_property.c
@@ -54,6 +54,7 @@ static const struct cs35l41_config cs35l41_config_table[] = {
{ "10431533", I2C, 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
{ "10431573", SPI, 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 1000, 4500, 24 },
{ "10431663", SPI, 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, -1, 0, 1000, 4500, 24 },
+ { "104316A3", SPI, 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 0, 0, 0 },
{ "104316D3", SPI, 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 0, 0, 0 },
{ "104316F3", SPI, 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 0, 0, 0 },
{ "104317F3", I2C, 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
@@ -358,6 +359,7 @@ static const struct cs35l41_prop_model cs35l41_prop_model_table[] = {
{ "CSC3551", "10431533", generic_dsd_config },
{ "CSC3551", "10431573", generic_dsd_config },
{ "CSC3551", "10431663", generic_dsd_config },
+ { "CSC3551", "104316A3", generic_dsd_config },
{ "CSC3551", "104316D3", generic_dsd_config },
{ "CSC3551", "104316F3", generic_dsd_config },
{ "CSC3551", "104317F3", generic_dsd_config },
--
2.43.0

2024-01-16 09:15:12

by Takashi Iwai

Subject: Re: [PATCH v2] ALSA: hda: cs35l41: Support additional ASUS Zenbook UX3402VA

On Fri, 12 Jan 2024 19:20:34 +0100,
Kenzo Gomez wrote:
>
> Add new model entry into configuration table.
>
> Signed-off-by: Kenzo Gomez <[email protected]>

This isn't applied cleanly to the latest code, as there were code
changes to drop some fields.

Please rebase on top of for-linus branch of sound.git tree (or the
latest Linus tree) and resubmit.


thanks,

Takashi

> ---
> sound/pci/hda/cs35l41_hda_property.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/sound/pci/hda/cs35l41_hda_property.c b/sound/pci/hda/cs35l41_hda_property.c
> index c1afb721b4c6..9ec5773e580e 100644
> --- a/sound/pci/hda/cs35l41_hda_property.c
> +++ b/sound/pci/hda/cs35l41_hda_property.c
> @@ -54,6 +54,7 @@ static const struct cs35l41_config cs35l41_config_table[] = {
> { "10431533", I2C, 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
> { "10431573", SPI, 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 1000, 4500, 24 },
> { "10431663", SPI, 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, -1, 0, 1000, 4500, 24 },
> + { "104316A3", SPI, 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 0, 0, 0 },
> { "104316D3", SPI, 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 0, 0, 0 },
> { "104316F3", SPI, 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 0, 0, 0 },
> { "104317F3", I2C, 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
> @@ -358,6 +359,7 @@ static const struct cs35l41_prop_model cs35l41_prop_model_table[] = {
> { "CSC3551", "10431533", generic_dsd_config },
> { "CSC3551", "10431573", generic_dsd_config },
> { "CSC3551", "10431663", generic_dsd_config },
> + { "CSC3551", "104316A3", generic_dsd_config },
> { "CSC3551", "104316D3", generic_dsd_config },
> { "CSC3551", "104316F3", generic_dsd_config },
> { "CSC3551", "104317F3", generic_dsd_config },
> --
> 2.43.0
>

2024-01-27 16:47:49

by Kenzo Gomez

Subject: [PATCH v3] ALSA: hda: cs35l41: Support additional ASUS Zenbook UX3402VA

Add new model entry into configuration table.

Signed-off-by: Kenzo Gomez <[email protected]>
---
sound/pci/hda/cs35l41_hda_property.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/sound/pci/hda/cs35l41_hda_property.c b/sound/pci/hda/cs35l41_hda_property.c
index 35277ce890a4..59504852adc6 100644
--- a/sound/pci/hda/cs35l41_hda_property.c
+++ b/sound/pci/hda/cs35l41_hda_property.c
@@ -76,6 +76,7 @@ static const struct cs35l41_config cs35l41_config_table[] = {
{ "10431533", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
{ "10431573", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 1000, 4500, 24 },
{ "10431663", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, -1, 0, 1000, 4500, 24 },
+ { "104316A3", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 0, 0, 0 },
{ "104316D3", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 0, 0, 0 },
{ "104316F3", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 0, 0, 0 },
{ "104317F3", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
@@ -410,6 +411,7 @@ static const struct cs35l41_prop_model cs35l41_prop_model_table[] = {
{ "CSC3551", "10431533", generic_dsd_config },
{ "CSC3551", "10431573", generic_dsd_config },
{ "CSC3551", "10431663", generic_dsd_config },
+ { "CSC3551", "104316A3", generic_dsd_config },
{ "CSC3551", "104316D3", generic_dsd_config },
{ "CSC3551", "104316F3", generic_dsd_config },
{ "CSC3551", "104317F3", generic_dsd_config },
--
2.43.0

2024-01-30 11:22:04

by Stefan Binding

Subject: RE: [PATCH v3] ALSA: hda: cs35l41: Support additional ASUS Zenbook UX3402VA

Hi,

> -----Original Message-----
> From: Takashi Iwai <[email protected]>
> Sent: Tuesday, January 30, 2024 11:05 AM
> To: Kenzo Gomez <[email protected]>
> Cc: [email protected]; [email protected];
> [email protected]; [email protected]; linux-
> [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]; [email protected]
> Subject: Re: [PATCH v3] ALSA: hda: cs35l41: Support additional ASUS
> Zenbook UX3402VA
>
> On Sat, 27 Jan 2024 17:46:21 +0100,
> Kenzo Gomez wrote:
> >
> > Add new model entry into configuration table.
> >
> > Signed-off-by: Kenzo Gomez <[email protected]>
>
> Cirrus people, could you take a look?
> I'm inclined to take as is, unless you have any objections.

Looks good to me.

Thanks,
Stefan

>
>
> thanks,
>
> Takashi
>
> > ---
> > sound/pci/hda/cs35l41_hda_property.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/sound/pci/hda/cs35l41_hda_property.c
> b/sound/pci/hda/cs35l41_hda_property.c
> > index 35277ce890a4..59504852adc6 100644
> > --- a/sound/pci/hda/cs35l41_hda_property.c
> > +++ b/sound/pci/hda/cs35l41_hda_property.c
> > @@ -76,6 +76,7 @@ static const struct cs35l41_config
> cs35l41_config_table[] = {
> > { "10431533", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0,
> 0 }, 0, 1, -1, 1000, 4500, 24 },
> > { "10431573", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0,
> 0 }, 1, 2, 0, 1000, 4500, 24 },
> > { "10431663", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0,
> 0 }, 1, -1, 0, 1000, 4500, 24 },
> > + { "104316A3", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0,
> 0 }, 1, 2, 0, 0, 0, 0 },
> > { "104316D3", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0,
> 0 }, 1, 2, 0, 0, 0, 0 },
> > { "104316F3", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0,
> 0 }, 1, 2, 0, 0, 0, 0 },
> > { "104317F3", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0,
> 0 }, 0, 1, -1, 1000, 4500, 24 },
> > @@ -410,6 +411,7 @@ static const struct cs35l41_prop_model
> cs35l41_prop_model_table[] = {
> > { "CSC3551", "10431533", generic_dsd_config },
> > { "CSC3551", "10431573", generic_dsd_config },
> > { "CSC3551", "10431663", generic_dsd_config },
> > + { "CSC3551", "104316A3", generic_dsd_config },
> > { "CSC3551", "104316D3", generic_dsd_config },
> > { "CSC3551", "104316F3", generic_dsd_config },
> > { "CSC3551", "104317F3", generic_dsd_config },
> > --
> > 2.43.0
> >

2024-01-30 11:33:20

by Takashi Iwai

Subject: Re: [PATCH v3] ALSA: hda: cs35l41: Support additional ASUS Zenbook UX3402VA

On Sat, 27 Jan 2024 17:46:21 +0100,
Kenzo Gomez wrote:
>
> Add new model entry into configuration table.
>
> Signed-off-by: Kenzo Gomez <[email protected]>

Cirrus people, could you take a look?
I'm inclined to take as is, unless you have any objections.


thanks,

Takashi

> ---
> sound/pci/hda/cs35l41_hda_property.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/sound/pci/hda/cs35l41_hda_property.c b/sound/pci/hda/cs35l41_hda_property.c
> index 35277ce890a4..59504852adc6 100644
> --- a/sound/pci/hda/cs35l41_hda_property.c
> +++ b/sound/pci/hda/cs35l41_hda_property.c
> @@ -76,6 +76,7 @@ static const struct cs35l41_config cs35l41_config_table[] = {
> { "10431533", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
> { "10431573", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 1000, 4500, 24 },
> { "10431663", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, -1, 0, 1000, 4500, 24 },
> + { "104316A3", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 0, 0, 0 },
> { "104316D3", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 0, 0, 0 },
> { "104316F3", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 0, 0, 0 },
> { "104317F3", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
> @@ -410,6 +411,7 @@ static const struct cs35l41_prop_model cs35l41_prop_model_table[] = {
> { "CSC3551", "10431533", generic_dsd_config },
> { "CSC3551", "10431573", generic_dsd_config },
> { "CSC3551", "10431663", generic_dsd_config },
> + { "CSC3551", "104316A3", generic_dsd_config },
> { "CSC3551", "104316D3", generic_dsd_config },
> { "CSC3551", "104316F3", generic_dsd_config },
> { "CSC3551", "104317F3", generic_dsd_config },
> --
> 2.43.0
>

2024-01-30 13:11:02

by Takashi Iwai

Subject: Re: [PATCH v3] ALSA: hda: cs35l41: Support additional ASUS Zenbook UX3402VA

On Sat, 27 Jan 2024 17:46:21 +0100,
Kenzo Gomez wrote:
>
> Add new model entry into configuration table.
>
> Signed-off-by: Kenzo Gomez <[email protected]>

Applied now. Thanks.


Takashi