2020-04-07 07:55:51

by Kai-Heng Feng

Subject: [PATCH] drm/i915: Force DPCD backlight mode for HP CML 2020 system

There's another Samsung OLED panel needs to use DPCD aux interface to
control backlight.

Signed-off-by: Kai-Heng Feng <[email protected]>
---
drivers/gpu/drm/drm_dp_helper.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c
index c6fbe6e6bc9d..d0cfee3b7a65 100644
--- a/drivers/gpu/drm/drm_dp_helper.c
+++ b/drivers/gpu/drm/drm_dp_helper.c
@@ -1299,6 +1299,8 @@ static const struct edid_quirk edid_quirk_list[] = {
* only supports DPCD backlight controls
*/
{ MFG(0x4c, 0x83), PROD_ID(0x41, 0x41), BIT(DP_QUIRK_FORCE_DPCD_BACKLIGHT) },
+ /* HP CML 2020 system */
+ { MFG(0x4c, 0x83), PROD_ID(0x45, 0x41), BIT(DP_QUIRK_FORCE_DPCD_BACKLIGHT) },
/*
* Some Dell CML 2020 systems have panels support both AUX and PWM
* backlight control, and some only support AUX backlight control. All
--
2.17.1

2020-04-08 08:07:15

by Jani Nikula

Subject: Re: [PATCH] drm/i915: Force DPCD backlight mode for HP CML 2020 system

On Tue, 07 Apr 2020, Kai-Heng Feng <[email protected]> wrote:
> There's another Samsung OLED panel needs to use DPCD aux interface to
> control backlight.

Acked-by: Jani Nikula <[email protected]>

>
> Signed-off-by: Kai-Heng Feng <[email protected]>
> ---
> drivers/gpu/drm/drm_dp_helper.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c
> index c6fbe6e6bc9d..d0cfee3b7a65 100644
> --- a/drivers/gpu/drm/drm_dp_helper.c
> +++ b/drivers/gpu/drm/drm_dp_helper.c
> @@ -1299,6 +1299,8 @@ static const struct edid_quirk edid_quirk_list[] = {
> * only supports DPCD backlight controls
> */
> { MFG(0x4c, 0x83), PROD_ID(0x41, 0x41), BIT(DP_QUIRK_FORCE_DPCD_BACKLIGHT) },
> + /* HP CML 2020 system */
> + { MFG(0x4c, 0x83), PROD_ID(0x45, 0x41), BIT(DP_QUIRK_FORCE_DPCD_BACKLIGHT) },
> /*
> * Some Dell CML 2020 systems have panels support both AUX and PWM
> * backlight control, and some only support AUX backlight control. All

--
Jani Nikula, Intel Open Source Graphics Center

2020-10-07 07:07:15

by Kai-Heng Feng

Subject: Re: [PATCH] drm/i915: Force DPCD backlight mode for HP CML 2020 system

> On Apr 8, 2020, at 15:23, Jani Nikula <[email protected]> wrote:
>
> On Tue, 07 Apr 2020, Kai-Heng Feng <[email protected]> wrote:
>> There's another Samsung OLED panel needs to use DPCD aux interface to
>> control backlight.
>
> Acked-by: Jani Nikula <[email protected]>

David,

Can you please merge this patch? Thanks.

Kai-Heng

>
>>
>> Signed-off-by: Kai-Heng Feng <[email protected]>
>> ---
>> drivers/gpu/drm/drm_dp_helper.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c
>> index c6fbe6e6bc9d..d0cfee3b7a65 100644
>> --- a/drivers/gpu/drm/drm_dp_helper.c
>> +++ b/drivers/gpu/drm/drm_dp_helper.c
>> @@ -1299,6 +1299,8 @@ static const struct edid_quirk edid_quirk_list[] = {
>> * only supports DPCD backlight controls
>> */
>> { MFG(0x4c, 0x83), PROD_ID(0x41, 0x41), BIT(DP_QUIRK_FORCE_DPCD_BACKLIGHT) },
>> + /* HP CML 2020 system */
>> + { MFG(0x4c, 0x83), PROD_ID(0x45, 0x41), BIT(DP_QUIRK_FORCE_DPCD_BACKLIGHT) },
>> /*
>> * Some Dell CML 2020 systems have panels support both AUX and PWM
>> * backlight control, and some only support AUX backlight control. All
>
> --
> Jani Nikula, Intel Open Source Graphics Center