2019-05-01 10:14:31

by Toke Høiland-Jørgensen

Subject: Re: [PATCH] mac80211: fix possible deadlock in TX path

Erik Stromdahl <[email protected]> writes:

> This patch fixes a possible deadlock when updating the TX statistics
> (when calling into ieee80211_tx_stats()) from ieee80211_tx_dequeue().

So is this the fix for the issue with TX scheduling you reported
earlier? :)

-Toke

2019-05-01 11:08:01

by Erik Stromdahl

Subject: Re: [PATCH] mac80211: fix possible deadlock in TX path

On 4/30/19 9:49 AM, Toke Høiland-Jørgensen wrote:
> Erik Stromdahl <[email protected]> writes:
>
>> This patch fixes a possible deadlock when updating the TX statistics
>> (when calling into ieee80211_tx_stats()) from ieee80211_tx_dequeue().
>
> So is this the fix for the issue with TX scheduling you reported
> earlier? :)
>

Actually not. I thought so initially, but then, after a few more test runs,
I was able to run into the issue again.

But it does seem to fix the other issue with the RCU stall since I haven't
seen it with this patch applied (could be just a coincidence though).

--
Erik