2012-11-03 06:28:51

by Namjae Jeon

Subject: [PATCH v2 2/3] fat: notify when discard is not supported

FAT also notify warning message about discard support
as ext4(http://patchwork.ozlabs.org/patch/192668/)

Signed-off-by: Namjae Jeon <[email protected]>
Signed-off-by: Amit Sahrawat <[email protected]>
---
fs/fat/inode.c | 9 +++++++++
1 file changed, 9 insertions(+)

diff --git a/fs/fat/inode.c b/fs/fat/inode.c
index 8d79657..3b48bab 100644
--- a/fs/fat/inode.c
+++ b/fs/fat/inode.c
@@ -26,6 +26,7 @@
#include <linux/writeback.h>
#include <linux/log2.h>
#include <linux/hash.h>
+#include <linux/blkdev.h>
#include <asm/unaligned.h>
#include "fat.h"

@@ -1446,6 +1447,14 @@ int fat_fill_super(struct super_block *sb, void *data, int silent, int isvfat,
goto out_fail;
}

+ if (sbi->options.discard) {
+ struct request_queue *q = bdev_get_queue(sb->s_bdev);
+ if (!blk_queue_discard(q))
+ fat_msg(sb, KERN_WARNING,
+ "mounting with \"discard\" option, but "
+ "the device does not support discard");
+ }
+
return 0;

out_invalid:
--
1.7.9.5

2012-11-05 10:53:20

by OGAWA Hirofumi

Subject: Re: [PATCH v2 2/3] fat: notify when discard is not supported

Namjae Jeon <[email protected]> writes:

> FAT also notify warning message about discard support
> as ext4(http://patchwork.ozlabs.org/patch/192668/)

Acked-by: OGAWA Hirofumi <[email protected]>

> Signed-off-by: Namjae Jeon <[email protected]>
> Signed-off-by: Amit Sahrawat <[email protected]>
> ---
> fs/fat/inode.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/fs/fat/inode.c b/fs/fat/inode.c
> index 8d79657..3b48bab 100644
> --- a/fs/fat/inode.c
> +++ b/fs/fat/inode.c
> @@ -26,6 +26,7 @@
> #include <linux/writeback.h>
> #include <linux/log2.h>
> #include <linux/hash.h>
> +#include <linux/blkdev.h>
> #include <asm/unaligned.h>
> #include "fat.h"
>
> @@ -1446,6 +1447,14 @@ int fat_fill_super(struct super_block *sb, void *data, int silent, int isvfat,
> goto out_fail;
> }
>
> + if (sbi->options.discard) {
> + struct request_queue *q = bdev_get_queue(sb->s_bdev);
> + if (!blk_queue_discard(q))
> + fat_msg(sb, KERN_WARNING,
> + "mounting with \"discard\" option, but "
> + "the device does not support discard");
> + }
> +
> return 0;
>
> out_invalid:

--
OGAWA Hirofumi <[email protected]>