2006-11-27 15:02:04

by Alan

[permalink] [raw]
Subject: Re: [PATCH] IDE: typo in ide-io.c leads to faulty assignment

On Mon, 27 Nov 2006 15:51:33 +0100
Elias Oltmanns <[email protected]> wrote:

> Due to a typo in ide_start_power_step, the result of a function rather
> than its pointer is assigned to args->handler.

NAK

If it was the result of the function it would end with (arguments);

Alan

2006-11-27 16:01:18

by Jesper Juhl

[permalink] [raw]
Subject: Re: [PATCH] IDE: typo in ide-io.c leads to faulty assignment

On 27/11/06, Elias Oltmanns <[email protected]> wrote:
> Due to a typo in ide_start_power_step, the result of a function rather
> than its pointer is assigned to args->handler. The patch applies to
> 2.6.19-rc6 but the problem exists in the stable branch as well.
>

These two lines :

- args->handler = task_no_data_intr;
+ args->handler = &task_no_data_intr;

do the same thing.

--
Jesper Juhl <[email protected]>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html

2006-11-27 16:31:20

by Elias Oltmanns

[permalink] [raw]
Subject: Re: [PATCH] IDE: typo in ide-io.c leads to faulty assignment

"Jesper Juhl" <[email protected]> wrote:
> These two lines :
>
> - args->handler = task_no_data_intr;
> + args->handler = &task_no_data_intr;
>
> do the same thing.

Thanks for explaining, obviously I got a bit confused.

Sorry for the noise.

Elias