2018-12-07 01:35:33

by Matteo Croce

[permalink] [raw]
Subject: [PATCH] vfat: don't read garbage after last dirent

The FAT32 File System Specification[1] states:

If DIR_Name[0] == 0x00, then the directory entry is free, and there
are no allocated directory entries after this one.

The special 0 value, indicates to FAT file system driver code that
the rest of the entries in this directory do notneed to be examined
because they are all free.

This is not enforced by Linux, and is possible to read garbage if
not all the dirents after the last one are filled with zeroes.

[1] http://download.microsoft.com/download/1/6/1/161ba512-40e2-4cc9-843a-923143f3456c/fatgen103.doc

Reported-by: Timothy Redaelli <[email protected]>
Signed-off-by: Matteo Croce <[email protected]>
---
fs/fat/dir.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/fat/dir.c b/fs/fat/dir.c
index c8366cb8eccd..0cec89271349 100644
--- a/fs/fat/dir.c
+++ b/fs/fat/dir.c
@@ -588,7 +588,7 @@ static int __fat_readdir(struct inode *inode, struct file *file,

bh = NULL;
get_new:
- if (fat_get_entry(inode, &cpos, &bh, &de) == -1)
+ if (fat_get_entry(inode, &cpos, &bh, &de) == -1 || !de->name[0])
goto end_of_dir;
parse_record:
nr_slots = 0;
--
2.19.2



2018-12-08 17:18:11

by Matteo Croce

[permalink] [raw]
Subject: Re: [PATCH] vfat: don't read garbage after last dirent

On Fri, Dec 7, 2018 at 1:34 AM Matteo Croce <[email protected]> wrote:
> the rest of the entries in this directory do notneed to be examined

I made a small typo, it should be "do not need"

Regards,
--
Matteo Croce
per aspera ad upstream

2018-12-14 03:42:53

by OGAWA Hirofumi

[permalink] [raw]
Subject: Re: [PATCH] vfat: don't read garbage after last dirent

Matteo Croce <[email protected]> writes:

> The FAT32 File System Specification[1] states:
>
> If DIR_Name[0] == 0x00, then the directory entry is free, and there
> are no allocated directory entries after this one.
>
> The special 0 value, indicates to FAT file system driver code that
> the rest of the entries in this directory do notneed to be examined
> because they are all free.
>
> This is not enforced by Linux, and is possible to read garbage if
> not all the dirents after the last one are filled with zeroes.
>
> [1] http://download.microsoft.com/download/1/6/1/161ba512-40e2-4cc9-843a-923143f3456c/fatgen103.doc
>
> Reported-by: Timothy Redaelli <[email protected]>
> Signed-off-by: Matteo Croce <[email protected]>

I know this spec. But name[0] == 0 means - the rest of the entries in
this directory must be 0. Otherwise, overwriting zeroed entry by adding
new dir entry, then shows garbage as dir entry. So "stop at zero" is
just a optimization.

On other hand, I know there is buggy formatters don't clear that
garbage, and uses it on read-only storage area.

So I will agree to supporting "stop at zero" though (and keep assuming
dir is initialized with zero clear. i.e. don't add tricky workaround to
support buggy formatters.), the implementation should handle it for
whole path, not only readdir().

E.g. I recall lookup, dir empty check path, and maybe there are others I
can't recall immediately.

> get_new:
> - if (fat_get_entry(inode, &cpos, &bh, &de) == -1)
> + if (fat_get_entry(inode, &cpos, &bh, &de) == -1 || !de->name[0])
> goto end_of_dir;
> parse_record:
> nr_slots = 0;

Thanks.
--
OGAWA Hirofumi <[email protected]>