2007-01-08 16:25:57

by Dmitri Monakhov

[permalink] [raw]
Subject: [PATCH] Broadcom 4400 resume small fix


Attachments:
(No filename) (170.00 B)
diff-ms-net-b44 (546.00 B)
Download all attachments

2007-01-08 21:03:30

by Francois Romieu

[permalink] [raw]
Subject: Re: [PATCH] Broadcom 4400 resume small fix

Dmitriy Monakhov <[email protected]> :
> Return value of 'pci_enable_device' was ignored in b44_resume().
> We can't ingore it because it can fail.

- Please Cc: [email protected], [email protected] and the maintainer
of the driver (Gary Zambrano <[email protected]> as per MAINTAINERS
file and the log of the driveri).
- the dev_err() message fits completely on a 80 columns line.
- request-irq is not checked a few lines below either.

It would be nice to avoid the free_irq/pci_disable_device dance altogether.

--
Ueimor