Hi all,
In commit
0f7555121609 ("drm/i915/gvt: release shadow batch buffer and wa_ctx before destroy one workload")
Fixes tag
Fixes: 0cce2823ed37 ("drm/i915/gvt/kvmgt:Refine error handling for prepare_execlist_workload")
has these problem(s):
- Subject does not match target commit subject
Just some whitespace.
--
Cheers,
Stephen Rothwell
On Thu, 24 Jan 2019, Stephen Rothwell <[email protected]> wrote:
> Hi all,
>
> In commit
>
> 0f7555121609 ("drm/i915/gvt: release shadow batch buffer and wa_ctx before destroy one workload")
>
> Fixes tag
>
> Fixes: 0cce2823ed37 ("drm/i915/gvt/kvmgt:Refine error handling for prepare_execlist_workload")
>
> has these problem(s):
>
> - Subject does not match target commit subject
>
> Just some whitespace.
Thanks for the report. The commit being referenced seems to be the right
one, though, so I don't think I'm going to force push to fix this.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
Thank Stephen.
I am not sure about the problem. The commit id "0cce2823ed37" is just for the patch of "drm/i915/gvt: Refine error handling for prepare_execlist_workload". Is there any other problems I missed?
Regards.
-Weinan
> -----Original Message-----
> From: Jani Nikula [mailto:[email protected]]
> Sent: Thursday, January 24, 2019 7:33 PM
> To: Stephen Rothwell <[email protected]>; Daniel Vetter
> <[email protected]>; Joonas Lahtinen <[email protected]>;
> Vivi, Rodrigo <[email protected]>; Intel Graphics
> <[email protected]>; DRI <[email protected]>
> Cc: Linux Next Mailing List <[email protected]>; Linux Kernel Mailing List
> <[email protected]>; Li, Weinan Z <[email protected]>; Zhenyu
> Wang <[email protected]>
> Subject: Re: linux-next: Fixes tag needs some work in the drm-intel-fixes tree
>
> On Thu, 24 Jan 2019, Stephen Rothwell <[email protected]> wrote:
> > Hi all,
> >
> > In commit
> >
> > 0f7555121609 ("drm/i915/gvt: release shadow batch buffer and wa_ctx
> > before destroy one workload")
> >
> > Fixes tag
> >
> > Fixes: 0cce2823ed37 ("drm/i915/gvt/kvmgt:Refine error handling for
> > prepare_execlist_workload")
> >
> > has these problem(s):
> >
> > - Subject does not match target commit subject
> >
> > Just some whitespace.
>
> Thanks for the report. The commit being referenced seems to be the right one,
> though, so I don't think I'm going to force push to fix this.
>
> BR,
> Jani.
>
> --
> Jani Nikula, Intel Open Source Graphics Center
Hi,
On Fri, 25 Jan 2019 01:21:26 +0000 "Li, Weinan Z" <[email protected]> wrote:
>
> I am not sure about the problem. The commit id "0cce2823ed37" is just
> for the patch of "drm/i915/gvt: Refine error handling for
> prepare_execlist_workload". Is there any other problems I missed?
Its just that the subject line of that commit has a space after the
':', but the copy of that subject line in the Fixes tag omitted that
space. This is not a big issue, my script just pointed it out.
Its not worth doing anything about it, just take a bit more care in the
future.
--
Cheers,
Stephen Rothwell