On Mon, Aug 07, 2017 at 04:22:27PM +0200, Oleg Kokorin wrote:
> From 336f8adb0292a25ea41f0515a80850031f814b9b Mon Sep 17 00:00:00 2001
> From: Oleg Kokorin <[email protected]>
> Date: Mon, 7 Aug 2017 15:35:53 +0200
> Subject: [PATCH] append Qualcomm GOBI 2K chipset ID for Panasonic CF-U1
> Toughbook
Please use
USB: serial: qcserial: add support for Panasonic CF-U1 Toughbook
as Subject (patch summary), and also add a commit message here (e.g.
your current summary).
> Signed-off-by: Oleg Kokorin <[email protected]>
> ---
> drivers/usb/serial/qcserial.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/usb/serial/qcserial.c b/drivers/usb/serial/qcserial.c
> index ebc0bee..53786ce 100644
> --- a/drivers/usb/serial/qcserial.c
> +++ b/drivers/usb/serial/qcserial.c
> @@ -76,6 +76,8 @@ static const struct usb_device_id id_table[] = {
> {DEVICE_G1K(0x1bc7, 0x900e)}, /* Telit Gobi QDL device */
>
> /* Gobi 2000 devices */
> + {USB_DEVICE(0x04da, 0x250e)}, /* Panasonic Gobi 2000 QDL device */
> + {USB_DEVICE(0x04da, 0x250f)}, /* Panasonic Gobi 2000 Modem device */
This patch is whitespace-damaged and does not apply. Please try sending
the patch to yourself first (e.g. using git-send-email) and make sure
you can apply it it with git am. Running checkpatch on the result is
also a good idea.
> {USB_DEVICE(0x1410, 0xa010)}, /* Novatel Gobi 2000 QDL device */
> {USB_DEVICE(0x1410, 0xa011)}, /* Novatel Gobi 2000 QDL device */
> {USB_DEVICE(0x1410, 0xa012)}, /* Novatel Gobi 2000 QDL device */
Thanks,
Johan
Johan Hovold <[email protected]> writes:
> On Mon, Aug 07, 2017 at 04:22:27PM +0200, Oleg Kokorin wrote:
>> From 336f8adb0292a25ea41f0515a80850031f814b9b Mon Sep 17 00:00:00 2001
>> From: Oleg Kokorin <[email protected]>
>> Date: Mon, 7 Aug 2017 15:35:53 +0200
>> Subject: [PATCH] append Qualcomm GOBI 2K chipset ID for Panasonic CF-U1
>> Toughbook
>
> Please use
>
> USB: serial: qcserial: add support for Panasonic CF-U1 Toughbook
>
> as Subject (patch summary), and also add a commit message here (e.g.
> your current summary).
>
>> Signed-off-by: Oleg Kokorin <[email protected]>
>> ---
>> drivers/usb/serial/qcserial.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/usb/serial/qcserial.c b/drivers/usb/serial/qcserial.c
>> index ebc0bee..53786ce 100644
>> --- a/drivers/usb/serial/qcserial.c
>> +++ b/drivers/usb/serial/qcserial.c
>> @@ -76,6 +76,8 @@ static const struct usb_device_id id_table[] = {
>> {DEVICE_G1K(0x1bc7, 0x900e)}, /* Telit Gobi QDL device */
>>
>> /* Gobi 2000 devices */
>> + {USB_DEVICE(0x04da, 0x250e)}, /* Panasonic Gobi 2000 QDL device */
>> + {USB_DEVICE(0x04da, 0x250f)}, /* Panasonic Gobi 2000 Modem device */
>
> This patch is whitespace-damaged and does not apply. Please try sending
> the patch to yourself first (e.g. using git-send-email) and make sure
> you can apply it it with git am. Running checkpatch on the result is
> also a good idea.
And please send a patch for qmi_wwan too, assuming this really is a Gobi
2000 modem. Thanks.
Bjørn