2013-10-09 09:50:54

by Ionut Nicu

[permalink] [raw]
Subject: [PATCH 1/2] i2c-mux-gpio: use deferred probing

If the i2c-parent bus driver is not loaded, returning
-ENODEV will force people to unload and then reload the
module again to get it working.

Signed-off-by: Ionut Nicu <[email protected]>
---
drivers/i2c/muxes/i2c-mux-gpio.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/i2c/muxes/i2c-mux-gpio.c b/drivers/i2c/muxes/i2c-mux-gpio.c
index 5d4a99b..ff184eb 100644
--- a/drivers/i2c/muxes/i2c-mux-gpio.c
+++ b/drivers/i2c/muxes/i2c-mux-gpio.c
@@ -79,7 +79,7 @@ static int i2c_mux_gpio_probe_dt(struct gpiomux *mux,
adapter = of_find_i2c_adapter_by_node(adapter_np);
if (!adapter) {
dev_err(&pdev->dev, "Cannot find parent bus\n");
- return -ENODEV;
+ return -EPROBE_DEFER;
}
mux->data.parent = i2c_adapter_id(adapter);
put_device(&adapter->dev);
@@ -177,7 +177,7 @@ static int i2c_mux_gpio_probe(struct platform_device *pdev)
if (!parent) {
dev_err(&pdev->dev, "Parent adapter (%d) not found\n",
mux->data.parent);
- return -ENODEV;
+ return -EPROBE_DEFER;
}

mux->parent = parent;
--
1.7.1


2013-10-09 10:14:18

by Peter Korsgaard

[permalink] [raw]
Subject: Re: [PATCH 1/2] i2c-mux-gpio: use deferred probing

>>>>> "IN" == Ionut Nicu <[email protected]> writes:

IN> If the i2c-parent bus driver is not loaded, returning
IN> -ENODEV will force people to unload and then reload the
IN> module again to get it working.

IN> Signed-off-by: Ionut Nicu <[email protected]>

Acked-by: Peter Korsgaard <[email protected]>

--
Sorry about disclaimer - It's out of my control.
Bye, Peter Korsgaard
This message is subject to the following terms and conditions: MAIL DISCLAIMER<http://www.barco.com/en/maildisclaimer>