2023-05-30 16:04:50

by Ben Schneider

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: marvell: Fix espressobin-ultra boot failure and wifi

May 29, 2023, 16:07 by [email protected]:

> Please Cc: the maintainers:
> Reviewed-by: Andrew Lunn <[email protected]>

Sorry! Maintainers cc'd.

Ben



2023-05-31 10:20:35

by Gregory CLEMENT

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: marvell: Fix espressobin-ultra boot failure and wifi

Hello Ben Schneider,

> May 29, 2023, 16:07 by [email protected]:
>
>> Please Cc: the maintainers:
>> Reviewed-by: Andrew Lunn <[email protected]>
>
> Sorry! Maintainers cc'd.

I don't see the patch so I can't apply it...

Gregory

>
> Ben
>

--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com

2023-05-31 16:15:13

by Ben Schneider

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: marvell: Fix espressobin-ultra boot failure and wifi

May 31, 2023, 09:20 by [email protected]:

>
> I don't see the patch so I can't apply it...
>
>
Hi Gregory, sorry I wasn't sure if I should resend the patch.

Boot hangs on EspressoBIN Ultra (Armada 3720) after a message that device
vcc_sd1 had been disabled. The device manufacturer patched this issue in
their kernel fork noting that vcc_sd1 is used by the EspressoBIN model
but not the EspressoBIN Ultra. Removing the device from the tree fixes
the boot hang and wifi.

Link: https://github.com/globalscaletechnologies/linux/commit/b879d560eebf2766781614a0169a9564f1e0fc06

Signed-off-by: Ben Schneider <[email protected]>
Reviewed-by: Andrew Lunn <[email protected]>
---
arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts | 3 +++
1 file changed, 3 insertions(+)

diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts
index d29d2da95..f9abef8dc 100644
--- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts
+++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts
@@ -24,6 +24,8 @@
                ethernet5 = &switch0port4;
        };
 
+       /delete-node/ regulator;
+
        reg_usb3_vbus: usb3-vbus {
                compatible = "regulator-fixed";
                regulator-name = "usb3-vbus";
@@ -66,6 +68,7 @@
};
 
&sdhci1 {
+       /delete-property/ vqmmc-supply;
        status = "disabled";
};

2023-06-02 07:04:22

by Gregory CLEMENT

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: marvell: Fix espressobin-ultra boot failure and wifi

Ben Schneider <[email protected]> writes:

> May 31, 2023, 09:20 by [email protected]:
>
>>
>> I don't see the patch so I can't apply it...
>>
>>
> Hi Gregory, sorry I wasn't sure if I should resend the patch.


Thanks however it is still not applicable, could you send with git-send
email ?

>
> Boot hangs on EspressoBIN Ultra (Armada 3720) after a message that device
> vcc_sd1 had been disabled. The device manufacturer patched this issue in
> their kernel fork noting that vcc_sd1 is used by the EspressoBIN model
> but not the EspressoBIN Ultra. Removing the device from the tree fixes
> the boot hang and wifi.
>
> Link: https://github.com/globalscaletechnologies/linux/commit/b879d560eebf2766781614a0169a9564f1e0fc06
>
> Signed-off-by: Ben Schneider <[email protected]>
> Reviewed-by: Andrew Lunn <[email protected]>
> ---
> arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts
> index d29d2da95..f9abef8dc 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts
> @@ -24,6 +24,8 @@
>                 ethernet5 = &switch0port4;
>         };
>  
> +       /delete-node/ regulator;
> +
>         reg_usb3_vbus: usb3-vbus {
>                 compatible = "regulator-fixed";
>                 regulator-name = "usb3-vbus";
> @@ -66,6 +68,7 @@
> };
>  
> &sdhci1 {
> +       /delete-property/ vqmmc-supply;
>         status = "disabled";
> };

--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com

2023-06-03 05:36:26

by Benjamin Schneider

[permalink] [raw]
Subject: [PATCH] arm64: dts: marvell: Fix espressobin-ultra boot failure and wifi

Boot hangs on EspressoBIN Ultra (Armada 3720) after a message that device
vcc_sd1 had been disabled. The device manufacturer patched this issue in
their kernel fork noting that vcc_sd1 is used by the EspressoBIN model
but not the EspressoBIN Ultra. Removing the device from the tree fixes
the boot hang and wifi.

Signed-off-by: Ben Schneider <[email protected]>
Reviewed-by: Andrew Lunn <[email protected]>
---
arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts | 3 +++
1 file changed, 3 insertions(+)

diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts
index d29d2da95..f9abef8dc 100644
--- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts
+++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts
@@ -24,6 +24,8 @@
ethernet5 = &switch0port4;
};

+ /delete-node/ regulator;
+
reg_usb3_vbus: usb3-vbus {
compatible = "regulator-fixed";
regulator-name = "usb3-vbus";
@@ -66,6 +68,7 @@
};

&sdhci1 {
+ /delete-property/ vqmmc-supply;
status = "disabled";
};

--
2.17.1


2023-06-16 12:25:57

by Gregory CLEMENT

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: marvell: Fix espressobin-ultra boot failure and wifi

Ben Schneider <[email protected]> writes:

> Boot hangs on EspressoBIN Ultra (Armada 3720) after a message that device
> vcc_sd1 had been disabled. The device manufacturer patched this issue in
> their kernel fork noting that vcc_sd1 is used by the EspressoBIN model
> but not the EspressoBIN Ultra. Removing the device from the tree fixes
> the boot hang and wifi.
>
> Signed-off-by: Ben Schneider <[email protected]>
> Reviewed-by: Andrew Lunn <[email protected]>

Applied on mvebu/dt64

Thanks,

Gregory
> ---
> arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts
> index d29d2da95..f9abef8dc 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts
> @@ -24,6 +24,8 @@
> ethernet5 = &switch0port4;
> };
>
> + /delete-node/ regulator;
> +
> reg_usb3_vbus: usb3-vbus {
> compatible = "regulator-fixed";
> regulator-name = "usb3-vbus";
> @@ -66,6 +68,7 @@
> };
>
> &sdhci1 {
> + /delete-property/ vqmmc-supply;
> status = "disabled";
> };
>
> --
> 2.17.1
>

--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com