2022-05-16 20:23:33

by Thomas Huth

Subject: [PATCH] include/uapi/linux/vfio.h: Fix trivial typo - _IORW should be _IOWR instead

There is no macro called _IORW, so use _IOWR in the comment instead.

Signed-off-by: Thomas Huth <[email protected]>
---
include/uapi/linux/vfio.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/uapi/linux/vfio.h b/include/uapi/linux/vfio.h
index fea86061b44e..733a1cddde30 100644
--- a/include/uapi/linux/vfio.h
+++ b/include/uapi/linux/vfio.h
@@ -643,7 +643,7 @@ enum {
};

/**
- * VFIO_DEVICE_GET_PCI_HOT_RESET_INFO - _IORW(VFIO_TYPE, VFIO_BASE + 12,
+ * VFIO_DEVICE_GET_PCI_HOT_RESET_INFO - _IOWR(VFIO_TYPE, VFIO_BASE + 12,
* struct vfio_pci_hot_reset_info)
*
* Return: 0 on success, -errno on failure:
@@ -770,7 +770,7 @@ struct vfio_device_ioeventfd {
#define VFIO_DEVICE_IOEVENTFD _IO(VFIO_TYPE, VFIO_BASE + 16)

/**
- * VFIO_DEVICE_FEATURE - _IORW(VFIO_TYPE, VFIO_BASE + 17,
+ * VFIO_DEVICE_FEATURE - _IOWR(VFIO_TYPE, VFIO_BASE + 17,
* struct vfio_device_feature)
*
* Get, set, or probe feature data of the device. The feature is selected
--
2.27.0

2022-05-16 20:35:04

by Cornelia Huck

Subject: Re: [PATCH] include/uapi/linux/vfio.h: Fix trivial typo - _IORW should be _IOWR instead

On Mon, May 16 2022, Thomas Huth <[email protected]> wrote:

> There is no macro called _IORW, so use _IOWR in the comment instead.
>
> Signed-off-by: Thomas Huth <[email protected]>
> ---
> include/uapi/linux/vfio.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Cornelia Huck <[email protected]>

2022-05-18 17:55:06

by Alex Williamson

Subject: Re: [PATCH] include/uapi/linux/vfio.h: Fix trivial typo - _IORW should be _IOWR instead

On Mon, 16 May 2022 12:12:02 +0200
Thomas Huth <[email protected]> wrote:

> There is no macro called _IORW, so use _IOWR in the comment instead.
>
> Signed-off-by: Thomas Huth <[email protected]>
> ---
> include/uapi/linux/vfio.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/uapi/linux/vfio.h b/include/uapi/linux/vfio.h
> index fea86061b44e..733a1cddde30 100644
> --- a/include/uapi/linux/vfio.h
> +++ b/include/uapi/linux/vfio.h
> @@ -643,7 +643,7 @@ enum {
> };
>
> /**
> - * VFIO_DEVICE_GET_PCI_HOT_RESET_INFO - _IORW(VFIO_TYPE, VFIO_BASE + 12,
> + * VFIO_DEVICE_GET_PCI_HOT_RESET_INFO - _IOWR(VFIO_TYPE, VFIO_BASE + 12,
> * struct vfio_pci_hot_reset_info)
> *
> * Return: 0 on success, -errno on failure:
> @@ -770,7 +770,7 @@ struct vfio_device_ioeventfd {
> #define VFIO_DEVICE_IOEVENTFD _IO(VFIO_TYPE, VFIO_BASE + 16)
>
> /**
> - * VFIO_DEVICE_FEATURE - _IORW(VFIO_TYPE, VFIO_BASE + 17,
> + * VFIO_DEVICE_FEATURE - _IOWR(VFIO_TYPE, VFIO_BASE + 17,
> * struct vfio_device_feature)
> *
> * Get, set, or probe feature data of the device. The feature is selected

Applied to vfio next branch for v5.19. Thanks!

Alex