Greeting,
FYI, we noticed the following commit (built with gcc-11):
commit: 530d96220d0d99cff9b5a3583210df2b5b5f6408 ("xfs: Directory's data fork extent counter can never overflow")
url: https://github.com/intel-lab-lkp/linux/commits/UPDATE-20220409-214913/Chandan-Babu-R/xfs-Extend-per-inode-extent-counters/20220406-174647
in testcase: xfstests
version: xfstests-x86_64-46e1b83-1_20220414
with following parameters:
disk: 4HDD
fs: xfs
test: xfs-group-53
ucode: 0x21
test-description: xfstests is a regression test suite for xfs and other files ystems.
test-url: git://git.kernel.org/pub/scm/fs/xfs/xfstests-dev.git
on test machine: 4 threads 1 sockets Intel(R) Core(TM) i3-3220 CPU @ 3.30GHz with 8G memory
caused below changes (please refer to attached dmesg/kmsg for entire log/backtrace):
If you fix the issue, kindly add following tag
Reported-by: kernel test robot <[email protected]>
2022-04-15 11:30:13 export TEST_DIR=/fs/sda1
2022-04-15 11:30:13 export TEST_DEV=/dev/sda1
2022-04-15 11:30:13 export FSTYP=xfs
2022-04-15 11:30:13 export SCRATCH_MNT=/fs/scratch
2022-04-15 11:30:13 mkdir /fs/scratch -p
2022-04-15 11:30:13 export SCRATCH_DEV=/dev/sda4
2022-04-15 11:30:13 export SCRATCH_LOGDEV=/dev/sda2
2022-04-15 11:30:13 export SCRATCH_XFS_LIST_METADATA_FIELDS=u3.sfdir3.hdr.parent.i4
2022-04-15 11:30:13 export SCRATCH_XFS_LIST_FUZZ_VERBS=random
2022-04-15 11:30:13 sed "s:^:xfs/:" //lkp/benchmarks/xfstests/tests/xfs-group-53
2022-04-15 11:30:13 ./check xfs/531 xfs/532 xfs/533 xfs/534 xfs/538 xfs/539
FSTYP -- xfs (debug)
PLATFORM -- Linux/x86_64 lkp-ivb-d05 5.17.0-rc6-00044-g530d96220d0d #1 SMP Fri Apr 15 17:47:01 CST 2022
MKFS_OPTIONS -- -f /dev/sda4
MOUNT_OPTIONS -- /dev/sda4 /fs/scratch
xfs/531 4s
xfs/532 28s
xfs/533 [failed, exit status 1]- output mismatch (see /lkp/benchmarks/xfstests/results//xfs/533.out.bad)
--- tests/xfs/533.out 2022-04-14 12:51:49.000000000 +0000
+++ /lkp/benchmarks/xfstests/results//xfs/533.out.bad 2022-04-15 11:31:08.365436563 +0000
@@ -6,12 +6,4 @@
Inject bmap_alloc_minlen_extent error tag
* Create directory entries
Verify directory's extent count
-* Rename: Populate destination directory
-Populate $dstdir by moving new directory entries
-Verify $dstdir's extent count
-* Create multiple hard links to a single file
...
(Run 'diff -u /lkp/benchmarks/xfstests/tests/xfs/533.out /lkp/benchmarks/xfstests/results//xfs/533.out.bad' to see the entire diff)
xfs/534 2s
xfs/538 489s
xfs/539 2s
Ran: xfs/531 xfs/532 xfs/533 xfs/534 xfs/538 xfs/539
Failures: xfs/533
Failed 1 of 6 tests
To reproduce:
git clone https://github.com/intel/lkp-tests.git
cd lkp-tests
sudo bin/lkp install job.yaml # job file is attached in this email
bin/lkp split-job --compatible job.yaml # generate the yaml file for lkp run
sudo bin/lkp run generated-yaml-file
# if come across any failure that blocks the test,
# please remove ~/.lkp and /lkp dir to run from a clean state.
--
0-DAY CI Kernel Test Service
https://01.org/lkp
On 18 Apr 2022 at 14:31, kernel test robot wrote:
> Greeting,
>
> FYI, we noticed the following commit (built with gcc-11):
>
> commit: 530d96220d0d99cff9b5a3583210df2b5b5f6408 ("xfs: Directory's data fork extent counter can never overflow")
> url: https://github.com/intel-lab-lkp/linux/commits/UPDATE-20220409-214913/Chandan-Babu-R/xfs-Extend-per-inode-extent-counters/20220406-174647
>
> in testcase: xfstests
> version: xfstests-x86_64-46e1b83-1_20220414
> with following parameters:
>
> disk: 4HDD
> fs: xfs
> test: xfs-group-53
> ucode: 0x21
>
> test-description: xfstests is a regression test suite for xfs and other files ystems.
> test-url: git://git.kernel.org/pub/scm/fs/xfs/xfstests-dev.git
>
>
> on test machine: 4 threads 1 sockets Intel(R) Core(TM) i3-3220 CPU @ 3.30GHz with 8G memory
>
> caused below changes (please refer to attached dmesg/kmsg for entire log/backtrace):
>
>
>
>
> If you fix the issue, kindly add following tag
> Reported-by: kernel test robot <[email protected]>
>
> 2022-04-15 11:30:13 export TEST_DIR=/fs/sda1
> 2022-04-15 11:30:13 export TEST_DEV=/dev/sda1
> 2022-04-15 11:30:13 export FSTYP=xfs
> 2022-04-15 11:30:13 export SCRATCH_MNT=/fs/scratch
> 2022-04-15 11:30:13 mkdir /fs/scratch -p
> 2022-04-15 11:30:13 export SCRATCH_DEV=/dev/sda4
> 2022-04-15 11:30:13 export SCRATCH_LOGDEV=/dev/sda2
> 2022-04-15 11:30:13 export SCRATCH_XFS_LIST_METADATA_FIELDS=u3.sfdir3.hdr.parent.i4
> 2022-04-15 11:30:13 export SCRATCH_XFS_LIST_FUZZ_VERBS=random
> 2022-04-15 11:30:13 sed "s:^:xfs/:" //lkp/benchmarks/xfstests/tests/xfs-group-53
> 2022-04-15 11:30:13 ./check xfs/531 xfs/532 xfs/533 xfs/534 xfs/538 xfs/539
> FSTYP -- xfs (debug)
> PLATFORM -- Linux/x86_64 lkp-ivb-d05 5.17.0-rc6-00044-g530d96220d0d #1 SMP Fri Apr 15 17:47:01 CST 2022
> MKFS_OPTIONS -- -f /dev/sda4
> MOUNT_OPTIONS -- /dev/sda4 /fs/scratch
>
> xfs/531 4s
> xfs/532 28s
> xfs/533 [failed, exit status 1]- output mismatch (see /lkp/benchmarks/xfstests/results//xfs/533.out.bad)
> --- tests/xfs/533.out 2022-04-14 12:51:49.000000000 +0000
> +++ /lkp/benchmarks/xfstests/results//xfs/533.out.bad 2022-04-15 11:31:08.365436563 +0000
> @@ -6,12 +6,4 @@
> Inject bmap_alloc_minlen_extent error tag
> * Create directory entries
> Verify directory's extent count
> -* Rename: Populate destination directory
> -Populate $dstdir by moving new directory entries
> -Verify $dstdir's extent count
> -* Create multiple hard links to a single file
> ...
> (Run 'diff -u /lkp/benchmarks/xfstests/tests/xfs/533.out /lkp/benchmarks/xfstests/results//xfs/533.out.bad' to see the entire diff)
The "Large extent counter" patchset removes code which checked for directory
extent count overflow since an operation on a directory can never cause its
extent count to overflow. However, the following check is added to
xfs_dinode_verify() to check for ondisk corruption when reading an inode from
disk,
if (S_ISDIR(mode) && nextents > mp->m_dir_geo->max_extents)
return __this_address;
I have written a patch to remove xfs/533 from fstests. I will post it soon.
--
chandan