2021-08-04 13:31:23

by Colin King

Subject: [PATCH][next] usb: gadget: f_uac2: remove redundant assignments to pointer i_feature

From: Colin Ian King <[email protected]>

Pointer i_feature is being initialized with a value and then immediately
re-assigned a new value in the next statement. Fix this by replacing the
the redundant initialization with the following assigned value.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <[email protected]>
---
drivers/usb/gadget/function/f_uac2.c | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/drivers/usb/gadget/function/f_uac2.c b/drivers/usb/gadget/function/f_uac2.c
index b9edc6787f79..3c34995276e7 100644
--- a/drivers/usb/gadget/function/f_uac2.c
+++ b/drivers/usb/gadget/function/f_uac2.c
@@ -970,17 +970,13 @@ afunc_bind(struct usb_configuration *cfg, struct usb_function *fn)
std_as_in_if1_desc.iInterface = us[STR_AS_IN_ALT1].id;

if (FUOUT_EN(uac2_opts)) {
- u8 *i_feature = (u8 *)out_feature_unit_desc;
-
- i_feature = (u8 *)out_feature_unit_desc +
- out_feature_unit_desc->bLength - 1;
+ u8 *i_feature = (u8 *)out_feature_unit_desc +
+ out_feature_unit_desc->bLength - 1;
*i_feature = us[STR_FU_OUT].id;
}
if (FUIN_EN(uac2_opts)) {
- u8 *i_feature = (u8 *)in_feature_unit_desc;
-
- i_feature = (u8 *)in_feature_unit_desc +
- in_feature_unit_desc->bLength - 1;
+ u8 *i_feature = (u8 *)in_feature_unit_desc +
+ in_feature_unit_desc->bLength - 1;
*i_feature = us[STR_FU_IN].id;
}

--
2.31.1

2021-08-04 14:04:31

by Felipe Balbi

Subject: Re: [PATCH][next] usb: gadget: f_uac2: remove redundant assignments to pointer i_feature

Colin King <[email protected]> writes:

> From: Colin Ian King <[email protected]>
>
> Pointer i_feature is being initialized with a value and then immediately
> re-assigned a new value in the next statement. Fix this by replacing the
> the redundant initialization with the following assigned value.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <[email protected]>

Acked-by: Felipe Balbi <[email protected]>

--
balbi