2013-05-13 08:59:06

by Gu Zheng

Subject: [PATCH] fs/fat: Use fat_msg() to replace printk() in __fat_fs_error()

>From 87141ec058aad35ac55bc7c3fc2eb378566a5a6a Mon Sep 17 00:00:00 2001
From: Gu Zheng <[email protected]>
Date: Mon, 13 May 2013 17:48:19 +0900
Subject: [PATCH] fs/fat: Use fat_msg() to replace printk() in __fat_fs_error()


Signed-off-by: Gu Zheng <[email protected]>
---
fs/fat/misc.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/fs/fat/misc.c b/fs/fat/misc.c
index 359d307..628e22a 100644
--- a/fs/fat/misc.c
+++ b/fs/fat/misc.c
@@ -30,7 +30,7 @@ void __fat_fs_error(struct super_block *sb, int report, const char *fmt, ...)
va_start(args, fmt);
vaf.fmt = fmt;
vaf.va = &args;
- printk(KERN_ERR "FAT-fs (%s): error, %pV\n", sb->s_id, &vaf);
+ fat_msg(sb, KERN_ERR, "error, %pV", &vaf);
va_end(args);
}

@@ -38,8 +38,7 @@ void __fat_fs_error(struct super_block *sb, int report, const char *fmt, ...)
panic("FAT-fs (%s): fs panic from previous error\n", sb->s_id);
else if (opts->errors == FAT_ERRORS_RO && !(sb->s_flags & MS_RDONLY)) {
sb->s_flags |= MS_RDONLY;
- printk(KERN_ERR "FAT-fs (%s): Filesystem has been "
- "set read-only\n", sb->s_id);
+ fat_msg(sb, KERN_ERR, "Filesystem has been set read-only");
}
}
EXPORT_SYMBOL_GPL(__fat_fs_error);
--
1.7.1

2013-05-13 09:28:34

by OGAWA Hirofumi

Subject: Re: [PATCH] fs/fat: Use fat_msg() to replace printk() in __fat_fs_error()

Gu Zheng <[email protected]> writes:

>>From 87141ec058aad35ac55bc7c3fc2eb378566a5a6a Mon Sep 17 00:00:00 2001
> From: Gu Zheng <[email protected]>
> Date: Mon, 13 May 2013 17:48:19 +0900
> Subject: [PATCH] fs/fat: Use fat_msg() to replace printk() in __fat_fs_error()

> - printk(KERN_ERR "FAT-fs (%s): error, %pV\n", sb->s_id, &vaf);
> + fat_msg(sb, KERN_ERR, "error, %pV", &vaf);
> va_end(args);

I'm assuming nested "%pV" is works fine. If so,

Acked-by: OGAWA Hirofumi <[email protected]>

> @@ -38,8 +38,7 @@ void __fat_fs_error(struct super_block *sb, int report, const char *fmt, ...)
> panic("FAT-fs (%s): fs panic from previous error\n", sb->s_id);
> else if (opts->errors == FAT_ERRORS_RO && !(sb->s_flags & MS_RDONLY)) {
> sb->s_flags |= MS_RDONLY;
> - printk(KERN_ERR "FAT-fs (%s): Filesystem has been "
> - "set read-only\n", sb->s_id);
> + fat_msg(sb, KERN_ERR, "Filesystem has been set read-only");
> }
> }
> EXPORT_SYMBOL_GPL(__fat_fs_error);

--
OGAWA Hirofumi <[email protected]>

2013-05-14 03:18:25

by Gu Zheng

Subject: Re: [PATCH] fs/fat: Use fat_msg() to replace printk() in __fat_fs_error()

On 05/13/2013 05:28 PM, OGAWA Hirofumi wrote:

> Gu Zheng <[email protected]> writes:
>
>> >From 87141ec058aad35ac55bc7c3fc2eb378566a5a6a Mon Sep 17 00:00:00 2001
>> From: Gu Zheng <[email protected]>
>> Date: Mon, 13 May 2013 17:48:19 +0900
>> Subject: [PATCH] fs/fat: Use fat_msg() to replace printk() in __fat_fs_error()
>
>> - printk(KERN_ERR "FAT-fs (%s): error, %pV\n", sb->s_id, &vaf);
>> + fat_msg(sb, KERN_ERR, "error, %pV", &vaf);
>> va_end(args);
>
> I'm assuming nested "%pV" is works fine. If so,

It works fine, I've tested this.

>
> Acked-by: OGAWA Hirofumi <[email protected]>

Thanks!

Best regards,
Gu

>
>> @@ -38,8 +38,7 @@ void __fat_fs_error(struct super_block *sb, int report, const char *fmt, ...)
>> panic("FAT-fs (%s): fs panic from previous error\n", sb->s_id);
>> else if (opts->errors == FAT_ERRORS_RO && !(sb->s_flags & MS_RDONLY)) {
>> sb->s_flags |= MS_RDONLY;
>> - printk(KERN_ERR "FAT-fs (%s): Filesystem has been "
>> - "set read-only\n", sb->s_id);
>> + fat_msg(sb, KERN_ERR, "Filesystem has been set read-only");
>> }
>> }
>> EXPORT_SYMBOL_GPL(__fat_fs_error);
>