2016-11-10 22:21:18

by Nikolaus Rath

[permalink] [raw]
Subject: commit 5c672ab3f0ee0f78f: fuse: serialize dirops by default

Hi Miklos,

In commit 5c672ab3f0ee0f78f7acad183f34db0f8781a200 you introduced a new
FUSE_PARALLEL_DIROPS capability and bumped the kernel interface no to
25 - but there have been no corresponding changes to userspace.

Is this still preliminary and thus deliberately not in libfuse? I only
noticed it by chance.

Best,
-Nikolaus

--
GPG encrypted emails preferred. Key id: 0xD113FCAC3C4E599F
Fingerprint: ED31 791B 2C5C 1613 AF38 8B8A D113 FCAC 3C4E 599F

»Time flies like an arrow, fruit flies like a Banana.«


2016-11-10 22:26:36

by Miklos Szeredi

[permalink] [raw]
Subject: Re: commit 5c672ab3f0ee0f78f: fuse: serialize dirops by default

On Thu, Nov 10, 2016 at 11:21 PM, Nikolaus Rath <[email protected]> wrote:
> Hi Miklos,
>
> In commit 5c672ab3f0ee0f78f7acad183f34db0f8781a200 you introduced a new
> FUSE_PARALLEL_DIROPS capability and bumped the kernel interface no to
> 25 - but there have been no corresponding changes to userspace.

I think libfuse3 should always set this, it's just for backward compatibility.

> Is this still preliminary and thus deliberately not in libfuse? I only
> noticed it by chance.

Oops, I just forgot about it.

Thanks,
Miklos

2016-11-11 04:53:12

by Nikolaus Rath

[permalink] [raw]
Subject: Re: commit 5c672ab3f0ee0f78f: fuse: serialize dirops by default

On Nov 10 2016, Miklos Szeredi <[email protected]> wrote:
> On Thu, Nov 10, 2016 at 11:21 PM, Nikolaus Rath <[email protected]> wrote:
>> Hi Miklos,
>>
>> In commit 5c672ab3f0ee0f78f7acad183f34db0f8781a200 you introduced a new
>> FUSE_PARALLEL_DIROPS capability and bumped the kernel interface no to
>> 25 - but there have been no corresponding changes to userspace.
>
> I think libfuse3 should always set this, it's just for backward compatibility.
>
>> Is this still preliminary and thus deliberately not in libfuse? I only
>> noticed it by chance.
>
> Oops, I just forgot about it.

Are you going to send a patch/pull request? If not, I don't mind adding
it either.


Best,
-Nikolaus

--
GPG encrypted emails preferred. Key id: 0xD113FCAC3C4E599F
Fingerprint: ED31 791B 2C5C 1613 AF38 8B8A D113 FCAC 3C4E 599F


»Time flies like an arrow, fruit flies like a Banana.«