2013-10-23 13:13:07

by Thierry Reding

[permalink] [raw]
Subject: [PATCH] mmc: sdhci: dove: Fix build breakage

Commit 2d7c51f (mmc: sdhci: Use work structs instead of tasklets)
converts tasklets to work structs, but typos the conversion in the Dove
driver.

Signed-off-by: Thierry Reding <[email protected]>
---
drivers/mmc/host/sdhci-dove.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/host/sdhci-dove.c b/drivers/mmc/host/sdhci-dove.c
index 45c7f25..95f1076 100644
--- a/drivers/mmc/host/sdhci-dove.c
+++ b/drivers/mmc/host/sdhci-dove.c
@@ -39,7 +39,7 @@ static irqreturn_t sdhci_dove_carddetect_irq(int irq, void *data)
{
struct sdhci_host *host = data;

- schedule_schedule(&host->card_detect_work);
+ schedule_work(&host->card_detect_work);
return IRQ_HANDLED;
}

--
1.8.4


2013-10-23 13:46:28

by Jeremie Samuel

[permalink] [raw]
Subject: Re: [PATCH] mmc: sdhci: dove: Fix build breakage

Soory, I thought I had corrected this typo.

Signed-off-by: Jeremie Samuel <[email protected]>

--
Jeremie Samuel Parrot S.A.
Software Engineer 14, quai de Jemmapes
R&D/OS Platform 75010 Paris, France
http://www.parrot.com

On 23/10/2013 15:10, Thierry Reding wrote:
> Commit 2d7c51f (mmc: sdhci: Use work structs instead of tasklets)
> converts tasklets to work structs, but typos the conversion in the Dove
> driver.
>
> Signed-off-by: Thierry Reding <[email protected]>
> ---
> drivers/mmc/host/sdhci-dove.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-dove.c b/drivers/mmc/host/sdhci-dove.c
> index 45c7f25..95f1076 100644
> --- a/drivers/mmc/host/sdhci-dove.c
> +++ b/drivers/mmc/host/sdhci-dove.c
> @@ -39,7 +39,7 @@ static irqreturn_t sdhci_dove_carddetect_irq(int irq, void *data)
> {
> struct sdhci_host *host = data;
>
> - schedule_schedule(&host->card_detect_work);
> + schedule_work(&host->card_detect_work);
> return IRQ_HANDLED;
> }
>

2013-10-27 12:57:03

by Chris Ball

[permalink] [raw]
Subject: Re: [PATCH] mmc: sdhci: dove: Fix build breakage

Hi,

On Wed, Oct 23 2013, Thierry Reding wrote:
> Commit 2d7c51f (mmc: sdhci: Use work structs instead of tasklets)
> converts tasklets to work structs, but typos the conversion in the Dove
> driver.
>
> Signed-off-by: Thierry Reding <[email protected]>
> ---
> drivers/mmc/host/sdhci-dove.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-dove.c b/drivers/mmc/host/sdhci-dove.c
> index 45c7f25..95f1076 100644
> --- a/drivers/mmc/host/sdhci-dove.c
> +++ b/drivers/mmc/host/sdhci-dove.c
> @@ -39,7 +39,7 @@ static irqreturn_t sdhci_dove_carddetect_irq(int irq, void *data)
> {
> struct sdhci_host *host = data;
>
> - schedule_schedule(&host->card_detect_work);
> + schedule_work(&host->card_detect_work);
> return IRQ_HANDLED;
> }

Thanks, Thierry -- I hope it's okay with you if I merge your fix into
the original patch and add your S-o-b to that patch:

Signed-off-by: Anton Vorontsov <[email protected]>
Signed-off-by: Jeremie Samuel <[email protected]>
[treding: Fix typo causing sdhci-dove build breakage]
Signed-off-by: Thierry Reding <[email protected]>
Signed-off-by: Chris Ball <[email protected]>

- Chris.
--
Chris Ball <[email protected]> <http://printf.net/>

2013-10-28 07:47:51

by Thierry Reding

[permalink] [raw]
Subject: Re: [PATCH] mmc: sdhci: dove: Fix build breakage

On Sun, Oct 27, 2013 at 08:56:55AM -0400, Chris Ball wrote:
> Hi,
>
> On Wed, Oct 23 2013, Thierry Reding wrote:
> > Commit 2d7c51f (mmc: sdhci: Use work structs instead of tasklets)
> > converts tasklets to work structs, but typos the conversion in the Dove
> > driver.
> >
> > Signed-off-by: Thierry Reding <[email protected]>
> > ---
> > drivers/mmc/host/sdhci-dove.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/mmc/host/sdhci-dove.c b/drivers/mmc/host/sdhci-dove.c
> > index 45c7f25..95f1076 100644
> > --- a/drivers/mmc/host/sdhci-dove.c
> > +++ b/drivers/mmc/host/sdhci-dove.c
> > @@ -39,7 +39,7 @@ static irqreturn_t sdhci_dove_carddetect_irq(int irq, void *data)
> > {
> > struct sdhci_host *host = data;
> >
> > - schedule_schedule(&host->card_detect_work);
> > + schedule_work(&host->card_detect_work);
> > return IRQ_HANDLED;
> > }
>
> Thanks, Thierry -- I hope it's okay with you if I merge your fix into
> the original patch and add your S-o-b to that patch:
>
> Signed-off-by: Anton Vorontsov <[email protected]>
> Signed-off-by: Jeremie Samuel <[email protected]>
> [treding: Fix typo causing sdhci-dove build breakage]
> Signed-off-by: Thierry Reding <[email protected]>
> Signed-off-by: Chris Ball <[email protected]>

Sure, no problem.

Thierry

Attachments:
(No filename) (1.32 kB)
 (No filename) (836.00 B)
 Download all attachments