2019-11-10 10:42:31

by Zheng Yongjun

Subject: [PATCH] net: ll_temac: Remove set but not used variable 'start_p'

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/net/ethernet/xilinx/ll_temac_main.c: In function temac_start_xmit:
drivers/net/ethernet/xilinx/ll_temac_main.c:737:13: warning: variable start_p set but not used [-Wunused-but-set-variable]

start_p is never used, so remove it.

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Zheng Yongjun <[email protected]>
---
drivers/net/ethernet/xilinx/ll_temac_main.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/xilinx/ll_temac_main.c b/drivers/net/ethernet/xilinx/ll_temac_main.c
index 21c1b4322ea7..b37433be6b7f 100644
--- a/drivers/net/ethernet/xilinx/ll_temac_main.c
+++ b/drivers/net/ethernet/xilinx/ll_temac_main.c
@@ -819,14 +819,13 @@ temac_start_xmit(struct sk_buff *skb, struct net_device *ndev)
{
struct temac_local *lp = netdev_priv(ndev);
struct cdmac_bd *cur_p;
- dma_addr_t start_p, tail_p, skb_dma_addr;
+ dma_addr_t tail_p, skb_dma_addr;
int ii;
unsigned long num_frag;
skb_frag_t *frag;

num_frag = skb_shinfo(skb)->nr_frags;
frag = &skb_shinfo(skb)->frags[0];
- start_p = lp->tx_bd_p + sizeof(*lp->tx_bd_v) * lp->tx_bd_tail;
cur_p = &lp->tx_bd_v[lp->tx_bd_tail];

if (temac_check_tx_bd_space(lp, num_frag + 1)) {
--
2.23.0

2019-11-11 12:35:03

by Esben Haabendal

Subject: Re: [PATCH] net: ll_temac: Remove set but not used variable 'start_p'

Zheng Yongjun <[email protected]> writes:

> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/ethernet/xilinx/ll_temac_main.c: In function temac_start_xmit:
> drivers/net/ethernet/xilinx/ll_temac_main.c:737:13: warning: variable start_p set but not used [-Wunused-but-set-variable]
>
> start_p is never used, so remove it.
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Zheng Yongjun <[email protected]>

Acked-by: Esben Haabendal <[email protected]>