2008-07-08 08:30:02

by Johannes Weiner

Subject: [PATCH] lguest: fix switcher_page leak on unload

map_switcher allocates the array, unmap_switcher has to free it
accordingly.

Signed-off-by: Johannes Weiner <[email protected]>
---

diff --git a/drivers/lguest/core.c b/drivers/lguest/core.c
index 5eea435..90663e0 100644
--- a/drivers/lguest/core.c
+++ b/drivers/lguest/core.c
@@ -135,6 +135,7 @@ static void unmap_switcher(void)
/* Now we just need to free the pages we copied the switcher into */
for (i = 0; i < TOTAL_SWITCHER_PAGES; i++)
__free_pages(switcher_page[i], 0);
+ kfree(switcher_page);
}

/*H:032

2008-07-08 09:32:19

by Rusty Russell

Subject: Re: [PATCH] lguest: fix switcher_page leak on unload

On Tuesday 08 July 2008 18:29:42 Johannes Weiner wrote:
> map_switcher allocates the array, unmap_switcher has to free it
> accordingly.

Applied, thanks Johannes! A small mem leak on module remove probably isn't
worth sending for -rc9, but queued for next merge.

Cheers,
Rusty.