2023-12-23 18:34:45

by Dario Binacchi

Subject: [PATCH v2] drm/debugfs: drop unneeded DEBUG_FS guard

The Makefile enables/disables the file compilation depending on
CONFIG_DEBUG_FS.

Signed-off-by: Dario Binacchi <[email protected]>
Reviewed-by: Jani Nikula <[email protected]>

---

Changes in v2:
- Add 'Reviewed-by' tag of Jani Nikula

drivers/gpu/drm/drm_debugfs.c | 4 ----
1 file changed, 4 deletions(-)

diff --git a/drivers/gpu/drm/drm_debugfs.c b/drivers/gpu/drm/drm_debugfs.c
index f291fb4b359f..f80d9cf3e71a 100644
--- a/drivers/gpu/drm/drm_debugfs.c
+++ b/drivers/gpu/drm/drm_debugfs.c
@@ -45,8 +45,6 @@
#include "drm_crtc_internal.h"
#include "drm_internal.h"

-#if defined(CONFIG_DEBUG_FS)
-
/***************************************************
* Initialization, etc.
**************************************************/
@@ -588,5 +586,3 @@ void drm_debugfs_crtc_remove(struct drm_crtc *crtc)
debugfs_remove_recursive(crtc->debugfs_entry);
crtc->debugfs_entry = NULL;
}
-
-#endif /* CONFIG_DEBUG_FS */
--
2.43.0

2024-01-02 14:49:06

by Jani Nikula

Subject: Re: [PATCH v2] drm/debugfs: drop unneeded DEBUG_FS guard

On Sat, 23 Dec 2023, Dario Binacchi <[email protected]> wrote:
> The Makefile enables/disables the file compilation depending on
> CONFIG_DEBUG_FS.
>
> Signed-off-by: Dario Binacchi <[email protected]>
> Reviewed-by: Jani Nikula <[email protected]>

Thanks for the patch, pushed to drm-misc-next.

BR,
Jani.

>
> ---
>
> Changes in v2:
> - Add 'Reviewed-by' tag of Jani Nikula
>
> drivers/gpu/drm/drm_debugfs.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_debugfs.c b/drivers/gpu/drm/drm_debugfs.c
> index f291fb4b359f..f80d9cf3e71a 100644
> --- a/drivers/gpu/drm/drm_debugfs.c
> +++ b/drivers/gpu/drm/drm_debugfs.c
> @@ -45,8 +45,6 @@
> #include "drm_crtc_internal.h"
> #include "drm_internal.h"
>
> -#if defined(CONFIG_DEBUG_FS)
> -
> /***************************************************
> * Initialization, etc.
> **************************************************/
> @@ -588,5 +586,3 @@ void drm_debugfs_crtc_remove(struct drm_crtc *crtc)
> debugfs_remove_recursive(crtc->debugfs_entry);
> crtc->debugfs_entry = NULL;
> }
> -
> -#endif /* CONFIG_DEBUG_FS */

--
Jani Nikula, Intel