2024-05-16 08:34:17

by Jani Nikula

Subject: [PATCH] drm: have config DRM_WERROR depend on !WERROR

If WERROR is already enabled, there's no point in enabling DRM_WERROR or
asking users about it.

Reported-by: Linus Torvalds <[email protected]>
Closes: https://lore.kernel.org/r/CAHk-=whxT8D_0j=bjtrvj-O=VEOjn6GW8GK4j2V+BiDUntZKAQ@mail.gmail.com
Fixes: f89632a9e5fa ("drm: Add CONFIG_DRM_WERROR")
Signed-off-by: Jani Nikula <[email protected]>
---
drivers/gpu/drm/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
index 026444eeb5c6..d0aa277fc3bf 100644
--- a/drivers/gpu/drm/Kconfig
+++ b/drivers/gpu/drm/Kconfig
@@ -450,6 +450,7 @@ config DRM_PRIVACY_SCREEN
config DRM_WERROR
bool "Compile the drm subsystem with warnings as errors"
depends on DRM && EXPERT
+ depends on !WERROR
default n
help
A kernel build should not cause any compiler warnings, and this
--
2.39.2

2024-05-16 12:37:31

by Sui Jingfeng

Subject: Re: drm: have config DRM_WERROR depend on !WERROR

Hi,


On 5/16/24 16:33, Jani Nikula wrote:
> If WERROR is already enabled, there's no point in enabling DRM_WERROR or
> asking users about it.
>
> Reported-by: Linus Torvalds <[email protected]>
> Closes: https://lore.kernel.org/r/CAHk-=whxT8D_0j=bjtrvj-O=VEOjn6GW8GK4j2V+BiDUntZKAQ@mail.gmail.com
> Fixes: f89632a9e5fa ("drm: Add CONFIG_DRM_WERROR")
> Signed-off-by: Jani Nikula <[email protected]>

Wow, you successfully get Linus's attention, haha.

> ---
> drivers/gpu/drm/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
> index 026444eeb5c6..d0aa277fc3bf 100644
> --- a/drivers/gpu/drm/Kconfig
> +++ b/drivers/gpu/drm/Kconfig
> @@ -450,6 +450,7 @@ config DRM_PRIVACY_SCREEN
> config DRM_WERROR
> bool "Compile the drm subsystem with warnings as errors"
> depends on DRM && EXPERT
> + depends on !WERROR
> default n
> help
> A kernel build should not cause any compiler warnings, and this

--
Best regards
Sui

2024-06-07 12:24:34

by Jani Nikula

Subject: Re: [PATCH] drm: have config DRM_WERROR depend on !WERROR

On Thu, 16 May 2024, Jani Nikula <[email protected]> wrote:
> If WERROR is already enabled, there's no point in enabling DRM_WERROR or
> asking users about it.

Ping. Any comments? (Besides the one snark.)


BR,
Jani.

>
> Reported-by: Linus Torvalds <[email protected]>
> Closes: https://lore.kernel.org/r/CAHk-=whxT8D_0j=bjtrvj-O=VEOjn6GW8GK4j2V+BiDUntZKAQ@mail.gmail.com
> Fixes: f89632a9e5fa ("drm: Add CONFIG_DRM_WERROR")
> Signed-off-by: Jani Nikula <[email protected]>
> ---
> drivers/gpu/drm/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
> index 026444eeb5c6..d0aa277fc3bf 100644
> --- a/drivers/gpu/drm/Kconfig
> +++ b/drivers/gpu/drm/Kconfig
> @@ -450,6 +450,7 @@ config DRM_PRIVACY_SCREEN
> config DRM_WERROR
> bool "Compile the drm subsystem with warnings as errors"
> depends on DRM && EXPERT
> + depends on !WERROR
> default n
> help
> A kernel build should not cause any compiler warnings, and this

--
Jani Nikula, Intel

2024-06-07 12:38:03

by Javier Martinez Canillas

Subject: Re: [PATCH] drm: have config DRM_WERROR depend on !WERROR

Jani Nikula <[email protected]> writes:

Hello Jani,

> If WERROR is already enabled, there's no point in enabling DRM_WERROR or
> asking users about it.
>
> Reported-by: Linus Torvalds <[email protected]>
> Closes: https://lore.kernel.org/r/CAHk-=whxT8D_0j=bjtrvj-O=VEOjn6GW8GK4j2V+BiDUntZKAQ@mail.gmail.com
> Fixes: f89632a9e5fa ("drm: Add CONFIG_DRM_WERROR")
> Signed-off-by: Jani Nikula <[email protected]>
> ---

The change makes sense to me.

Reviewed-by: Javier Martinez Canillas <[email protected]>

--
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat

2024-06-07 15:11:44

by Jani Nikula

Subject: Re: [PATCH] drm: have config DRM_WERROR depend on !WERROR

On Fri, 07 Jun 2024, Javier Martinez Canillas <[email protected]> wrote:
> Jani Nikula <[email protected]> writes:
>
> Hello Jani,
>
>> If WERROR is already enabled, there's no point in enabling DRM_WERROR or
>> asking users about it.
>>
>> Reported-by: Linus Torvalds <[email protected]>
>> Closes: https://lore.kernel.org/r/CAHk-=whxT8D_0j=bjtrvj-O=VEOjn6GW8GK4j2V+BiDUntZKAQ@mail.gmail.com
>> Fixes: f89632a9e5fa ("drm: Add CONFIG_DRM_WERROR")
>> Signed-off-by: Jani Nikula <[email protected]>
>> ---
>
> The change makes sense to me.
>
> Reviewed-by: Javier Martinez Canillas <[email protected]>

Thanks, pushed to drm-misc-fixes.

BR,
Jani.

--
Jani Nikula, Intel