On Tue, 2022-04-26 at 17:52 -0500, Eric W. Biederman wrote:
> User mode linux is the last user of the PT_DTRACE flag. Using the flag to indicate
> single stepping is a little confusing and worse changing tsk->ptrace without locking
> could potentionally cause problems.
>
> So use a thread info flag with a better name instead of flag in tsk->ptrace.
>
> Remove the definition PT_DTRACE as uml is the last user.
Looks fine to me.
Acked-by: Johannes Berg <[email protected]>
Looking at pending patches, I don't see any conflicts from this. I'm
guessing anyway you'll want/need to take these through some tree all
together.
johannes
Johannes Berg <[email protected]> writes:
> On Tue, 2022-04-26 at 17:52 -0500, Eric W. Biederman wrote:
>> User mode linux is the last user of the PT_DTRACE flag. Using the flag to indicate
>> single stepping is a little confusing and worse changing tsk->ptrace without locking
>> could potentionally cause problems.
>>
>> So use a thread info flag with a better name instead of flag in tsk->ptrace.
>>
>> Remove the definition PT_DTRACE as uml is the last user.
>
>
> Looks fine to me.
>
> Acked-by: Johannes Berg <[email protected]>
Thanks.
> Looking at pending patches, I don't see any conflicts from this. I'm
> guessing anyway you'll want/need to take these through some tree all
> together.
Taking them all through a single tree looks like it will be easiest.
So I am planning on taking them through my signal tree.
Now that I think of it, the lack of locking also means I want to
Cc stable.
Eric