2021-08-23 18:47:17

by Shah, Nehal-bakulchandra

Subject: [PATCH 0/2] Add DWC3 controller suppport for AMD's platforms

Newer generation of AMD's platform has DWC3 controller. Also there is
a requirement to support user space role switch control. This patch
series addresses the same.

Nehal Bakulchandra Shah (2):
usb: dwc3: pci: add support for AMD's newer generation platform.
usb: dwc3: pci add property to allow user space role switch

drivers/usb/dwc3/drd.c | 2 ++
drivers/usb/dwc3/dwc3-pci.c | 18 ++++++++++++++++++
2 files changed, 20 insertions(+)

--
2.25.1

2021-08-23 18:47:52

by Shah, Nehal-bakulchandra

Subject: [PATCH 1/2] usb: dwc3: pci: add support for AMD's newer generation platform.

AMD's latest platforms has DWC3 controller. Add the PCI ID and
properties for the same.

Signed-off-by: Nehal Bakulchandra Shah <[email protected]>
---
drivers/usb/dwc3/dwc3-pci.c | 17 +++++++++++++++++
1 file changed, 17 insertions(+)

diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci.c
index 2b37bdd39a74..7ff8fc8f79a9 100644
--- a/drivers/usb/dwc3/dwc3-pci.c
+++ b/drivers/usb/dwc3/dwc3-pci.c
@@ -44,6 +44,7 @@
#define PCI_DEVICE_ID_INTEL_ADLM 0x54ee
#define PCI_DEVICE_ID_INTEL_ADLS 0x7ae1
#define PCI_DEVICE_ID_INTEL_TGL 0x9a15
+#define PCI_DEVICE_ID_AMD_MR 0x163a

#define PCI_INTEL_BXT_DSM_GUID "732b85d5-b7a7-4a1b-9ba0-4bbd00ffd511"
#define PCI_INTEL_BXT_FUNC_PMU_PWR 4
@@ -148,6 +149,14 @@ static const struct property_entry dwc3_pci_amd_properties[] = {
{}
};

+static const struct property_entry dwc3_pci_mr_properties[] = {
+ PROPERTY_ENTRY_STRING("dr_mode", "otg"),
+ PROPERTY_ENTRY_BOOL("usb-role-switch"),
+ PROPERTY_ENTRY_STRING("role-switch-default-mode", "host"),
+ PROPERTY_ENTRY_BOOL("linux,sysdev_is_parent"),
+ {}
+};
+
static const struct software_node dwc3_pci_intel_swnode = {
.properties = dwc3_pci_intel_properties,
};
@@ -160,6 +169,10 @@ static const struct software_node dwc3_pci_amd_swnode = {
.properties = dwc3_pci_amd_properties,
};

+static const struct software_node dwc3_pci_amd_mr_swnode = {
+ .properties = dwc3_pci_mr_properties,
+};
+
static int dwc3_pci_quirks(struct dwc3_pci *dwc)
{
struct pci_dev *pdev = dwc->pci;
@@ -401,6 +414,10 @@ static const struct pci_device_id dwc3_pci_id_table[] = {

{ PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_NL_USB),
(kernel_ulong_t) &dwc3_pci_amd_swnode, },
+
+ { PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_MR),
+ (kernel_ulong_t)&dwc3_pci_amd_mr_swnode, },
+
{ } /* Terminating Entry */
};
MODULE_DEVICE_TABLE(pci, dwc3_pci_id_table);
--
2.25.1

2021-08-24 08:23:35

by Felipe Balbi

Subject: Re: [PATCH 1/2] usb: dwc3: pci: add support for AMD's newer generation platform.

Nehal Bakulchandra Shah <[email protected]> writes:

> AMD's latest platforms has DWC3 controller. Add the PCI ID and
> properties for the same.
>
> Signed-off-by: Nehal Bakulchandra Shah <[email protected]>

Acked-by: Felipe Balbi <[email protected]>

--
balbi