2019-08-19 16:38:56

by Nathan Lynch

[permalink] [raw]
Subject: Re: [PATCH] powerpc/vdso32: Add support for CLOCK_{REALTIME/MONOTONIC}_COARSE

Hi,

Christophe Leroy <[email protected]> writes:
> Benchmark from vdsotest:

I assume you also ran the verification/correctness parts of vdsotest...? :-)



2019-08-19 20:34:57

by Christophe Leroy

[permalink] [raw]
Subject: Re: [PATCH] powerpc/vdso32: Add support for CLOCK_{REALTIME/MONOTONIC}_COARSE

Hi,

Le 19/08/2019 à 18:37, Nathan Lynch a écrit :
> Hi,
>
> Christophe Leroy <[email protected]> writes:
>> Benchmark from vdsotest:
>
> I assume you also ran the verification/correctness parts of vdsotest...? :-)
>

I did run vdsotest-all. I guess it runs the verifications too ?

Christophe

2019-08-19 22:35:49

by Nathan Lynch

[permalink] [raw]
Subject: Re: [PATCH] powerpc/vdso32: Add support for CLOCK_{REALTIME/MONOTONIC}_COARSE

Christophe Leroy <[email protected]> writes:

> Hi,
>
> Le 19/08/2019 à 18:37, Nathan Lynch a écrit :
>> Hi,
>>
>> Christophe Leroy <[email protected]> writes:
>>> Benchmark from vdsotest:
>>
>> I assume you also ran the verification/correctness parts of vdsotest...? :-)
>>
>
> I did run vdsotest-all. I guess it runs the verifications too ?

It does, but at a quick glance it runs the validation for "only" 1
second per API. It may provide more confidence to allow the validation
to run across several second (tv_sec) transitions, e.g.

vdsotest -d 30 clock-gettime-monotonic-coarse verify

Regardless, I did not see any problem with your patch.