2009-10-01 14:28:09

by Hemant Pedanekar

Subject: [PATCH] mtd: nand: davinci: fix to use mask_ale from pdata

Correct typo to use mask_ale from platform data when set to non-zero.

Signed-off-by: Hemant Pedanekar <[email protected]>
---
drivers/mtd/nand/davinci_nand.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/mtd/nand/davinci_nand.c b/drivers/mtd/nand/davinci_nand.c
index 0fad648..20b04a2 100644
--- a/drivers/mtd/nand/davinci_nand.c
+++ b/drivers/mtd/nand/davinci_nand.c
@@ -571,7 +571,7 @@ static int __init nand_davinci_probe(struct platform_device *pdev)
info->mask_chipsel = pdata->mask_chipsel;

/* use nandboot-capable ALE/CLE masks by default */
- info->mask_ale = pdata->mask_cle ? : MASK_ALE;
+ info->mask_ale = pdata->mask_ale ? : MASK_ALE;
info->mask_cle = pdata->mask_cle ? : MASK_CLE;

/* Set address of hardware control function */
--
1.6.2.4

2009-10-08 15:16:51

by Kevin Hilman

Subject: Re: [PATCH] mtd: nand: davinci: fix to use mask_ale from pdata

Hemant Pedanekar <[email protected]> writes:

> Correct typo to use mask_ale from platform data when set to non-zero.
>
> Signed-off-by: Hemant Pedanekar <[email protected]>

Signed-off-by: Kevin Hilman <[email protected]>

Could this fix be queued for the .32-rc series please?

Thanks,

Kevin

> ---
> drivers/mtd/nand/davinci_nand.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mtd/nand/davinci_nand.c b/drivers/mtd/nand/davinci_nand.c
> index 0fad648..20b04a2 100644
> --- a/drivers/mtd/nand/davinci_nand.c
> +++ b/drivers/mtd/nand/davinci_nand.c
> @@ -571,7 +571,7 @@ static int __init nand_davinci_probe(struct platform_device *pdev)
> info->mask_chipsel = pdata->mask_chipsel;
>
> /* use nandboot-capable ALE/CLE masks by default */
> - info->mask_ale = pdata->mask_cle ? : MASK_ALE;
> + info->mask_ale = pdata->mask_ale ? : MASK_ALE;
> info->mask_cle = pdata->mask_cle ? : MASK_CLE;
>
> /* Set address of hardware control function */
> --
> 1.6.2.4
>
> _______________________________________________
> Davinci-linux-open-source mailing list
> [email protected]
> http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source

2009-10-08 15:39:13

by Narnakaje, Snehaprabha

Subject: RE: [PATCH] mtd: nand: davinci: fix to use mask_ale from pdata

Andrew,

Could you please apply this patch to the -mm tree and thus queue it up for 2.6.32-rc series?

Thanks
Sneha

> -----Original Message-----
> From: [email protected]
> [mailto:[email protected]] On Behalf
> Of Kevin Hilman
> Sent: Thursday, October 08, 2009 11:16 AM
> To: Pedanekar, Hemant
> Cc: [email protected]; davinci-linux-open-
> [email protected]; [email protected]; linux-
> [email protected]; [email protected]; [email protected];
> [email protected]
> Subject: Re: [PATCH] mtd: nand: davinci: fix to use mask_ale from pdata
>
> Hemant Pedanekar <[email protected]> writes:
>
> > Correct typo to use mask_ale from platform data when set to non-zero.
> >
> > Signed-off-by: Hemant Pedanekar <[email protected]>
>
> Signed-off-by: Kevin Hilman <[email protected]>
>
> Could this fix be queued for the .32-rc series please?
>
> Thanks,
>
> Kevin
>
> > ---
> > drivers/mtd/nand/davinci_nand.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/mtd/nand/davinci_nand.c
> b/drivers/mtd/nand/davinci_nand.c
> > index 0fad648..20b04a2 100644
> > --- a/drivers/mtd/nand/davinci_nand.c
> > +++ b/drivers/mtd/nand/davinci_nand.c
> > @@ -571,7 +571,7 @@ static int __init nand_davinci_probe(struct
> platform_device *pdev)
> > info->mask_chipsel = pdata->mask_chipsel;
> >
> > /* use nandboot-capable ALE/CLE masks by default */
> > - info->mask_ale = pdata->mask_cle ? : MASK_ALE;
> > + info->mask_ale = pdata->mask_ale ? : MASK_ALE;
> > info->mask_cle = pdata->mask_cle ? : MASK_CLE;
> >
> > /* Set address of hardware control function */
> > --
> > 1.6.2.4
> >
> > _______________________________________________
> > Davinci-linux-open-source mailing list
> > [email protected]
> > http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
>
> _______________________________________________
> Davinci-linux-open-source mailing list
> [email protected]
> http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source

2009-10-09 04:19:44

by Artem Bityutskiy

Subject: Re: [PATCH] mtd: nand: davinci: fix to use mask_ale from pdata

On 10/08/2009 06:37 PM, ext Narnakaje, Snehaprabha wrote:
> Andrew,
>
> Could you please apply this patch to the -mm tree and thus queue it up for 2.6.32-rc series?

FYI, this patch is already in the mtd-2.6.git tree. So you should bug
dwmw2 to push it to rc3

--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)