2008-01-16 15:16:23

by Johannes Weiner

[permalink] [raw]
Subject: Re: [patch for 2.6.24? 1/1] cpufreq: Initialise default governor before use

Hi,

Ingo Molnar <[email protected]> writes:

> * [email protected] <[email protected]> wrote:
>
>> +#ifdef CONFIG_CPU_FREQ_DEFAULT_GOV_CONSERVATIVE
>> +fs_initcall(cpufreq_gov_dbs_init);
>> +#else
>> module_init(cpufreq_gov_dbs_init);
>> +#endif
>
> silly question: why not unconditional fs_initcall() ?

Would there be a way to avoid the fs_initcall at all?

Otherwise, this is just a psychological thing to show, hey, this still
sucks, find a better solution. But perhaps the plain fs_initcall is
marker enough for that fact.

Hannes