2001-11-19 08:33:18

by Mark Orr

[permalink] [raw]
Subject: [2.4.15pre6] Funny error on "make modules_install" - cosmetic cleanup probably needed


I'm running 2.4.15-pre6 here, and for several previous
versions there's been an unusual (but harmless) error message
when installing modules via "make modules_install" once the
kernel build is done.

looks like this:

make[2]: Entering directory `/usr/src/linux/drivers/cdrom'
mkdir -p /lib/modules/2.4.15-pre6/kernel/drivers/cdrom/
cp cdrom.o cdrom.o /lib/modules/2.4.15-pre6/kernel/drivers/cdrom/
cp: will not overwrite just-created `/lib/modules/2.4.15-pre6/kernel/drivers/cdrom/cdrom.o' with `cdrom.o'
make[2]: *** [_modinst__] Error 1
make[2]: Leaving directory `/usr/src/linux/drivers/cdrom'
make[1]: *** [_modinst_cdrom] Error 2
make[1]: Leaving directory `/usr/src/linux/drivers'
make: *** [_modinst_drivers] Error 2

...As I say, it's harmless. cdrom.o is getting installed, and
you can just make -i ... to get past it.

I'm guessing that I'm the only one getting this error (since I
cant find any other complaints about it) because i'm using the
latest fileutils v4.1.1 off alpha.gnu.org, which must have code
to complain about such things -- but still, that

cp cdrom.o cdrom.o /big/long/directory

...just looks weird. Somebody leave something hanging in
one of the makefiles?

--
Mark Orr
[email protected]



2001-11-19 12:45:25

by Keith Owens

[permalink] [raw]
Subject: Re: [2.4.15pre6] Funny error on "make modules_install" - cosmetic cleanup probably needed

On Mon, 19 Nov 2001 02:32:58 -0600,
Mark Orr <[email protected]> wrote:
>make[2]: Entering directory `/usr/src/linux/drivers/cdrom'
>mkdir -p /lib/modules/2.4.15-pre6/kernel/drivers/cdrom/
>cp cdrom.o cdrom.o /lib/modules/2.4.15-pre6/kernel/drivers/cdrom/
>cp: will not overwrite just-created `/lib/modules/2.4.15-pre6/kernel/drivers/cdrom/cdrom.o' with `cdrom.o'

There are several places where a module gets installed twice, because
of the way that module objects are selected in 2.4 (2.5 does not have
this feature). The fix is easy but it should not be necessary. IMNSHO
it is *wrong* for fileutils to decide that it will not copy a file
twice, cp should do what the user asked. Complain to the fileutils
maintainer as a first step.

Work around for unexpected cp behaviour, against 2.4.14, untested.

Index: 14.1/Rules.make
--- 14.1/Rules.make Wed, 07 Mar 2001 23:04:43 +1100 kaos (linux-2.4/T/c/47_Rules.make 1.1.2.2 644)
+++ 14.1(w)/Rules.make Mon, 19 Nov 2001 23:42:58 +1100 kaos (linux-2.4/T/c/47_Rules.make 1.1.2.2 644)
@@ -173,7 +173,7 @@ modules: $(ALL_MOBJS) dummy \
_modinst__: dummy
ifneq "$(strip $(ALL_MOBJS))" ""
mkdir -p $(MODLIB)/kernel/$(MOD_DESTDIR)
- cp $(ALL_MOBJS) $(MODLIB)/kernel/$(MOD_DESTDIR)$(MOD_TARGET)
+ cp $(sort $(ALL_MOBJS)) $(MODLIB)/kernel/$(MOD_DESTDIR)$(MOD_TARGET)
endif

.PHONY: modules_install



2001-11-21 14:26:16

by Todd M. Roy

[permalink] [raw]
Subject: Re: [2.4.15pre6] Funny error on "make modules_install" - cosmetic cleanup probably needed

I noticed this problem with the latest version of fileutils
from alpha.gnu.org, (fileutils-4.1.1.tar.bz2) I reverted to 4.1
and the problem disappeared.

-- todd --


> X-RocketRCL: 1598;1;2282498317
> X-Apparently-To: [email protected] via web13602.mail.yahoo.com; 19 Nov 2001 04:49:52 -0800 (PST)
> X-Yahoo-Received: from mux1.sc5.mail.yahoo.com
> by web13602.mail.yahoo.com; 19 Nov 2001 04:49:52 -0800 (PST)
> X-Yahoo-Received: from mta431.mail.yahoo.com
> by mux1.sc5.mail.yahoo.com; 19 Nov 2001 04:49:52 -0800 (PST)
> X-Yahoo-Forwarded: from [email protected] to [email protected]
> X-Yahoo-Forwarded: from [email protected] to [email protected]
> X-Yahoo-Forwarded: from [email protected] to [email protected]
> X-Yahoo-Forwarded: from [email protected] to [email protected]
> X-Yahoo-MsgId: <mta431.mail.yahoo.com.1006174190.94912.0000>
> X-Track: 1: 40
> From: Keith Owens <[email protected]>
> Cc: [email protected]
> Date: Mon, 19 Nov 2001 23:44:50 +1100
> Sender: [email protected]
> X-Mailing-List: [email protected]
>
> On Mon, 19 Nov 2001 02:32:58 -0600,
> Mark Orr <[email protected]> wrote:
> >make[2]: Entering directory `/usr/src/linux/drivers/cdrom'
> >mkdir -p /lib/modules/2.4.15-pre6/kernel/drivers/cdrom/
> >cp cdrom.o cdrom.o /lib/modules/2.4.15-pre6/kernel/drivers/cdrom/
> >cp: will not overwrite just-created `/lib/modules/2.4.15-pre6/kernel/drivers/cdrom/cdrom.o' with `cdrom.o'
>
> There are several places where a module gets installed twice, because
> of the way that module objects are selected in 2.4 (2.5 does not have
> this feature). The fix is easy but it should not be necessary. IMNSHO
> it is *wrong* for fileutils to decide that it will not copy a file
> twice, cp should do what the user asked. Complain to the fileutils
> maintainer as a first step.
>
> Work around for unexpected cp behaviour, against 2.4.14, untested.
>
> Index: 14.1/Rules.make
> --- 14.1/Rules.make Wed, 07 Mar 2001 23:04:43 +1100 kaos (linux-2.4/T/c/47_Rules.make 1.1.2.2 644)
> +++ 14.1(w)/Rules.make Mon, 19 Nov 2001 23:42:58 +1100 kaos (linux-2.4/T/c/47_Rules.make 1.1.2.2 644)
> @@ -173,7 +173,7 @@ modules: $(ALL_MOBJS) dummy \
> _modinst__: dummy
> ifneq "$(strip $(ALL_MOBJS))" ""
> mkdir -p $(MODLIB)/kernel/$(MOD_DESTDIR)
> - cp $(ALL_MOBJS) $(MODLIB)/kernel/$(MOD_DESTDIR)$(MOD_TARGET)
> + cp $(sort $(ALL_MOBJS)) $(MODLIB)/kernel/$(MOD_DESTDIR)$(MOD_TARGET)
> endif
>
> .PHONY: modules_install
>
>
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>

2001-11-22 16:39:50

by Jim Meyering

[permalink] [raw]
Subject: Re: [2.4.15pre6] Funny error on "make modules_install" - cosmetic cleanup probably needed

Thanks for the report.
That will be fixed in fileutils-4.1.2.

"Todd M. Roy" <[email protected]> wrote:
> I noticed this problem with the latest version of fileutils
> from alpha.gnu.org, (fileutils-4.1.1.tar.bz2) I reverted to 4.1
> and the problem disappeared.
...
[`cp a a d/' now fails]