2024-03-12 11:22:40

by Thomas Weißschuh

Subject: [PATCH] ALSA: aaci: Delete unused variable in aaci_do_suspend

The variable aaci is not used anymore and can be deleted.

Fixes: 792a6c51875c ("[ALSA] Fix PM support")
Signed-off-by: Thomas Weißschuh <[email protected]>
---
Note: This only seems to trigger with the series
"ALSA: Clean up with DEFINE_SIMPLE_DEV_PM_OPS()" applied.

(Encountered on next-20240312)

[0] https://lore.kernel.org/all/[email protected]/
---
sound/arm/aaci.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/sound/arm/aaci.c b/sound/arm/aaci.c
index 0817ad21af74..2bfffdd33864 100644
--- a/sound/arm/aaci.c
+++ b/sound/arm/aaci.c
@@ -740,7 +740,6 @@ static const struct snd_pcm_ops aaci_capture_ops = {
#ifdef CONFIG_PM
static int aaci_do_suspend(struct snd_card *card)
{
- struct aaci *aaci = card->private_data;
snd_power_change_state(card, SNDRV_CTL_POWER_D3cold);
return 0;
}

---
base-commit: 90d35da658da8cff0d4ecbb5113f5fac9d00eb72
change-id: 20240312-aaci-unused-d74171092e50

Best regards,
--
Thomas Weißschuh <[email protected]>

2024-03-12 11:31:40

by Takashi Iwai

Subject: Re: [PATCH] ALSA: aaci: Delete unused variable in aaci_do_suspend

On Tue, 12 Mar 2024 12:22:28 +0100,
Thomas Wei?schuh wrote:
>
> The variable aaci is not used anymore and can be deleted.
>
> Fixes: 792a6c51875c ("[ALSA] Fix PM support")
> Signed-off-by: Thomas Wei?schuh <[email protected]>
> ---
> Note: This only seems to trigger with the series
> "ALSA: Clean up with DEFINE_SIMPLE_DEV_PM_OPS()" applied.
>
> (Encountered on next-20240312)
>
> [0] https://lore.kernel.org/all/[email protected]/

Thanks, applied now.


Takashi